[Libreoffice-commits] core.git: jvmfwk/source

Stephan Bergmann sbergman at redhat.com
Mon May 29 09:26:48 UTC 2017


On 05/28/2017 12:11 PM, David Ostrovsky wrote:
> On Fri May 19 20:10:43 UTC 2017, Stephan Bergmann wrote:
>> New commits:
>> commit 957874168491f4b030fda85c65dd969aae82a670
>> Author: Stephan Bergmann <sbergman at redhat.com>
>> Date:   Fri May 19 22:10:19 2017 +0200
>>
>>     loplugin:stringcopy
>>     
>>     Change-Id: I04e3faf18cd6dae39d948cfb3dd0834dd96751b1
>>
>> diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
>> index 353eab37ba6f..19c3e1b1f44c 100644
>> --- a/jvmfwk/source/elements.cxx
>> +++ b/jvmfwk/source/elements.cxx
>> @@ -260,7 +260,7 @@ void NodeJava::load()
>>              {
>>                  CXmlCharPtr sUser(xmlNodeListGetString(
>>                      docUser, cur->children, 1));
>> -                m_userClassPath =
> boost::optional<OUString>>(OUString(sUser));
>> +                m_userClassPath = boost::optional<OUString>(sUser);
>>              }
>>          }
>>          else if (xmlStrcmp(cur->name, reinterpret_cast<xmlChar const
> *>("javaInfo")) == 0)
> 
> This doesn't compile against system boost 1.54.0 here: [1].

<https://cgit.freedesktop.org/libreoffice/core/commit/?id=0bebf37bac076a56801ef7d1c113f729b12b9f46> 
"Revert 'loplugin:stringcopy'"


More information about the LibreOffice mailing list