Gerrit review blocked on "Needs Code-Style"
Stephan Bergmann
sbergman at redhat.com
Tue Nov 7 22:25:26 UTC 2017
Why is <https://gerrit.libreoffice.org/#/c/44418/> "Suppress
loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and
which I at least cannot override via some +1 reply)? What's going on in
our Gerrit?
(Should that be an attempt at implementing the Gerrit-side clang-format
enforcement: Note that that commit, while including a new source file
compilerplugins/clang/test/unnecessaryoverride.cxx that should be
clang-format--enforced, also includes a fix to .clang-format necessary
to keep that source file's Clang -verify comments intact. Could it be
that Gerrit checks clang-format on that source file with a stale
.clang-format?)
More information about the LibreOffice
mailing list