New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1422233:  Error handling issues  (CHECKED_RETURN)
/sw/source/core/txtnode/thints.cxx: 1292 in SwTextNode::InsertHint(SwTextAttr *, SetAttrMode)()


________________________________________________________________________________________________________
*** CID 1422233:  Error handling issues  (CHECKED_RETURN)
/sw/source/core/txtnode/thints.cxx: 1292 in SwTextNode::InsertHint(SwTextAttr *, SetAttrMode)()
1286                         // Need to insert char first, because SetAnchor() reads
1287                         // GetStart().
1288                         //JP 11.05.98: if the anchor is already set correctly,
1289                         // fix it after inserting the char, so that clients don't
1290                         // have to worry about it.
1291                         const SwFormatAnchor* pAnchor = nullptr;
>>>     CID 1422233:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "GetItemState" without checking return value (as is done elsewhere 71 out of 74 times).
1292                         pFormat->GetItemState( RES_ANCHOR, false,
1293                             reinterpret_cast<const SfxPoolItem**>(&pAnchor) );
1294     
1295                         SwIndex aIdx( this, pAttr->GetStart() );
1296                         const OUString c(GetCharOfTextAttr(*pAttr));
1297                         OUString const ins( InsertText(c, aIdx, nInsertFlags) );

** CID 1422232:    (NEGATIVE_RETURNS)
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()


________________________________________________________________________________________________________
*** CID 1422232:    (NEGATIVE_RETURNS)
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()
750                         (*pCols)[ nInsCol ] = pCol;
751                     }
752                     else
753                         pCol = it->second;
754     
755                     sal_uInt32 nInsRow = static_cast<sal_uInt32>(bNoGlue ? nNoGlueRow : nRow1);
>>>     CID 1422232:    (NEGATIVE_RETURNS)
>>>     Unsigned variable "nInsRow" is incremented, which might cause an integer overflow.
756                     for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow, ++nInsRow)
757                     {
758                         ScSingleRefData aCellData;
759                         aCellData.InitFlags();
760                         aCellData.SetFlag3D(true);
761                         aCellData.SetColRel(false);
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()
750                         (*pCols)[ nInsCol ] = pCol;
751                     }
752                     else
753                         pCol = it->second;
754     
755                     sal_uInt32 nInsRow = static_cast<sal_uInt32>(bNoGlue ? nNoGlueRow : nRow1);
>>>     CID 1422232:    (NEGATIVE_RETURNS)
>>>     Unsigned variable "nInsRow" is incremented, which might cause an integer overflow.
756                     for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow, ++nInsRow)
757                     {
758                         ScSingleRefData aCellData;
759                         aCellData.InitFlags();
760                         aCellData.SetFlag3D(true);
761                         aCellData.SetColRel(false);
/sc/source/ui/unoobj/chart2uno.cxx: 756 in <unnamed>::Chart2Positioner::createPositionMap()()
750                         (*pCols)[ nInsCol ] = pCol;
751                     }
752                     else
753                         pCol = it->second;
754     
755                     sal_uInt32 nInsRow = static_cast<sal_uInt32>(bNoGlue ? nNoGlueRow : nRow1);
>>>     CID 1422232:    (NEGATIVE_RETURNS)
>>>     Unsigned variable "nInsRow" is incremented, which might cause an integer overflow.
756                     for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow, ++nInsRow)
757                     {
758                         ScSingleRefData aCellData;
759                         aCellData.InitFlags();
760                         aCellData.SetFlag3D(true);
761                         aCellData.SetColRel(false);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpypiAT9kCcc7BIf-2FyhYSkycIvC9OEcF78Pe2g4bqfwvtaxfdi100dcm3DSJ-2Bmm9j8fXtjcJ6unjciJT0JSCXP1ccCDhIOwvFcylxbgliIGEoRmouzm9X9e7tf5J5CGEfmTHsl63COzoV3Ew1IEiRj8rzrWCaDu47jwPUEV9XPLv-2FI-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpypiAT9kCcc7BIf-2FyhYSkycG9mESL-2BJhIKw9Ui-2FTK-2FTm-2FS65ka-2BwiFBTqg1rAkz813n5Y5Emt7xFp-2FQAyjPONgH5wiDjMiaG7jLGxuG0KlHdS86uLVs7NNE5mKN9I3MSGSPp-2F46FKyd8fCfR3KXIqLXAi9RuvOST0Y-2BYQ8xw9Xl28-3D