New Defects reported by Coverity Scan for LibreOffice

[Stephan Bergmann]

On 11/28/2017 04:30 AM, scan-admin at coverity.com wrote:
> ** CID 1424265:  Parse warnings  (PARSE_ERROR)
> /sc/source/ui/miscdlgs/dataproviderdlg.cxx: 223 in ()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 1424265:  Parse warnings  (PARSE_ERROR)
> /sc/source/ui/miscdlgs/dataproviderdlg.cxx: 223 in ()
> 217         { 1, "Cancel & Quit", &ScDataProviderDlg::cancelAndQuit }
> 218     };
> 219
> 220     MenuData aColumnData[] = {
> 221         { 0, "Delete Column", &ScDataProviderDlg::deleteColumn },
> 222         { 1, "Split Column", &ScDataProviderDlg::splitColumn },
>>>>      CID 1424265:  Parse warnings  (PARSE_ERROR)
>>>>      no suitable constructor exists to convert from "void (ScDataProviderDlg::*)()" to "std::function<void (ScDataProviderDlg *)>"
> 223         { 2, "Merge Columns", &ScDataProviderDlg::mergeColumns },
> 224     };
> 225
> 226     class ScDataTransformationBaseControl : public VclContainer,
> 227                                         public VclBuilderContainer
> 228     {

That's apparently a bug in Coverity Scan; std::functions's

   template<class F> function(F f);

constructor template is eligible here, as void (ScDataProviderDlg::*)() 
is Lvalue-Callable for argument types ScDataProviderDlg* and return type 
void.