New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
24 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1424325:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdograf.cxx: 378 in SdrGrafObj::SdrGrafObj(const Graphic &, const tools::Rectangle &)()


________________________________________________________________________________________________________
*** CID 1424325:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdograf.cxx: 378 in SdrGrafObj::SdrGrafObj(const Graphic &, const tools::Rectangle &)()
372         mbLineIsOutsideGeometry = true;
373         mbInsidePaint = false;
374         mbIsPreview = false;
375     
376         // #i25616#
377         mbSupportTextIndentingOnLineWidthChange = false;
>>>     CID 1424325:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbIsSignatureLineCanAddComment" is not initialized in this constructor nor in any functions that it calls.
378     }
379     
380     SdrGrafObj::SdrGrafObj( const Graphic& rGrf )
381     :   SdrRectObj(),
382         pGraphicLink    ( nullptr ),
383         bMirrored       ( false )

** CID 1424324:    (UNCAUGHT_EXCEPT)
/editeng/source/uno/unonrule.cxx: 476 in SvxCreateNumRule(const SvxNumRule *)()
/editeng/source/uno/unonrule.cxx: 476 in SvxCreateNumRule(const SvxNumRule *)()


________________________________________________________________________________________________________
*** CID 1424324:    (UNCAUGHT_EXCEPT)
/editeng/source/uno/unonrule.cxx: 476 in SvxCreateNumRule(const SvxNumRule *)()
470         if( pRule == nullptr )
471             throw IllegalArgumentException();
472     
473         return pRule->getNumRule();
474     }
475     
>>>     CID 1424324:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
476     css::uno::Reference< css::container::XIndexReplace > SvxCreateNumRule( const SvxNumRule* pRule ) throw()
477     {
478         DBG_ASSERT( pRule, "No default SvxNumRule!" );
479         if( pRule )
480         {
481             return new SvxUnoNumberingRules( *pRule );
/editeng/source/uno/unonrule.cxx: 476 in SvxCreateNumRule(const SvxNumRule *)()
470         if( pRule == nullptr )
471             throw IllegalArgumentException();
472     
473         return pRule->getNumRule();
474     }
475     
>>>     CID 1424324:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
476     css::uno::Reference< css::container::XIndexReplace > SvxCreateNumRule( const SvxNumRule* pRule ) throw()
477     {
478         DBG_ASSERT( pRule, "No default SvxNumRule!" );
479         if( pRule )
480         {
481             return new SvxUnoNumberingRules( *pRule );

** CID 1424323:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdograf.cxx: 402 in SdrGrafObj::SdrGrafObj(const Graphic &)()


________________________________________________________________________________________________________
*** CID 1424323:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdograf.cxx: 402 in SdrGrafObj::SdrGrafObj(const Graphic &)()
396         mbLineIsOutsideGeometry = true;
397         mbInsidePaint = false;
398         mbIsPreview = false;
399     
400         // #i25616#
401         mbSupportTextIndentingOnLineWidthChange = false;
>>>     CID 1424323:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbIsSignatureLineCanAddComment" is not initialized in this constructor nor in any functions that it calls.
402     }
403     
404     SdrGrafObj::~SdrGrafObj()
405     {
406         delete pGraphic;
407         delete mpReplacementGraphic;

** CID 1424322:  Uninitialized members  (UNINIT_CTOR)
/oox/source/vml/vmlshape.cxx: 260 in oox::vml::ShapeModel::ShapeModel()()


________________________________________________________________________________________________________
*** CID 1424322:  Uninitialized members  (UNINIT_CTOR)
/oox/source/vml/vmlshape.cxx: 260 in oox::vml::ShapeModel::ShapeModel()()
254     {
255     }
256     
257     ShapeModel::ShapeModel() :
258         mbIsSignatureLine(false)
259     {
>>>     CID 1424322:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbSignatureLineCanAddComment" is not initialized in this constructor nor in any functions that it calls.
260     }
261     
262     ShapeModel::~ShapeModel()
263     {
264     }
265     

** CID 1424321:  Null pointer dereferences  (FORWARD_NULL)
/oox/source/export/vmlexport.cxx: 673 in oox::vml::VMLExport::Commit(EscherPropertyContainer &, const tools::Rectangle &)()


________________________________________________________________________________________________________
*** CID 1424321:  Null pointer dereferences  (FORWARD_NULL)
/oox/source/export/vmlexport.cxx: 673 in oox::vml::VMLExport::Commit(EscherPropertyContainer &, const tools::Rectangle &)()
667                             // Get signature line graphic
668                             const uno::Reference<graphic::XGraphic> xGraphic
669                                 = pSdrGrafObj->getSignatureLineUnsignedGraphic();
670                             Graphic aGraphic(xGraphic);
671     
672                             BitmapChecksum nChecksum = aGraphic.GetChecksum();
>>>     CID 1424321:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "this->m_pTextExport" to "FindRelId", which dereferences it. (The dereference happens because this is a virtual function call.)
673                             OUString aImageId = m_pTextExport->FindRelId(nChecksum);
674                             if (aImageId.isEmpty())
675                             {
676                                 aImageId = m_pTextExport->GetDrawingML().WriteImage(aGraphic);
677                                 m_pTextExport->CacheRelId(nChecksum, aImageId);
678                             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyaHB-2Fss9Cf7eILZoxIPI8RnnIaP8MTUy0uB1s-2BpKC3czklif-2BPRv7nF6b99FuVb7PkmUYGE0eIG08Q0qkxkBZ4hGw5MREqzLDBwU-2B8dkZER1eCp6VuBtjPFiyAyhuxqWz7ev5fRGOlQpE5JwfQpaMPF3ufJIzXphCvccqmNfeNBE-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyaHB-2Fss9Cf7eILZoxIPI8RtWeGEkIa4-2FgAUdpj1SPYK-2FCGJJ-2BmyptURopOloW8pcgI64Sz1nNokeH9gkDrRbjvGsItadtXkDkIrZdGOMgMN7Jqge4cKcFfAQ0BVs-2BD-2BQjl00K8nqQQmZfwpzh1iRBRzNE1zEq-2FazOTbh3Q6J6h3g-3D