New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Tue Apr 10 22:50:35 UTC 2018
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
25 new defect(s) introduced to LibreOffice found with Coverity Scan.
21 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 25 defect(s)
** CID 1434186: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/unodraw/unoshape.cxx: 980 in SvxShape::Notify(SfxBroadcaster &, const SfxHint &)()
________________________________________________________________________________________________________
*** CID 1434186: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/unodraw/unoshape.cxx: 980 in SvxShape::Notify(SfxBroadcaster &, const SfxHint &)()
974
975 uno::Sequence< sal_Int8 > SAL_CALL SvxShape::getImplementationId()
976 {
977 return css::uno::Sequence<sal_Int8>();
978 }
979
>>> CID 1434186: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
980 void SvxShape::Notify( SfxBroadcaster&, const SfxHint& rHint ) throw()
981 {
982 DBG_TESTSOLARMUTEX();
983 if( !HasSdrObject() )
984 return;
985
** CID 1434185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/filter/source/graphicfilter/ios2met/ios2met.cxx: 2041 in OS2METReader::ReadOrder(unsigned short, unsigned short)()
________________________________________________________________________________________________________
*** CID 1434185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/filter/source/graphicfilter/ios2met/ios2met.cxx: 2041 in OS2METReader::ReadOrder(unsigned short, unsigned short)()
2035 case GOrdSChCel: {
2036 sal_uInt8 nbyte;
2037 sal_uInt16 nLen=nOrderLen;
2038 auto nWidth = ReadCoord(bCoord32);
2039 auto nHeight = ReadCoord(bCoord32);
2040 if (nWidth < 0 || nHeight < 0 ||
>>> CID 1434185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "nWidth > 2147483647 /* std::numeric_limits<int>::max() */" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2041 nWidth > std::numeric_limits<decltype(nWidth)>::max() ||
2042 nHeight > std::numeric_limits<decltype(nHeight)>::max())
2043 {
2044 aAttr.aChrCellSize = aDefAttr.aChrCellSize;
2045 }
2046 else
** CID 1434184: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/data/postit.cxx: 875 in ScPostIt::~ScPostIt()()
________________________________________________________________________________________________________
*** CID 1434184: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/data/postit.cxx: 875 in ScPostIt::~ScPostIt()()
869 {
870 mnPostItId = nPostItId == 0 ? mnLastPostItId++ : nPostItId;
871 if( bAlwaysCreateCaption || maNoteData.mbShown )
872 CreateCaptionFromInitData( rPos );
873 }
874
>>> CID 1434184: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
875 ScPostIt::~ScPostIt()
876 {
877 RemoveCaption();
878 }
879
880 ScPostIt* ScPostIt::Clone( const ScAddress& rOwnPos, ScDocument& rDestDoc, const ScAddress& rDestPos, bool bCloneCaption ) const
** CID 1434183: Error handling issues (UNCAUGHT_EXCEPT)
/connectivity/source/commontools/statementcomposer.cxx: 243 in dbtools::StatementComposer::~StatementComposer()()
________________________________________________________________________________________________________
*** CID 1434183: Error handling issues (UNCAUGHT_EXCEPT)
/connectivity/source/commontools/statementcomposer.cxx: 243 in dbtools::StatementComposer::~StatementComposer()()
237 m_pData->sCommand = _rCommand;
238 m_pData->nCommandType = _nCommandType;
239 m_pData->bEscapeProcessing = _bEscapeProcessing;
240 }
241
242
>>> CID 1434183: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
243 StatementComposer::~StatementComposer()
244 {
245 lcl_resetComposer( *m_pData );
246 }
247
248
** CID 1434182: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 113 in chart::UndoGuardWithSelection::~UndoGuardWithSelection()()
________________________________________________________________________________________________________
*** CID 1434182: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 113 in chart::UndoGuardWithSelection::~UndoGuardWithSelection()()
107 UndoGuardWithSelection::UndoGuardWithSelection(
108 const OUString& i_undoString, const uno::Reference< document::XUndoManager >& i_undoManager )
109 :UndoGuard( i_undoString, i_undoManager, E_MODEL_WITH_SELECTION )
110 {
111 }
112
>>> CID 1434182: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
113 UndoGuardWithSelection::~UndoGuardWithSelection()
114 {
115 if ( !isActionPosted() )
116 rollback();
117 }
118
** CID 1434181: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svdpage.cxx: 87 in SdrObjList::~SdrObjList()()
________________________________________________________________________________________________________
*** CID 1434181: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svdpage.cxx: 87 in SdrObjList::~SdrObjList()()
81 bObjOrdNumsDirty=false;
82 bRectsDirty=false;
83 pOwnerObj=nullptr;
84 eListKind=SdrObjListKind::Unknown;
85 }
86
>>> CID 1434181: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
87 SdrObjList::~SdrObjList()
88 {
89 Clear(); // delete contents of container
90 }
91
92 SdrObjList* SdrObjList::CloneSdrObjList(SdrModel* pNewModel) const
** CID 1434180: Error handling issues (UNCAUGHT_EXCEPT)
/forms/source/component/cachedrowset.cxx: 75 in frm::CachedRowSet::~CachedRowSet()()
________________________________________________________________________________________________________
*** CID 1434180: Error handling issues (UNCAUGHT_EXCEPT)
/forms/source/component/cachedrowset.cxx: 75 in frm::CachedRowSet::~CachedRowSet()()
69 CachedRowSet::CachedRowSet()
70 :m_pData( new CachedRowSet_Data )
71 {
72 }
73
74
>>> CID 1434180: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
75 CachedRowSet::~CachedRowSet()
76 {
77 dispose();
78 }
79
80
** CID 1434179: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/misc/closeveto.cxx: 136 in utl::CloseVeto::~CloseVeto()()
________________________________________________________________________________________________________
*** CID 1434179: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/misc/closeveto.cxx: 136 in utl::CloseVeto::~CloseVeto()()
130 bool const hasOwnership)
131 : m_xData(new CloseVeto_Data)
132 {
133 lcl_init(*m_xData, i_closeable, hasOwnership);
134 }
135
>>> CID 1434179: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
136 CloseVeto::~CloseVeto()
137 {
138 lcl_deinit(*m_xData);
139 }
140
141 } // namespace utl
142
** CID 1434178: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 528 in utl::OConfigurationTreeRoot::commit() const()
________________________________________________________________________________________________________
*** CID 1434178: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 528 in utl::OConfigurationTreeRoot::commit() const()
522 void OConfigurationTreeRoot::clear() throw()
523 {
524 OConfigurationNode::clear();
525 m_xCommitter.clear();
526 }
527
>>> CID 1434178: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
528 bool OConfigurationTreeRoot::commit() const throw()
529 {
530 OSL_ENSURE(isValid(), "OConfigurationTreeRoot::commit: object is invalid!");
531 if (!isValid())
532 return false;
533 OSL_ENSURE(m_xCommitter.is(), "OConfigurationTreeRoot::commit: I'm a readonly node!");
** CID 1434177: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svddrgmt.cxx: 149 in SdrDragEntrySdrObject::~SdrDragEntrySdrObject()()
________________________________________________________________________________________________________
*** CID 1434177: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svddrgmt.cxx: 149 in SdrDragEntrySdrObject::~SdrDragEntrySdrObject()()
143 mbModify(bModify)
144 {
145 // add SdrObject parts to transparent overlay stuff
146 setAddToTransparent(true);
147 }
148
>>> CID 1434177: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
149 SdrDragEntrySdrObject::~SdrDragEntrySdrObject()
150 {
151 if(mpClone)
152 {
153 SdrObject::Free(mpClone);
154 }
** CID 1434176: Error handling issues (UNCAUGHT_EXCEPT)
/framework/source/fwe/helper/documentundoguard.cxx: 212 in framework::DocumentUndoGuard::~DocumentUndoGuard()()
________________________________________________________________________________________________________
*** CID 1434176: Error handling issues (UNCAUGHT_EXCEPT)
/framework/source/fwe/helper/documentundoguard.cxx: 212 in framework::DocumentUndoGuard::~DocumentUndoGuard()()
206 DocumentUndoGuard::DocumentUndoGuard( const Reference< XInterface >& i_undoSupplierComponent )
207 :m_xData( new DocumentUndoGuard_Data )
208 {
209 lcl_init( *m_xData, i_undoSupplierComponent );
210 }
211
>>> CID 1434176: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
212 DocumentUndoGuard::~DocumentUndoGuard()
213 {
214 lcl_restore( *m_xData );
215 }
216
217 } // namespace framework
218
** CID 1434175: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/unodraw/unoshape.cxx: 216 in SvxShape::~SvxShape()()
________________________________________________________________________________________________________
*** CID 1434175: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/unodraw/unoshape.cxx: 216 in SvxShape::~SvxShape()()
210 , mnLockCount(0)
211 {
212 impl_construct();
213 }
214
215
>>> CID 1434175: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
216 SvxShape::~SvxShape() throw()
217 {
218 ::SolarMutexGuard aGuard;
219
220 DBG_ASSERT( mnLockCount == 0, "Locked shape was disposed!" );
221
** CID 1434174: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 89 in chart::UndoLiveUpdateGuard::~UndoLiveUpdateGuard()()
________________________________________________________________________________________________________
*** CID 1434174: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 89 in chart::UndoLiveUpdateGuard::~UndoLiveUpdateGuard()()
83
84 UndoLiveUpdateGuard::UndoLiveUpdateGuard( const OUString& i_undoString, const uno::Reference< document::XUndoManager >& i_undoManager )
85 :UndoGuard( i_undoString, i_undoManager, E_MODEL )
86 {
87 }
88
>>> CID 1434174: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
89 UndoLiveUpdateGuard::~UndoLiveUpdateGuard()
90 {
91 if ( !isActionPosted() )
92 rollback();
93 }
94
** CID 1434173: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 262 in utl::OConfigurationNode::createNode(const rtl::OUString &) const()
________________________________________________________________________________________________________
*** CID 1434173: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 262 in utl::OConfigurationNode::createNode(const rtl::OUString &) const()
256 try { xChildComp->dispose(); } catch(Exception&) { }
257 }
258
259 return OConfigurationNode();
260 }
261
>>> CID 1434173: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
262 OConfigurationNode OConfigurationNode::createNode(const OUString& _rName) const throw()
263 {
264 Reference< XSingleServiceFactory > xChildFactory(m_xContainerAccess, UNO_QUERY);
265 OSL_ENSURE(xChildFactory.is(), "OConfigurationNode::createNode: object is invalid or read-only!");
266
267 if (xChildFactory.is()) // implies m_xContainerAccess.is()
** CID 1434172: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 101 in chart::UndoLiveUpdateGuardWithData::~UndoLiveUpdateGuardWithData()()
________________________________________________________________________________________________________
*** CID 1434172: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 101 in chart::UndoLiveUpdateGuardWithData::~UndoLiveUpdateGuardWithData()()
95 UndoLiveUpdateGuardWithData::UndoLiveUpdateGuardWithData(
96 const OUString& i_undoString, const uno::Reference< document::XUndoManager >& i_undoManager )
97 :UndoGuard( i_undoString, i_undoManager, E_MODEL_WITH_DATA )
98 {
99 }
100
>>> CID 1434172: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
101 UndoLiveUpdateGuardWithData::~UndoLiveUpdateGuardWithData()
102 {
103 if ( !isActionPosted() )
104 rollback();
105 }
106
** CID 1434171: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx: 54 in sd::framework::ConfigurationUpdaterLock::~ConfigurationUpdaterLock()()
________________________________________________________________________________________________________
*** CID 1434171: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx: 54 in sd::framework::ConfigurationUpdaterLock::~ConfigurationUpdaterLock()()
48
49 class ConfigurationUpdaterLock
50 {
51 public:
52 explicit ConfigurationUpdaterLock (ConfigurationUpdater& rUpdater)
53 : mrUpdater(rUpdater) { mrUpdater.LockUpdates(); }
>>> CID 1434171: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
54 ~ConfigurationUpdaterLock() { mrUpdater.UnlockUpdates(); }
55 private:
56 ConfigurationUpdater& mrUpdater;
57 };
58
59 //===== ConfigurationUpdater ==================================================
** CID 1434170: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svddrgmt.cxx: 1156 in SdrDragObjOwn::~SdrDragObjOwn()()
________________________________________________________________________________________________________
*** CID 1434170: Error handling issues (UNCAUGHT_EXCEPT)
/svx/source/svdraw/svddrgmt.cxx: 1156 in SdrDragObjOwn::~SdrDragObjOwn()()
1150 {
1151 // suppress full drag for some object types
1152 setSolidDraggingActive(pObj->supportsFullDrag());
1153 }
1154 }
1155
>>> CID 1434170: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
1156 SdrDragObjOwn::~SdrDragObjOwn()
1157 {
1158 if(mpClone)
1159 {
1160 SdrObject::Free(mpClone);
1161 }
** CID 1434169: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/data/dpcache.cxx: 90 in ScDPCache::~ScDPCache()()
________________________________________________________________________________________________________
*** CID 1434169: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/data/dpcache.cxx: 90 in ScDPCache::~ScDPCache()()
84 p->ClearTableData();
85 }
86 };
87
88 }
89
>>> CID 1434169: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
90 ScDPCache::~ScDPCache()
91 {
92 // Make sure no live ScDPObject instances hold reference to this cache any
93 // more.
94 mbDisposing = true;
95 std::for_each(maRefObjects.begin(), maRefObjects.end(), ClearObjectSource());
** CID 1434168: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 237 in utl::OConfigurationNode::insertNode(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> &) const()
________________________________________________________________________________________________________
*** CID 1434168: Error handling issues (UNCAUGHT_EXCEPT)
/unotools/source/config/confignode.cxx: 237 in utl::OConfigurationNode::insertNode(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> &) const()
231 OSL_FAIL("OConfigurationNode::removeNode: caught a generic exception!");
232 }
233 }
234 return false;
235 }
236
>>> CID 1434168: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
237 OConfigurationNode OConfigurationNode::insertNode(const OUString& _rName,const Reference< XInterface >& _xNode) const throw()
238 {
239 if(_xNode.is())
240 {
241 try
242 {
** CID 1434167: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 46 in chart::UndoGuard::~UndoGuard()()
________________________________________________________________________________________________________
*** CID 1434167: Error handling issues (UNCAUGHT_EXCEPT)
/chart2/source/controller/main/UndoGuard.cxx: 46 in chart::UndoGuard::~UndoGuard()()
40 ,m_aUndoString( i_undoString )
41 ,m_bActionPosted( false )
42 {
43 m_pDocumentSnapshot.reset( new ChartModelClone( m_xChartModel, i_facet ) );
44 }
45
>>> CID 1434167: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
46 UndoGuard::~UndoGuard()
47 {
48 if ( m_pDocumentSnapshot )
49 discardSnapshot();
50 }
51
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpysuFLX3swjthyCi0f1GOjFx668SRzD7Ggh5QwOPTtnym1pI8X2ebt6Q3Awud1E8rNiPLipT9ra03Qqtr7HzoR7SHDxe6-2BFnG3AlYShGeEtDZSkN1ch-2F0FFklyczMOKpgiFQL8T2z4nQAeZMLd2ZIpZZxb-2FnsoDraPBju7TVt3erM-3D
More information about the LibreOffice
mailing list