New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
16 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1438379:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/xml/xmltransformationi.cxx: 639 in ScXMLDateTimeContext::ScXMLDateTimeContext(ScXMLImport &, const rtl::Reference<sax_fastparser::FastAttributeList> &)()


________________________________________________________________________________________________________
*** CID 1438379:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/xml/xmltransformationi.cxx: 639 in ScXMLDateTimeContext::ScXMLDateTimeContext(ScXMLImport &, const rtl::Reference<sax_fastparser::FastAttributeList> &)()
633                 maType = sc::DATETIME_TRANSFORMATION_TYPE::HOUR;
634             else if (aType == "minute")
635                 maType = sc::DATETIME_TRANSFORMATION_TYPE::MINUTE;
636             else if (aType == "seconds")
637                 maType = sc::DATETIME_TRANSFORMATION_TYPE::SECOND;
638         }
>>>     CID 1438379:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "maType" is not initialized in this constructor nor in any functions that it calls.
639     }
640     
641     ScXMLDateTimeContext::~ScXMLDateTimeContext()
642     {
643         ScDocument* pDoc = GetScImport().GetDocument();
644         auto& rDataSources = pDoc->GetExternalDataMapper().getDataSources();

** CID 1438378:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/include/tools/helpers.hxx: 82 in NormAngle180<unsigned short>(T1)()


________________________________________________________________________________________________________
*** CID 1438378:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/include/tools/helpers.hxx: 82 in NormAngle180<unsigned short>(T1)()
76         return fVal > 0.0 ? static_cast<long>( fVal + 0.5 ) : -static_cast<long>( -fVal + 0.5 );
77     }
78     
79     //valid range:  (-180,180]
80     template <typename T> inline SAL_WARN_UNUSED_RESULT T NormAngle180(T angle)
81     {
>>>     CID 1438378:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "angle <= -180" is always false regardless of the values of its operands. This occurs as the logical operand of "while".
82         while (angle <= -180)
83             angle += 360;
84         while (angle > 180)
85             angle -= 360;
86         return angle;
87     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyvkC2CIkFk3Tp9ed9X4jBJwu4ElZdGXWT9uRVrwKViIH3B6RtJjFYVVkFq9Lg69-2FhRQdXuqSiOjRSJCFcmBllJloVumRe5xLN8Uljd2KgETDgQao1sz2x2dF8mcEHmbwxnV6SrnKu6ydOb87umiMPPcQ0E6MgGiJcTDO2YOAMbHc-3D