broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

[Rene Engelhard]

Hi,

On Sun, Aug 12, 2018 at 12:09:42PM +0300, Maxim Monastirsky wrote:
> On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote:
> > > I think you should use colibre *instead* of tango. My understanding
> > > is
> > 
> > No, that looks too much Windows'ishy to me.
> 
> Ah, OK. In this case it might make sense to do an upstream patch to
> copy these icons to tango, as we already did for a lot of other icons
> that were copied to tango from galaxy (see tdf#118123).
> 
> > > that colibre is at least as complete as tango, and is actively
> > > maintained unlike tango. And tango isn't even part of the fallback
> > 
> > That is not 100% true, see my paste.
> > 
> > For the desktop detection icon detection it is.
> 
> The desktop detection code you cited is about defining the *preferred*
> icon theme, not about "fallback" - which means what to do when the
> requested theme isn't found. The fallback for a complete icon theme (as
> opposed to an individual icon) is done like this:
> 
> /*static*/ OUString
> IconThemeSelector::ReturnFallback(const std::vector<IconThemeInfo>&

$ git grep ReturnFallback
source/app/IconThemeSelector.cxx:    return ReturnFallback(installedThemes);
source/app/IconThemeSelector.cxx:    return ReturnFallback(installedThemes);
source/app/IconThemeSelector.cxx:IconThemeSelector::ReturnFallback(const std::vector<IconThemeInfo>& installedThemes)

so vcl/source/app/IconThemeSelector.cxx
 
> installedThemes)
> {
>     if (!installedThemes.empty()) {
>         return installedThemes.front().GetThemeId();
>     }
>     else {
>         return FALLBACK_ICON_THEME_ID;
>     }
> }


$ git grep FALLBACK_ICON_THEME_ID
qa/cppunit/app/test_IconThemeSelector.cxx:            OUString(vcl::IconThemeSelector::FALLBACK_ICON_THEME_ID), selected);
source/app/IconThemeSelector.cxx:/*static*/ const OUStringLiteral IconThemeSelector::FALLBACK_ICON_THEME_ID("tango");
                                                                                                             ^^^^^
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

source/app/IconThemeSelector.cxx:        r = FALLBACK_ICON_THEME_ID;
source/app/IconThemeSelector.cxx:        return FALLBACK_ICON_THEME_ID;

So what is this then? Count me confused. :)

Regards,

Rene