New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1438785:  Uninitialized members  (UNINIT_CTOR)
/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx: 107 in connectivity::mysqlc::OResultSet::OResultSet(connectivity::mysqlc::OConnection &, connectivity::mysqlc::OCommonStatement *, st_mysql_res *, unsigned short)()


________________________________________________________________________________________________________
*** CID 1438785:  Uninitialized members  (UNINIT_CTOR)
/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx: 107 in connectivity::mysqlc::OResultSet::OResultSet(connectivity::mysqlc::OConnection &, connectivity::mysqlc::OCommonStatement *, st_mysql_res *, unsigned short)()
101         , m_xMetaData(nullptr)
102         , m_pResult(pResult)
103         , fieldCount(0)
104         , m_encoding(_encoding)
105     {
106         fieldCount = mysql_num_fields(pResult);
>>>     CID 1438785:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_aRow" is not initialized in this constructor nor in any functions that it calls.
107     }
108     
109     OResultSet::~OResultSet() {}
110     
111     void OResultSet::disposing()
112     {

** CID 1438784:  Uninitialized members  (UNINIT_CTOR)
/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx: 70 in connectivity::mysqlc::OConnection::OConnection(connectivity::mysqlc::MysqlCDriver &)()


________________________________________________________________________________________________________
*** CID 1438784:  Uninitialized members  (UNINIT_CTOR)
/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx: 70 in connectivity::mysqlc::OConnection::OConnection(connectivity::mysqlc::MysqlCDriver &)()
64     
65     OConnection::OConnection(MysqlCDriver& _rDriver)
66         : OMetaConnection_BASE(m_aMutex)
67         , m_xMetaData(nullptr)
68         , m_xDriver(&_rDriver)
69     {
>>>     CID 1438784:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member field "m_mysql.extension" is not initialized in this constructor nor in any functions that it calls.
70     }
71     
72     OConnection::~OConnection()
73     {
74         if (!isClosed())
75         {

** CID 1438783:  Error handling issues  (CHECKED_RETURN)
/connectivity/source/drivers/mysqlc/mysqlc_resultsetmetadata.cxx: 66 in connectivity::mysqlc::OResultSetMetaData::isCaseSensitive(int)()


________________________________________________________________________________________________________
*** CID 1438783:  Error handling issues  (CHECKED_RETURN)
/connectivity/source/drivers/mysqlc/mysqlc_resultsetmetadata.cxx: 66 in connectivity::mysqlc::OResultSetMetaData::isCaseSensitive(int)()
60         sql.append(rtl::OUString::number(pField->charsetnr));
61     
62         Reference<XStatement> stmt = m_rConnection.createStatement();
63         Reference<XResultSet> rs = stmt->executeQuery(sql.makeStringAndClear());
64         Reference<XRow> xRow(rs, UNO_QUERY_THROW);
65     
>>>     CID 1438783:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "next" without checking return value (as is done elsewhere 189 out of 196 times).
66         rs->next(); // fetch first and only row
67         rtl::OUString sColName = xRow->getString(1); // first column is Collation name
68     
69         return !sColName.isEmpty() && !sColName.endsWith("_ci");
70     }
71     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyyOwYaWC-2BsPwf18-2BUOunOC1fLUGHQiEoPHPfZ4AZbM4pRjFzQSzjJ84-2BsezUcDnIqZk6SNlhBC9LsvmBIePrsFme9rm1aDfL92Y1az1a0af3s2TIYWSGvGZMrE5r1gwvNif01WbGWfm8ZUXDt-2Blx1D4daGoXk-2B-2FEYjAHc9U0q9SM-3D