Non-portable configure.ac

[Sander Maijers]

Thanks!

Note that checkbashisms 2.17.12-1 failed to catch this when I debugged 
this issue.

https://www.archlinux.org/packages/community/any/checkbashisms/

Also note that on Arch Linux, I used dash 0.5.9.1-1, whereas Debian only 
has various older versions

https://packages.debian.org/search?keywords=dash

Running shellcheck and checkbashisms regularly is advisable even for 
autoconf generated scripts.


On 22-02-18 12:07, Eike Rathke wrote:
> Hi Sander,
>
> On Wednesday, 2018-02-21 14:03:49 +0100, Sander Maijers wrote:
>
>> I have set dash as /bin/sh.
> "Funny", because Debian has dash there as well and no problem.
>
> Anyway.. this
>
>> ./configure fails due a syntax error, since `${PRODUCTNAME// /}` not a
>> portable syntax.
> has been changed to
> PRODUCTNAME_WITHOUT_SPACES=$(printf %s "$PRODUCTNAME" | sed 's/ //g')
>
> on master.
>
>    Eike
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20180222/63142496/attachment.html>