Fwd: [Libreoffice-commits] core.git: toolkit/Module_toolkit.mk

[Michael Stahl]

On 07.01.2018 22:20, Markus Mohrhard wrote:
> New commits:
> commit 43dd63898c145ebeb918f1d6ce094cf5c68548c8
> Author: Markus Mohrhard <markus.mohrhard at googlemail.com
> <mailto:markus.mohrhard at googlemail.com>>
> Date:   Sun Jan 7 22:15:13 2018 +0100
> 
>     disable toolkit unit conversion test for now
> 
>     There seems to be a bunch of problems:
> 
>     On OSX the test crashes when no display can be found:
>    
> https://ci.libreoffice.org/job/lo_gerrit/25298/Config=macosx_clang_dbgutil/console
> <https://ci.libreoffice.org/job/lo_gerrit/25298/Config=macosx_clang_dbgutil/console>

that's a problem of that jenkins builder, i just had a libreoffice-6-0
branch build fail in the same way in CppunitTest_vcl_complextext:

https://ci.libreoffice.org/job/lo_gerrit_60/326/Config=macosx_clang_dbgutil/console

Thorsten is investigating...

>     On windows the position seems to be wrong on some boxes, e.g.:
>     D:/lode/dev/core/toolkit/qa/cppunit/UnitConversion.cxx(149) : error
> : Assertion
>     Test name: `anonymous namespace'::ToolkitTest::testXUnitConversion
>     equality assertion failed
>     - Expected: 100
>     - Actual  : 72
>     - Window pos wrong

well screw that, let's disable the test on windows, it Works-For-Me but
nobody else apparently... it's a pretty stupid test anyway... pushed
c46ab19bcab9151744527978742eeb5e34d2effe "toolkit: disable the
UnitConversion test only on WNT"