New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Tue Jan 30 11:10:31 UTC 2018


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1428737:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/view/drviews2.cxx: 887 in sd::DrawViewShell::FuTemporary(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1428737:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/view/drviews2.cxx: 887 in sd::DrawViewShell::FuTemporary(SfxRequest &)()
881             case SID_ATTR_ZOOMSLIDER:
882             {
883                 const SfxItemSet* pArgs = rReq.GetArgs();
884     
885                 if (pArgs && pArgs->Count () == 1 )
886                 {
>>>     CID 1428737:  Null pointer dereferences  (NULL_RETURNS)
>>>     Assigning: "pScale" = null return value from "GetArg".
887                     const SfxUInt16Item* pScale = rReq.GetArg<SfxUInt16Item>(SID_ATTR_ZOOMSLIDER);
888                     if (CHECK_RANGE (5, pScale->GetValue (), 3000))
889                     {
890                         SetZoom (pScale->GetValue ());
891     
892                         SfxBindings& rBindings = GetViewFrame()->GetBindings();

** CID 1428736:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/view/outlnvs2.cxx: 122 in sd::OutlineViewShell::FuTemporary(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1428736:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/view/outlnvs2.cxx: 122 in sd::OutlineViewShell::FuTemporary(SfxRequest &)()
116             case SID_ATTR_ZOOMSLIDER:
117             {
118                 const SfxItemSet* pArgs = rReq.GetArgs();
119     
120                 if (pArgs && pArgs->Count () == 1 )
121                 {
>>>     CID 1428736:  Null pointer dereferences  (NULL_RETURNS)
>>>     Assigning: "pScale" = null return value from "GetArg".
122                     const SfxUInt16Item* pScale = rReq.GetArg<SfxUInt16Item>(SID_ATTR_ZOOMSLIDER);
123                     if (CHECK_RANGE (5, pScale->GetValue (), 3000))
124                     {
125                         SetZoom (pScale->GetValue ());
126     
127                         SfxBindings& rBindings = GetViewFrame()->GetBindings();

** CID 1428735:  Insecure data handling  (TAINTED_SCALAR)
/comphelper/source/misc/lok.cxx: 129 in comphelper::LibreOfficeKit::isWhitelistedLanguage(const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1428735:  Insecure data handling  (TAINTED_SCALAR)
/comphelper/source/misc/lok.cxx: 129 in comphelper::LibreOfficeKit::isWhitelistedLanguage(const rtl::OUString &)()
123         static std::vector<OUString> aWhitelist;
124         if (!bInitialized)
125         {
126             const char* pWhitelist = getenv("LOK_WHITELIST_LANGUAGES");
127             if (pWhitelist)
128             {
>>>     CID 1428735:  Insecure data handling  (TAINTED_SCALAR)
>>>     Call to function "basic_string" with tainted argument "pWhitelist" transitively taints "<temporary>". [Note: The source code implementation of the function has been overridden by a builtin model.]
129                 std::stringstream stream(pWhitelist);
130                 std::string s;
131     
132                 std::cerr << "Whitelisted languages: ";
133                 while (getline(stream, s, ' ')) {
134                     if (s.length() == 0)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyWgcZ-2BwRrtaVyMvosh7y3DtBYd4go3-2BkZ4ooT4JKqRPlHTVqq0xGVhnj2cYydQMhmuBnU5SQZET-2Fo2uCm1djMwumNHK37f0WbMfteMRbWuub-2FjLVl9fNbGLkS12vMWiy9arh9Rh6QVDAs9uL1THnIm-2BUffw9al8FdRARNSb-2FA-2FyI-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyWgcZ-2BwRrtaVyMvosh7y3DuQQfynOZXMJI6FG-2By4kzxKYh5zkJVvvNsoIkLywn-2BhZGoBWxh7l2M-2BzEIiiZzOfaz9ws21QLZlB1lx5ps1sBdq81XDsnYdqV5btvUT2ywf8rUhw9boTiyGXuJbWAb1aqxyfJl1Tyw7VekVictvaBeA-3D



More information about the LibreOffice mailing list