New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Thu May 3 14:18:36 UTC 2018


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

8 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1435279:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/pdfwriter_impl.hxx: 606 in vcl::PDFWriterImpl::PDFGlyph::PDFGlyph(const Point &, const GlyphItem *, int, int, unsigned char, int)()


________________________________________________________________________________________________________
*** CID 1435279:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/pdfwriter_impl.hxx: 606 in vcl::PDFWriterImpl::PDFGlyph::PDFGlyph(const Point &, const GlyphItem *, int, int, unsigned char, int)()
600                       sal_Int32 nFontId,
601                       sal_uInt8 nMappedGlyphId,
602                       int nCharPos )
603             : m_aPos( rPos ), m_pGlyph(pGlyph), m_nNativeWidth( nNativeWidth ),
604               m_nMappedFontId( nFontId ), m_nMappedGlyphId( nMappedGlyphId ),
605               m_nCharPos(nCharPos)
>>>     CID 1435279:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_nCharCount" is not initialized in this constructor nor in any functions that it calls.
606             {}
607         };
608     
609         static const sal_Char* getStructureTag( PDFWriter::StructElement );
610         static const sal_Char* getAttributeTag( PDFWriter::StructAttribute eAtr );
611         static const sal_Char* getAttributeValueTag( PDFWriter::StructAttributeValue eVal );

** CID 1435278:  Resource leaks  (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 179 in BitmapMosaicFilter::execute(const BitmapEx &)()


________________________________________________________________________________________________________
*** CID 1435278:  Resource leaks  (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 179 in BitmapMosaicFilter::execute(const BitmapEx &)()
173     
174                 aBitmap = *pNewBmp;
175     
176                 aBitmap.SetPrefMapMode(aMap);
177                 aBitmap.SetPrefSize(aPrefSize);
178             }
>>>     CID 1435278:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pWriteAcc" going out of scope leaks the storage it points to.
179         }
180     
181         if (bRet)
182             return rBitmapEx;
183     
184         return BitmapEx();
185     }
186     

** CID 1435277:  Control flow issues  (DEADCODE)
/svl/source/numbers/zforfind.cxx: 1217 in ImpSvNumberInputScan::IsAcceptedDatePattern(unsigned short)()


________________________________________________________________________________________________________
*** CID 1435277:  Control flow issues  (DEADCODE)
/svl/source/numbers/zforfind.cxx: 1217 in ImpSvNumberInputScan::IsAcceptedDatePattern(unsigned short)()
1211                 xLocaleData.changeLocale( aSaveLocale);
1212                 // When concatenating don't care about duplicates, combining
1213                 // weeding those out reallocs yet another time and probably doesn't
1214                 // take less time than looping over two additional patterns below..
1215                 switch (eEDF)
1216                 {
>>>     CID 1435277:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "case NF_EVALDATEFORMAT_FORMAT:".
1217                     case NF_EVALDATEFORMAT_FORMAT:
1218                         assert(!"shouldn't reach here");
1219                     break;
1220                     case NF_EVALDATEFORMAT_INTL:
1221                         sDateAcceptancePatterns = aLocalePatterns;
1222                     break;

** CID 1435276:  Resource leaks  (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 179 in BitmapMosaicFilter::execute(const BitmapEx &)()


________________________________________________________________________________________________________
*** CID 1435276:  Resource leaks  (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 179 in BitmapMosaicFilter::execute(const BitmapEx &)()
173     
174                 aBitmap = *pNewBmp;
175     
176                 aBitmap.SetPrefMapMode(aMap);
177                 aBitmap.SetPrefSize(aPrefSize);
178             }
>>>     CID 1435276:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pNewBmp" going out of scope leaks the storage it points to.
179         }
180     
181         if (bRet)
182             return rBitmapEx;
183     
184         return BitmapEx();
185     }
186     

** CID 1435275:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/sidebar/SidebarDockingWindow.cxx: 50 in sfx2::sidebar::SidebarDockingWindow::SidebarDockingWindow(SfxBindings *, sfx2::sidebar::SidebarChildWindow &, vcl::Window *, long)()


________________________________________________________________________________________________________
*** CID 1435275:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/sidebar/SidebarDockingWindow.cxx: 50 in sfx2::sidebar::SidebarDockingWindow::SidebarDockingWindow(SfxBindings *, sfx2::sidebar::SidebarChildWindow &, vcl::Window *, long)()
44         else
45         {
46             const SfxViewFrame* pViewFrame = pSfxBindings->GetDispatcher()->GetFrame();
47             const SfxFrame& rFrame = pViewFrame->GetFrame();
48             mpSidebarController.set(sfx2::sidebar::SidebarController::create(this, rFrame.GetFrameInterface()).get());
49         }
>>>     CID 1435275:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbIsReadyToDrag" is not initialized in this constructor nor in any functions that it calls.
50     }
51     
52     SidebarDockingWindow::~SidebarDockingWindow()
53     {
54         disposeOnce();
55     }

** CID 1435274:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1435274:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 174 in BitmapMosaicFilter::execute(const BitmapEx &)()
168     
169             if (bRet)
170             {
171                 const MapMode aMap(aBitmap.GetPrefMapMode());
172                 const Size aPrefSize(aBitmap.GetPrefSize());
173     
>>>     CID 1435274:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pNewBmp" to "operator =", which dereferences it.
174                 aBitmap = *pNewBmp;
175     
176                 aBitmap.SetPrefMapMode(aMap);
177                 aBitmap.SetPrefSize(aPrefSize);
178             }
179         }

** CID 1435273:  Resource leaks  (CTOR_DTOR_LEAK)


________________________________________________________________________________________________________
*** CID 1435273:  Resource leaks  (CTOR_DTOR_LEAK)
/sfx2/source/dialog/tabdlg.cxx: 1476 in SfxTabDialogController::SfxTabDialogController(weld::Window *, const rtl::OUString &, const rtl::OString &, const SfxItemSet *, bool)()
1470         , m_pSet(pItemSet ? new SfxItemSet(*pItemSet) : nullptr)
1471         , m_pOutSet(nullptr)
1472         , m_pRanges(nullptr)
1473         , m_bStandardPushed(false)
1474         , m_pExampleSet(nullptr)
1475     {
>>>     CID 1435273:  Resource leaks  (CTOR_DTOR_LEAK)
>>>     Calling allocation function "Init_Impl".
1476         Init_Impl(bEditFmt);
1477     }
1478     
1479     void SfxTabDialogController::Init_Impl(bool /*bFmtFlag*/)
1480     {
1481         m_pImpl.reset(new TabDlg_Impl(m_xTabCtrl->get_n_pages()));

** CID 1435272:  Uninitialized members  (UNINIT_CTOR)
/sw/source/ui/envelp/envfmt.cxx: 177 in SwEnvFormatPage::SwEnvFormatPage(TabPageParent, const SfxItemSet &)()


________________________________________________________________________________________________________
*** CID 1435272:  Uninitialized members  (UNINIT_CTOR)
/sw/source/ui/envelp/envfmt.cxx: 177 in SwEnvFormatPage::SwEnvFormatPage(TabPageParent, const SfxItemSet &)()
171                 m_xSizeFormatBox->insert_text(nPos, aPaperName);
172                 m_aIDs.insert( m_aIDs.begin() + nPos, i);
173             }
174         }
175         m_xSizeFormatBox->append_text(SvxPaperInfo::GetName(PAPER_USER));
176         m_aIDs.push_back( sal_uInt16(PAPER_USER) );
>>>     CID 1435272:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_pDialog" is not initialized in this constructor nor in any functions that it calls.
177     }
178     
179     void SwEnvFormatPage::Init(SwEnvDlg* pDialog)
180     {
181         m_pDialog = pDialog;
182         m_xPreview->SetDialog(m_pDialog);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyisdY5vcTUudjwtSvvaVRNM7LG-2BgXpqL1f8S9-2F7ub2T50JzHtJRFA4tOxIhHRcSH3PFUaSeqDdhsD6PhUfvORIxMlLmDFYe3bTb1l5kPP9p5-2F9XXvJg0gWixoc0aLLAR8uHk-2FCrIRzzElcM4u78Ae8QkQEgyVzGedOICxr5TWO4A-3D



More information about the LibreOffice mailing list