New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1435839:  Uninitialized members  (UNINIT_CTOR)
/include/vcl/customweld.hxx: 21 in weld::CustomWidgetController::CustomWidgetController()()


________________________________________________________________________________________________________
*** CID 1435839:  Uninitialized members  (UNINIT_CTOR)
/include/vcl/customweld.hxx: 21 in weld::CustomWidgetController::CustomWidgetController()()
15     namespace weld
16     {
17     class VCL_DLLPUBLIC CustomWidgetController
18     {
19     private:
20         Size m_aSize;
>>>     CID 1435839:  Uninitialized members  (UNINIT_CTOR)
>>>     The compiler-generated constructor for this class does not initialize "m_pDrawingArea".
21         weld::DrawingArea* m_pDrawingArea;
22     
23     public:
24         virtual void Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRect) = 0;
25         virtual void Resize() {}
26         virtual void MouseButtonDown(const MouseEvent&) {}

** CID 1435838:  Uninitialized members  (UNINIT_CTOR)
/svx/source/dialog/dlgctrl.cxx: 664 in RectCtl::RectCtl(SvxTabPage *, RectPoint, unsigned short, unsigned short)()


________________________________________________________________________________________________________
*** CID 1435838:  Uninitialized members  (UNINIT_CTOR)
/svx/source/dialog/dlgctrl.cxx: 664 in RectCtl::RectCtl(SvxTabPage *, RectPoint, unsigned short, unsigned short)()
658         , nRadius(Application::GetDefaultDevice()->LogicToPixel(Size(nCircle, 0), MapMode(MapUnit::Map100thMM)).Width())
659         , eDefRP(eRpt)
660         , pBitmap(nullptr)
661         , m_nState(CTL_STATE::NONE)
662         , mbCompleteDisable(false)
663     {
>>>     CID 1435838:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "eRP" is not initialized in this constructor nor in any functions that it calls.
664     }
665     
666     void RectCtl::SetDrawingArea(weld::DrawingArea* pDrawingArea)
667     {
668         pDrawingArea->set_size_request(pDrawingArea->get_approximate_digit_width() * 25,
669                                        pDrawingArea->get_text_height() * 5);

** CID 1435837:  Uninitialized members  (UNINIT_CTOR)
/svx/source/dialog/charmap.cxx: 80 in SvxShowCharSet::SvxShowCharSet(weld::ScrolledWindow *, const VclPtr<VirtualDevice> &)()


________________________________________________________________________________________________________
*** CID 1435837:  Uninitialized members  (UNINIT_CTOR)
/svx/source/dialog/charmap.cxx: 80 in SvxShowCharSet::SvxShowCharSet(weld::ScrolledWindow *, const VclPtr<VirtualDevice> &)()
74         , mbUpdateForeground(true)
75         , mbUpdateBackground(true)
76     {
77         init();
78     
79         mxScrollArea->set_user_managed_scrolling();
>>>     CID 1435837:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "nY" is not initialized in this constructor nor in any functions that it calls.
80     }
81     
82     void SvxShowCharSet::SetDrawingArea(weld::DrawingArea* pDrawingArea)
83     {
84         mxScrollArea->set_size_request(COLUMN_COUNT * pDrawingArea->get_approximate_digit_width() * 4,
85                                        ROW_COUNT * pDrawingArea->get_text_height() * 2);

** CID 1078573:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1078573:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/docnode/swbaslnk.cxx: 174 in SwBaseLink::DataChanged(const rtl::OUString &, const com::sun::star::uno::Any &)()
168     
169         if ( !bUpdate || bFrameInPaint )
170             return SUCCESS;
171     
172         if (bUpdate)
173         {
>>>     CID 1078573:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pSwGrfNode" to "SetGrfFlySize", which dereferences it.
174             if (!SetGrfFlySize(aGrfSz, pSwGrfNode, aOldSz))
175             {
176                 SwMsgPoolItem aMsgHint(RES_GRAPHIC_ARRIVED);
177                 lcl_CallModify(*pSwGrfNode, aMsgHint);
178                 return SUCCESS;
179             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyfkkL4Gt7-2FUAdkX0ztjdcak8JQiLFHnf3ix4SoCLXG6ey-2F-2FFo-2BvxiztvRn-2BcMjd8TlAq5G6BfaMDbsJATMEofsoNoCLw9StlDKOAxdNTFHtZG83rh25-2F-2F0JhL3BQbi8xfhsXCNdB5L1b63Qb3G5RSmmSzeW5CGzwPRzw1IueB11s-3D