remove followed by a push_back of same var (SwSpellDialogChildWindow)

[julien2412]

Hello,

I noticed these lines:
    737         if(pCurrentTextObj)
    738         {
    739             m_pSpellState->m_aTextObjects.remove(pCurrentTextObj);
    740            
m_pSpellState->m_aTextObjects.push_back(pCurrentTextObj);
    741         }
See
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx#737

Is it a special trick so some other vars are notified or just a plain error?


Looking at the git history, it comes from a cleaning refactoring with
 de60fd06b84bc1aa080ef209b0eeb36914bd8b32 in 2010-12-17

Any thoughts?

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html