New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1441522:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1441522:  Null pointer dereferences  (FORWARD_NULL)
/svx/source/tbxctrls/fontworkgallery.cxx: 200 in svx::FontWorkGalleryDialog::insertSelectedFontwork()()
194                     // the mpSdrView that is used to insert (InsertObjectAtView below) the
195                     // cloned SdrObject.
196                     const bool bUseSpecialCalcMode(nullptr != mppSdrObject && nullptr != mpDestModel);
197                     const bool bSdrViewInsertMode(nullptr != mpSdrView);
198     
199                     // center shape on current view
>>>     CID 1441522:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "this->mpSdrView" to "GetFirstOutputDevice", which dereferences it.
200                     OutputDevice* pOutDev(mpSdrView->GetFirstOutputDevice());
201     
202                     if(pOutDev && (bUseSpecialCalcMode || bSdrViewInsertMode))
203                     {
204                         // Clone directly to target SdrModel (may be different due to user/caller (!))
205                         SdrObject* pNewObject(

** CID 1441521:  API usage errors  (INVALIDATE_ITERATOR)
/svl/source/passwordcontainer/passwordcontainer.cxx: 1280 in PasswordContainer::Notify()()


________________________________________________________________________________________________________
*** CID 1441521:  API usage errors  (INVALIDATE_ITERATOR)
/svl/source/passwordcontainer/passwordcontainer.cxx: 1280 in PasswordContainer::Notify()()
1274                     if ( m_pStorageFile )
1275                         m_pStorageFile->remove( rEntry.first, aNPIter->GetUserName() ); // remove record ( aURL, aName )
1276                 }
1277     
1278                 if( !aNPIter->HasPasswords( MEMORY_RECORD ) )
1279                 {
>>>     CID 1441521:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Using invalid iterator "std::vector<NamePassRecord, std::allocator<NamePassRecord> >::const_iterator(aNPIter)".
1280                     aNPIter = rEntry.second.erase(aNPIter);
1281                 }
1282                 else
1283                     ++aNPIter;
1284             }
1285         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyPvqYm7xQDzkVodLK1TcrkXKPdOyH620dN1PXJe81RVARFJDDBwCZPHg2q9rcCOCHpXWKxzCyug927WQjrLSJJytBCqRmTrMIfQKTNV-2BBcS5H990Z2VWkX58BzNNDQt4CB9eHPXssxwal2n7qxz-2BzDMYCO9SE82lnxETmLr-2FLiuA-3D