scary / too subtle overload

Lionel Elie Mamane lionel at mamane.lu
Thu Oct 4 15:49:01 UTC 2018


In include/svtools/brwbox.hxx:

class SVT_DLLPUBLIC BrowseBox
{
public:
    bool            IsColumnSelected( sal_uInt16 nColumnId ) const;
    // IAccessibleTableProvider
    virtual bool                    IsColumnSelected( long _nColumn ) const override;
}

Function overload based on different integer types, one virtual, the
other not. <sarcasm> What could possibly go wrong? </sarcasm>

I'm tempted to rename one of the two... if it is LibreOffice-internal
only. I'm afraid both are part of our public API, but I'm not sure how
to check that again.

Any thoughts on that?

-- 
Lionel


More information about the LibreOffice mailing list