scary / too subtle overload

toki toki.kantoor at
Fri Oct 5 10:56:28 UTC 2018

On 10/4/18 3:49 PM, Lionel Elie Mamane wrote:
> In include/svtools/brwbox.hxx:
> class SVT_DLLPUBLIC BrowseBox
> {
> public:
>     bool            IsColumnSelected( sal_uInt16 nColumnId ) const;
>     // IAccessibleTableProvider
>     virtual bool                    IsColumnSelected( long _nColumn ) const override;
> }
> Function overload based on different integer types, one virtual, the

How did you catch that?

> I'm tempted to rename one of the two... if it is LibreOffice-internal

Doesn't matter if it is internal or external. Rename at least one of
them, and when somebody screams that their code broke, explain the bug.


More information about the LibreOffice mailing list