New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Thu Oct 11 13:36:48 UTC 2018


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

7 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1440243:  Uninitialized members  (UNINIT_CTOR)
/sw/source/core/txtnode/txtedt.cxx: 746 in SwScanner::SwScanner(const SwTextNode &, const rtl::OUString &, const o3tl::strong_int<unsigned short, LanguageTypeTag> *, const ModelToViewHelper &, unsigned short, int, int, bool)()


________________________________________________________________________________________________________
*** CID 1440243:  Uninitialized members  (UNINIT_CTOR)
/sw/source/core/txtnode/txtedt.cxx: 746 in SwScanner::SwScanner(const SwTextNode &, const rtl::OUString &, const o3tl::strong_int<unsigned short, LanguageTypeTag> *, const ModelToViewHelper &, unsigned short, int, int, bool)()
740         sal_uInt16 nType, sal_Int32 nStart, sal_Int32 nEnde, bool bClp )
741         : SwScanner(
742             [&rNd](sal_Int32 const nBegin, sal_uInt16 const nScript, bool const bNoChar)
743                 { return rNd.GetLang(nBegin, bNoChar ? 0 : 1, nScript); }
744             , rText, pLang, rConvMap, nType, nStart, nEnde, bClp)
745     {
>>>     CID 1440243:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member field "m_pGetLangOfChar._M_invoker" is not initialized in this constructor nor in any functions that it calls.
746     }
747     
748     SwScanner::SwScanner(std::function<LanguageType(sal_Int32, sal_Int32, bool)> const& pGetLangOfChar,
749                          const OUString& rText, const LanguageType* pLang,
750                          const ModelToViewHelper& rConvMap, sal_uInt16 nType, sal_Int32 nStart,
751                          sal_Int32 nEnde, bool bClp)

** CID 1440242:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1440242:  Incorrect expression  (USELESS_CALL)
/vcl/unx/generic/glyphs/freetype_glyphcache.cxx: 281 in GlyphCache::InitFreetype()()
275         if( pEnv )
276             nDefaultPrioAntiAlias = pEnv[0] - '0';
277         pEnv = ::getenv( "SAL_AUTOHINTING_PRIORITY" );
278         if( pEnv )
279             nDefaultPrioAutoHint  = pEnv[0] - '0';
280     
>>>     CID 1440242:  Incorrect expression  (USELESS_CALL)
>>>     Calling "rtl::Static<std::unordered_map<char const *, std::shared_ptr<FreetypeFontFile>, rtl::CStringHash, rtl::CStringEqual, std::allocator<std::pair<char const * const, std::shared_ptr<FreetypeFontFile> > > >, <unnamed>::vclFontFileList>::get()" is only useful for its return value, which is ignored.
281         vclFontFileList::get();
282     }
283     
284     FT_Face FreetypeFont::GetFtFace() const
285     {
286         FT_Activate_Size( maSizeFT );

** CID 1440241:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1440241:  Null pointer dereferences  (FORWARD_NULL)
/svtools/source/filter/exportdialog.cxx: 951 in ExportDialog::updateControls()()
945         }
946         mxNfResolution->set_value( nResolution );
947     
948         if (mpSbCompression && mpSbCompression->get_visible() && mpNfCompression)
949             mpSbCompression->set_value(mpNfCompression->get_value());
950     
>>>     CID 1440241:  Null pointer dereferences  (FORWARD_NULL)
>>>     "GetGraphicStream" dereferences null "this->mpSbCompression".
951         GetGraphicStream();
952     
953         // updating estimated size
954         sal_Int64 nRealFileSize( mpTempStream->Tell() );
955         if ( mbIsPixelFormat )
956         {

** CID 1440240:  Error handling issues  (UNCAUGHT_EXCEPT)
/starmath/source/view.cxx: 852 in SmViewShell_Impl::SmViewShell_Impl()()


________________________________________________________________________________________________________
*** CID 1440240:  Error handling issues  (UNCAUGHT_EXCEPT)
/starmath/source/view.cxx: 852 in SmViewShell_Impl::SmViewShell_Impl()()
846     
847         // make window docked to the bottom initially (after first start)
848         SetAlignment(SfxChildAlignment::BOTTOM);
849         static_cast<SfxDockingWindow *>(GetWindow())->Initialize(pInfo);
850     }
851     
>>>     CID 1440240:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
852     struct SmViewShell_Impl
853     {
854         std::unique_ptr<sfx2::DocumentInserter> pDocInserter;
855         std::unique_ptr<SfxRequest> pRequest;
856         SvtMiscOptions const        aOpts;
857     };

** CID 1440239:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/view/viewshel.cxx: 1209 in sd::KeepSlideSorterInSyncWithPageChanges::~KeepSlideSorterInSyncWithPageChanges()()


________________________________________________________________________________________________________
*** CID 1440239:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/view/viewshel.cxx: 1209 in sd::KeepSlideSorterInSyncWithPageChanges::~KeepSlideSorterInSyncWithPageChanges()()
1203             {
1204                 rSet.DisableItem(SID_GETREDOSTRINGS);
1205             }
1206         }
1207     }
1208     
>>>     CID 1440239:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
1209     class KeepSlideSorterInSyncWithPageChanges
1210     {
1211         sd::slidesorter::view::SlideSorterView::DrawLock const m_aDrawLock;
1212         sd::slidesorter::controller::SlideSorterController::ModelChangeLock const m_aModelLock;
1213         sd::slidesorter::controller::PageSelector::UpdateLock const m_aUpdateLock;
1214         sd::slidesorter::controller::SelectionObserver::Context const m_aContext;

** CID 1440238:  Memory - illegal accesses  (WRAPPER_ESCAPE)
/sc/source/filter/excel/xipivot.cxx: 1493 in XclImpPivotTable::Convert()()


________________________________________________________________________________________________________
*** CID 1440238:  Memory - illegal accesses  (WRAPPER_ESCAPE)
/sc/source/filter/excel/xipivot.cxx: 1493 in XclImpPivotTable::Convert()()
1487     
1488         pDPObj->SetSaveData( aSaveData );
1489         pDPObj->SetSheetDesc( aDesc );
1490         pDPObj->SetOutRange( aOutRange );
1491         pDPObj->SetHeaderLayout( maPTViewEx9Info.mnGridLayout == 0 );
1492     
>>>     CID 1440238:  Memory - illegal accesses  (WRAPPER_ESCAPE)
>>>     The internal representation of local "pDPObj" escapes into "this->mpDPObj", but is destroyed when it exits scope.
1493         mpDPObj = pDPObj.get();
1494         GetDoc().GetDPCollection()->InsertNewTable(std::move(pDPObj));
1495     
1496         ApplyFieldInfo();
1497         ApplyMergeFlags(aOutRange, aSaveData);
1498     }

** CID 1399420:  Error handling issues  (UNCAUGHT_EXCEPT)
/slideshow/source/engine/slide/slideanimations.cxx: 46 in slideshow::internal::SlideAnimations::~SlideAnimations()()


________________________________________________________________________________________________________
*** CID 1399420:  Error handling issues  (UNCAUGHT_EXCEPT)
/slideshow/source/engine/slide/slideanimations.cxx: 46 in slideshow::internal::SlideAnimations::~SlideAnimations()()
40                 mpRootNode()
41             {
42                 ENSURE_OR_THROW( maContext.mpSubsettableShapeManager,
43                                   "SlideAnimations::SlideAnimations(): Invalid SlideShowContext" );
44             }
45     
>>>     CID 1399420:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
46             SlideAnimations::~SlideAnimations()
47             {
48                 if( mpRootNode )
49                 {
50                     SHOW_NODE_TREE( mpRootNode );
51     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyDWYarXesS3e5HmGoRSTreOZolZ5xN1dPSIM0C3x6JvHXKqkpQ8kCTet7-2BA4qE1GLCjKY3mIz1MclBIdmHdX3gB5L3xKxSYTq23Oh7jj-2BwoiVpgc6XfNE97vcJFUr-2BwD5v58dlbpOOflakw47A6lq-2B62pVyRveXF7ghqwyS2u3oc-3D



More information about the LibreOffice mailing list