OpenDocument spec tables row height [was: Writer - row-height, min-row-height and use-optimal-row-height]

[Lionel Elie Mamane]

In the absence of feedback from sw people, we just commit the change?

On Thu, Jul 26, 2018 at 03:10:37PM +0200, Lionel Elie Mamane wrote:
> Anybody?
> 
> On Sun, Jun 17, 2018 at 11:48:49AM +0200, Lionel Elie Mamane wrote:
> > Hi,
> > 
> > The Base report builder produces Writer (odt) documents directly (it
> > spits out XML, not using Writer to produce it), and then opens them in
> > Writer. It uses tables heavily.
> > 
> > In the context of
> > https://bugs.documentfoundation.org/show_bug.cgi?id=45789
> > https://gerrit.libreoffice.org/53977
> > Ilhan prepared a patch to make Report Builder mark some rows of some
> > tables as "fit to size" in row height. By reading the OpenDocument
> > specification, I thought this would happen by setting the
> > style:use-optimal-row-height attribute on the row. However, it turns
> > out that Ilhan had to change some sw code for that to work, and that
> > made me suspicious whether that was the right thing to do.
> > 
> > I looked into the XML generated by Writer with "Fit to Size" enabled
> > and disabled, and apparently that checkbox in writer replaces
> > "style:row-height" by "style:min-row-height, and
> > style:use-optimal-row-height is nowhere to be seen.
> > 
> > Could a Writer expert please look at the sw changes in
> > https://gerrit.libreoffice.org/53977
> > and let us know whether these changes are right or wrong with respect
> > to OpenDocument? Is style:use-optimal-row-height supposed to override
> > style:row-height or vice-versa?
> > 
> > Thanks in advance,
> > 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice