ESC meeting minutes: 2019-12-05
Miklos Vajna
vmiklos at collabora.com
Thu Dec 5 15:46:27 UTC 2019
* Present:
+ Cloph, Heiko, Caolan, Eike, Stephan, Xisco, Michael S, Thorsten, Ilmari, Miklos, Oliver, Kendy, Michael M.
* Completed Action Items:
+ update the ReleaseBuilds wiki page after release baseline for macOS has changed to Catalina + xcode11 (Cloph)
[ decided to not do it at the end ]
+ file a redmine ticket to update api.libreoffice.org automatically (Cloph)
[ https://redmine.documentfoundation.org/issues/3052 ]
* Pending Action Items:
+ Propose new certified developers (Kendy, Stephan, Thorsten)
+ still waiting
+ make gnu make 4.0 a requirement on master (Michael S)
* Release Engineering update (Cloph)
+ 6.4 status
+ string + ui freeze in 2 weeks
+ Late features?
+ ODF tender, perhaps (Thorsten)
+ string changes went in to 6.4 precautiously (Thorsten)
+ 6.3 status
+ 6.3.4 rc2 will be tagged later today
+ Remotes
+ Android viewer
+ there were some x86 fixes, but is still broken for Cloph
+ arm64 â likely to have runtime problems
+ Kendy has some patches to bridges and elsewhere, but maybe not all
of them are needed thanks to the Stephanâs patch
+ Online
+ libreoffice-6-4 branch is created
* Documentation (Olivier)
+ New Help
+ progress in XHP editor (ohallot)
+ goal: edit in the browser, click a button, see the result instantly
+ Helpcontent2
+ Hep page for OPT_ functions (S. Fanning)
+ Updates and housekeeping (ohallot)
+ switching from PNG to SVG images, new requirement: width/height has to be set
+ Fixes (Caolán, M. Kaganski)
+ Google Season Of Doc
+ Book is ready LibreOffice Online
+ PDF: https://nextcloud.documentfoundation.org/s/RtHBeXoeiZr2eM8
+ Calc guide:
+ decided to be less verbose about threading / opencl
* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
231(231) (topicUI) bugs open, 249(249) (needsUXEval) needs to be evaluated by the UXteam
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
added 4(-11) 20(-4) 38(-3) 103(-5)
commented 91(7) 324(46) 787(10) 2292(54)
removed 0(-1) 1(0) 1(0) 13(0)
resolved 11(3) 35(8) 84(1) 217(7)
+ top 10 contributors:
Heiko Tietze made 186 changes in 1 month, and 917 changes in 1 year
Xisco Faulà made 100 changes in 1 month, and 404 changes in 1 year
Kainz, Andreas made 44 changes in 1 month, and 245 changes in 1 year
Timur made 41 changes in 1 month, and 98 changes in 1 year
Foote, V Stuart made 39 changes in 1 month, and 398 changes in 1 year
Dieter Praas made 36 changes in 1 month, and 305 changes in 1 year
Mehrbrodt, Samuel made 24 changes in 1 month, and 109 changes in 1 y
Roman Kuznetsov made 23 changes in 1 month, and 290 changes in 1 year
Cor Nouws made 18 changes in 1 month, and 173 changes in 1 year
Seth Chaiklin made 16 changes in 1 month, and 23 changes in 1 year
+ New tickets with needsUXEval Nov/28-Dec/05
* Remove alt+enter shortcut
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129201
* Page sidebar: "Same Content" on header/footer sections is absolutely
illogical
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129200
* Tabbed interface: Remove printer name in Print Directly command under
File tab
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129154
* Choice of extra toolbars forgotten when switching to different view
(e.g. NotebookBar)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=123607
* PDF Export: UI doesn't show that the export option Range, is ignored
when "Full-sheet previews" (under Structure) is set
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129162
=> in discussion, unconfirmed, reopened
* FORMATTING - Preset protected cell background color not displayed in
spreadsheet (documentation per Comment 6)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129024
* Show MIME type icon in recent file list
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129153
* Make all function names distinguishable
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129122
+ dup of https://bugs.documentfoundation.org/show_bug.cgi?id=108458
-> + Jim made a patch to have an even listener for tooltips on treeviews
https://gerrit.libreoffice.org/#/c/84555/
+ donât forget to test both weld backends (gtk3, non-gtk3) (Miklos)
=> accepted
* Wording in printer dialog
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129140
=> ASSIGNED
* Some statusbar indicator are not easily visible on Adwaita Dark theme
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129145
* Automatic bullet list inconsistency when mixed font size in line
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127527
* Redaction Toolbar Should Not Appears In A New Draw File
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129128
* Automatic Hyperlinks
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128961
=> NAB, DUP, WFM
* Crash Testing (Caolan)
+ 0(-7) import failure, 0(-10) export failures
+ 0 coverity issues! \o/
+ 11 oss-fuzz issues (2 non-timeouts)
+ Impress â running program in a shape
+ perhaps will follow what PowerPoint does in the same context (Stephan)
+ what PowerPoint does is read-only mode by default for downloaded documents + then you canât even click on the shape (Thorsten)
* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/6.2.7.1
       + (+174) 1544 1370 1607 1473 1256 1378 1607 1549 2481 1309 959 673 186 0
   + https://crashreport.libreoffice.org/stats/version/6.2.8.2
       + (+109) 1082 973 815 568 375 320 198 0
   + https://crashreport.libreoffice.org/stats/version/6.3.1.2
       + (+18) 1280 1262 1238 1297 1162 1454 1783 2151 3406 2696 2886 2262 820 0
   + https://crashreport.libreoffice.org/stats/version/6.3.2.2
       + (-62) 2578 2640 3124 3622 3487 4392 3950 3273 4801 1698 0
   + https://crashreport.libreoffice.org/stats/version/6.3.3.2
       + (+362) 3674 3312 2629 1820 854 0
+ Recent regressions without steps to reproduce them
1. https://crashreport.libreoffice.org/stats/signature/TypeDescriptor_Init_Impl::getMutex()
2. (Since 6.3.3.2 â likely related to e200d3a51157e81eb66dbfc0961ae94c47b3c6e7) https://crashreport.libreoffice.org/stats/signature/XmlFilterAdaptor::importImpl(com::sun::star::uno::Sequence%3Ccom::sun::star::beans::PropertyValue%3E%20const%20&)
3. (Only linux) https://crashreport.libreoffice.org/stats/signature/dbaccess::ODatabaseDocument::impl_attachResource
4.
https://crashreport.libreoffice.org/stats/signature/ScDocument::RemoveSubTotalCell(ScFormulaCell%20*)
5. https://crashreport.libreoffice.org/stats/signature/SvListView::SelectListEntry(SvTreeListEntry%20*,bool)
+ no reproducers steps yet (Xisco)
+ hoping to figure out how to trigger them
* Hackfests & Events (Thorsten)
+ hope to have one each quarter.
+ plans for next year:
+ FOSDEM 2020
+ HackFest February 3rd and 4th, again probably in Beta Coworking (after FOSDEM)
+ devroom is approved, will be on Saturday
+ talks submitted: Caolan, Thorsten (will do the lightning), Ilmari,
Kendy, Andras, Pedro, Michael, Heiko, Xisco
+ CMS room might be interesting too (Thorsten)
* mentoring/easyhack update
committer... 1 week 1 month 3 months 12 months
open 80(8) 141(8) 147(9) 158(8)
reviews 1489(-348) 6002(175) 14074(162) 55489(60)
merged 432(-154) 2004(30) 5097(48) 17339(32)
abandoned 24(2) 88(-6) 246(12) 850(3)
own commits 305(-162) 1589(-32) 4307(46) 14765(-56)
review commits 59(-36) 345(-15) 956(-19) 4295(-5)
contributor... 1 week 1 month 3 months 12 months
open 25(6) 40(3) 43(4) 45(4)
reviews 250(0) 827(38) 2131(48) 4242(150)
merged 22(6) 70(14) 147(3) 893(5)
abandoned 10(3) 167(3) 182(2) 479(4)
own commits 19(-4) 87(-8) 184(-20) 934(-28)
review commits 0(0) 0(0) 0(0) 0(0)
+ easyHack statistics:
needsDevEval 6(6) needsUXEval 1(1) cleanup_comments 199(199)
total 248(248) assigned 4(4) open 229(229)
+ top 10 contributors:
Balazs Varga made 11 patches in 1 month, and 61 patches in 1 year
LibreOï¬ciant made 9 patches in 1 month, and 77 patches in 1 year
Corentin Noël made 8 patches in 1 month, and 9 patches in 1 year
Seth Chaiklin made 8 patches in 1 month, and 8 patches in 1 year
Pranam Lashkari made 6 patches in 1 month, and 6 patches in 1 year
Tünde Tóth made 5 patches in 1 month, and 35 patches in 1 year
Ilmari Lauhakangas made 3 patches in 1 month, and 42 patches in 1 year
Steve Fanning made 2 patches in 1 month, and 2 patches in 1 year
Marco A.G.Pinto made 2 patches in 1 month, and 9 patches in 1 year
Attila Bakos made 1 patches in 1 month, and 2 patches in 1 year
+ top 10 reviewers:
Vajna, Miklos made 141 review comments in 1 month, and 1568 in 1 year
Xisco Faulà made 140 review comments in 1 month, and 1004 in 1 year
Michael Stahl made 127 review comments in 1 month, and 1518 in 1 year
Grandin, Noel made 119 review comments in 1 month, and 1166 in 1 year
McNamara, Caolán made 118 review comments in 1 month, and 1123 in 1 year
Bergmann, Stephan made 116 review comments in 1 month, and 1057 in 1 year
Heiko Tietze made 114 review comments in 1 month, and 470 in 1 year
Nabet, Julien made 113 review comments in 1 month, and 2266 in 1 year
Meeks, Michael made 109 review comments in 1 month, and 631 in 1 year
Holešovský, Jan made 108 review comments in 1 month, and 910 in 1 year
+ Patches automatically abandoned:
Dialog: keep mpDialogImpl around after dispose. ( Michael Meeks )
- https://gerrit.libreoffice.org/#/c/79878
Make Chart Creation Wizard async ( Michael Meeks )
- https://gerrit.libreoffice.org/#/c/79571
tdf#127305 display selected text in URL field QR Code Dialog ( shubham goyal )
- https://gerrit.libreoffice.org/#/c/78879
- Samuel?
tdf#97361: Removed getByTindex in Pyuno pytests ( Mayank Suman )
- https://gerrit.libreoffice.org/#/c/80116
- Thorsten?
+ big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
Martin Milata
Henrie, Alex
Gary Kim
Steve Fanning
* Commit Access
+ None
* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
+ sleep -3 weeks
* Jenkins / CI update (Christian)
from:Thu Nov 28 14:50:33 2019
master linux rel jobs: 37 ok: 37 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master linux dbg jobs: 32 ok: 31 ko: 1 fail ratio: 3.12 % break: 1 broken duration: 1.43%
master mac rel jobs: 10 ok: 10 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master mac dbg jobs: 11 ok: 11 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win rel jobs: 51 ok: 48 ko: 3 fail ratio: 5.88 % break: 3 broken duration: 3.12%
master win dbg jobs: 63 ok: 61 ko: 2 fail ratio: 3.17 % break: 2 broken duration: 6.88%
master win64 dbg jobs: 58 ok: 52 ko: 6 fail ratio: 10.34 % break: 5 broken duration: 7.56%
master gerrit lin jobs: 553 ok: 461 ko: 69 fail ratio: 12.48% time for ok: mean: 24 median: 20
master gerrit plg jobs: 478 ok: 303 ko: 134 fail ratio: 28.03% time for ok: mean: 34 median: 28
master gerrit win jobs: 569 ok: 437 ko: 107 fail ratio: 18.80% time for ok: mean: 57 median: 57
master gerrit mac jobs: 543 ok: 418 ko: 62 fail ratio: 11.42% time for ok: mean: 42 median: 24
master gerrit all jobs: 485 ok: 268 ko: 143 fail ratio: 29.48% time for ok: mean: 146 median: 142
+ https://dev-www.libreoffice.org/tmp/gerrit_191205.html
+ tests that failed a lot in last seven days:
4 CppunitTest_sw_mailmerge
6 CppunitTest_sw_uiwriter
8 CppunitTest_writerperfect_writer
12 UITest_calc_tests
24 UITest_chart
+ high load on Jenkins continues
+ tempted to kill ongoing jobs when one fails (Cloph)
+ EC2 instance is suboptimal (completed a build in 16h)
+ took them offline for now
+ have 1 replacement (on the weblate machine for now)
+ Possibly the Hetzner cloud will be a good replacement for Amazon
+ is this on-demand? (Thorsten)
+ yes, thatâs the intention (Cloph)
+ though need to start the instances manually currently â but Hetzner has API, needs a bit of glue & scripting to hook up to Jenkins
+ trade-off: more info later vs less info faster
+ currently: more info later
+ plan: less info faster (kill ongoing platforms if one fails)
+ happy (Thorsten)
* Gerrit SSO (Cloph)
+ https://lists.freedesktop.org/archives/libreoffice/2019-December/083923.html
+ Switchover to ONLY TDF-SSO on Dec 25th
other authentication methods will be removed
+ you will be locked out from your account if you donât have TDF-account
setup/infra will have to map it manually afterwards
+ Gerrit will be updated to 2.16
+ test instance: https://gerrit-stage.documentfoundation.org/
* l10n (Sophie)
+ weblate instance status: migrating to a newer version
+ also to final hardware
+ both pending on provisioning of the server (ordered it last Friday)
+ new team for Guadeloupean Creole
* Graphics architecture (Thorsten)
* https://pad.documentfoundation.org/p/ESC_graphics_architecture
* skia status: see the updated feature/skia branch in core.git (Miklos)
+ Lubos merged the SKIA branch to master
+ if you want to try it, export SAL_ENABLESKIA=1
+ Metabug for skia bugs:
- https://bugs.documentfoundation.org/show_bug.cgi?id=129062
* docx/xlsx competitive marketing isues (Miklos)
+ docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
+ xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs
+ unchanged from last week
* bibisect repos heads up â those are incremental builds, so busted dependencies give interesting bugs â c.f. https://bugs.documentfoundation.org/show_bug.cgi?id=128133 â needs awareness or perhaps occasional clean builds (Thorsten)
+ what about from-scratch builds for bibisect? (Miklos)
+ windows donât have ccache (Thorsten)
+ not happy with non-c++ build cost â rebuilds change timestamps, kill git compression (Cloph)
+ regarding reproducible builds, one random link with information also
for Windows is
<http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html>
+ what about at least clean Linux builds? (Miklos)
+ a bit worried regarding random noise in bibisect repos (Cloph)
+ 8GB is the current size of a full cycle, not looking forward to larger repos (Xisco)
* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief
+ UNCONFIRMED: 551 (-1)
+ enhancements: 58 (-4)
+ needsUXEval: 5 (-4)
+ haveBackTrace: 0 (+0)
+ needsDevAdvice: 13 (-1)
+ documentation: 10 (+3)
+ android: 5 (+0)
+ iOS: 1 (-3)
+ Online: 14 (-1)
   New:
       + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving
           + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
           + Thorsten?
       + Time required to export a large document has doubled for Latin (text layout issue)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=112989
           + Khaled?
   Old:
       + Save-As behavior on MacOS Catalina
          + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
          + not happening for everyone
       + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
          + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
            + probably depends on xcode version (Xisco)
            + but newer xcode is required by notorization (Cloph)
              + ideal would be to build with xcode 10 entirely
              + HiDPI screen for Cloph would be great (Michael)
              + found out: not a regression, but it is from a userâs PoV
   Fixed:
       + Sidebar Position and Size displays incorrect width and height when units in mm
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128659
           + Thanks to Caolán
+ New high severity bugs of the week:
+ Crash when sort by column of Excel 97-2003 file with specific data
+ https://bugs.documentfoundation.org/show_bug.cgi?id=129127
+ Dennis ?
+ Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
+ https://bugs.documentfoundation.org/show_bug.cgi?id=119190
+ Noel Power ?
* QA stats
+ https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
+131 +9 (-164) overall)
many thanks to the top bug squashers:
Xisco Faulà 20
Timur 20
Caolán McNamara 10
Mike Kaganski 8
QA Administrators 7
Andras Timar 6
Julien Nabet 6
andreas_k 6
Roman Kuznetsov 4
Noel Grandin 4
+ top 10 bugs reporters:
NISZ LibreOffice Team 6
Mike Kaganski 5
Nicolas Christener 5
Chris Sherlock 4
raal 3
Rizal Muttaqin 3
Roman Kuznetsov 2
Roeland 2
Adalbert HanÃen 2
roland 2
+ top 10 bugs fixers:
McNamara, Caolán 9
Xisco Faulà 6
Grandin, Noel 5
Kainz, Andreas 4
Andras Timar 3
Kaganski, Mike 3
Hung, Mark 2
Rathke, Eike 2
Nabet, Julien 2
Vajna, Miklos 1
+ top 10 bugs confirmers:
Dieter Praas 17
Xisco Faulà 16
Timur 14
Heiko Tietze 8
Nabet, Julien 8
Roman Kuznetsov 6
Alex Thurgood 6
*UNKNOWN* 5
Foote, V Stuart 3
Kaganski, Mike 3
* Highest-Priority bugs (aka "MABs"):
+ http://bit.ly/2lJAAJI
6.0 : 1/52 - 1 % (+0)
5.4 : 1/40 - 2 % (+0)
5.3 : 1/54 - 1 % (+1)
5.2 : 0/43 - 0 % (+0)
5.1 : 1/36 - 2 % (+2)
5.0 : 0/64 - 0 % (+0)
4.4 : 0/76 - 0 % (+0)
4.3 : 2/73 - 2 % (+0)
4.2 : 2/133 - 1 % (+0)
4.1 : 3/85 - 3 % (+2)
4.0 : 3/82 - 3 % (+0)
old : 6/244 - 2 % (+1)
* Bisected bugs open: keyword 'bisected'
+ more accurate - down to a single commit.
+ http://bit.ly/2dyIfDy
+
done by:
Xisco Faulà 10
Budea, Ãron 2
Brinzing, Oliver 2
Terrence Enger 1
Raal 1
Timur 1
Kaganski, Mike 1
* Bibisected bugs open: keyword 'bibisected'
+ http://bit.ly/2cSCXlS
+
done by:
Xisco Faulà 12
Budea, Ãron 2
Brinzing, Oliver 2
Terrence Enger 1
Raal 1
Kaganski, Mike 1
* all bugs tagged with 'regression'
+ 1138(-3) bugs open of 9117(+26) total 2(-1) high prio.
done by:
Timur 6
Xisco Faulà 6
Brinzing, Oliver 3
Andrea Giudiceandrea 2
Alex Thurgood 2
Foote, V Stuart 1
NISZ LibreOffice Team 1
Pedro 1
Raal 1
Kaganski, Mike 1
* ~Component count net * high severity regressions
+ http://bit.ly/1HWHb3E
UI - 1(+0)
Calc - 1(+0)
Linguistic - 0(-1)
by OS:
Windows - 0(+0)
All - 1(-1)
Mac OS X - 1(+0)
Linux - 0(+0)
* ~Component count net * all regressions
+ http://bit.ly/1BUdI8i
Writer: other - 314(-4)
Calc - 227(+3)
Impress - 130(-1)
Writer: docx filter - 77(+0)
LibreOffice - 65(-1)
Draw - 45(+0)
Borders - 41(+1)
UI - 38(+0)
Base - 35(+0)
Writer: perf - 33(-1)
Writer: doc filter - 32(+1)
Crashes - 31(+1)
Writer: other filter - 29(+0)
graphics stack - 27(-1)
filters and storage - 22(+0)
RTL - 22(+0)
BASIC - 19(+2)
Printing and PDF export - 18(+0)
Chart - 17(+0)
framework - 2(+0)
sdk - 1(+0)
Linguistic - 0(-1)
More information about the LibreOffice
mailing list