sd: disable pdf import tests

Stephan Bergmann sbergman at redhat.com
Mon Dec 16 16:59:51 UTC 2019


> commit f03ca93665fa974c5be2d9ca7082cb64ceafd7f8
> Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
> Date:   Sun May 20 22:31:36 2018 -0400
> 
>     sd: disable pdf import tests
>     
>     Change-Id: Iaee679d2ff322c67d081185588103d5685fa970a
> 
> diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
> index 7e37d3c6ad0b..5fdb232625ef 100644
> --- a/sd/qa/unit/import-tests.cxx
> +++ b/sd/qa/unit/import-tests.cxx
> @@ -138,7 +138,7 @@ public:
>      void testTableBorderLineStyle();
>      void testBnc862510_6();
>      void testBnc862510_7();
> -#if ENABLE_PDFIMPORT
> +#if ENABLE_PDFIMPORT && defined(IMPORT_PDF_ELEMENTS)
>      void testPDFImport();
>      void testPDFImportSkipImages();
>  #endif
> @@ -221,7 +221,7 @@ public:
>      CPPUNIT_TEST(testTableBorderLineStyle);
>      CPPUNIT_TEST(testBnc862510_6);
>      CPPUNIT_TEST(testBnc862510_7);
> -#if ENABLE_PDFIMPORT
> +#if ENABLE_PDFIMPORT && defined(IMPORT_PDF_ELEMENTS)
>      CPPUNIT_TEST(testPDFImport);
>      CPPUNIT_TEST(testPDFImportSkipImages);
>  #endif
> @@ -1205,7 +1205,7 @@ void SdImportTest::testBnc862510_7()
>      xDocShRef->DoClose();
>  }
>  
> -#if ENABLE_PDFIMPORT
> +#if ENABLE_PDFIMPORT && defined(IMPORT_PDF_ELEMENTS)
>  
>  void SdImportTest::testPDFImport()
>  {

What's the reason for this change, and/or are there plans to enable the 
tests again?  (`git log -SIMPORT_PDF_ELEMENTS` shows this to be the only 
commit ever mentioning that identifier, so the tests are indeed disabled 
since then.)



More information about the LibreOffice mailing list