[Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

[Rene Engelhard]

Hi,

On Sun, Jun 09, 2019 at 03:30:12AM +0000, Michael Weghorn (via logerrit) wrote:
> diff --git a/avmedia/Library_avmediagst.mk b/avmedia/Library_avmediagst.mk
> index cd651c82e60b..027123911e87 100644
> --- a/avmedia/Library_avmediagst.mk
> +++ b/avmedia/Library_avmediagst.mk
> @@ -31,6 +31,16 @@ $(eval $(call gb_Library_add_libs,avmediagst,\
>  ))
>  endif
>  
> +ifneq ($(ENABLE_QT5),)
> +$(eval $(call gb_Library_add_cxxflags,avmediagst,\
> +    $$(QT5_CFLAGS) \
> +))
> +
> +$(eval $(call gb_Library_add_libs,avmediagst,\
> +    $(QT5_LIBS) \
> +))
> +endif
> +
>  $(eval $(call gb_Library_use_external,avmediagst,boost_headers))
>  
>  $(eval $(call gb_Library_use_sdk_api,avmediagst))
[...]
> +#if ENABLE_QT5
> +                    // try to use qwidget5videosink for qt5 on Wayland, which requires the Qt5 packages for QtGStreamer to be installed
> +                    if (aToolkit == "qt5" && aPlatform == "wayland")
> +                    {
[...]

Thought of this a few days and I don't like this. This would make the
whole office (well, the package where the gstreamer thingy is in)
dependent on qt5. (Yes, I know it's already the case for gtk3, but that
imho is not a that big issue.)

I could hack around it but that doesn't scale
- needs 3 builds of avmedia (gtk3, qt5, neither)
- would need dpkg-divert and this effectively means you cannot coinstall
  the -gtk3 and -qt5 plugin packages (and thus not even -gtk3 and
  -kde5).

Can't the qt5 (and gtk3) libraries not dynamically loaded in some way?

Regards,

Rene