UI tests opening all possible dialogs

Artur Neumann artur at jankaritech.com
Tue Jun 25 11:30:36 UTC 2019


Hi Raal,

so you would prefer if the "Cancel/Close" tests would be integrated in
other tests of that dialog if those exist like I've done now

https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests/fillRandomNumber.py
https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests/sheetRename.py
https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests3/clearCells.py

If that is the case I will go through the list and change that

Artur

On 2019-06-24 9:30 p.m., Raal wrote:
> Hi Artur,
> see https://gerrit.libreoffice.org/#/c/74654/ - you can add test for
> Cancel button to existing tests.
>
> Cheers,
> Raal
>
> On 24. 06. 19 9:22, Artur Neumann wrote:
>>
>> Hi Raal & Markus
>>
>> I've moved the tests into a new folder and skipped tests that are
>> already done in other tests. The lines have comments explaining why
>> specific tests are skipped. https://gerrit.libreoffice.org/#/c/74333/
>>
>> If you thing testing the "Cancel" button does not make sense, we can
>> skip even more tests.
>>
>> Please review and see if that makes sense to you.
>>
>> Greetings Artur
>>
>> On 2019-06-22 10:57 p.m., Raal wrote:
>>> Hello Artur,
>>> generally it looks useful, but please check first if such test
>>> exists. For example bug 120227 is already covered by this test
>>> https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/pageFormat/tdf123508
>>> <https://bugs.documentfoundation.org/show_bug.cgi?id=123508>.py .
>>> Please search first at opengrok, because uitests are quite slow and
>>> we should avoid duplicity. For example from your test
>>> SearchDialog  - lots of tests exists in directory
>>> /core/sc/qa/uitest/search_replace/
>>> <https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/search_replace/>
>>> InsertObjectChart - lots of tests exists in directory 
>>> /core/sc/qa/uitest/chart/
>>> FunctionDialog -
>>> https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/calc_tests7/tdf123479.py
>>> etc.
>>>
>>> Please add your test to the new directory, see
>>> https://gerrit.libreoffice.org/#/c/72376/ like an example
>>> Note: the tests runs in "gen" enviroment, so gtk3 bugs we cannot
>>> test (125982
>>> <https://bugs.documentfoundation.org/show_bug.cgi?id=125982>, 125985
>>> <https://bugs.documentfoundation.org/show_bug.cgi?id=125985>)
>>>
>>> Best regards,
>>> Raal
>>>
>>>
>>>
>>>
>>> On 22. 06. 19 11:10, Markus Mohrhard wrote:
>>>> Hello Artur,
>>>>
>>>> On Fri, Jun 21, 2019 at 12:06 PM Artur Neumann
>>>> <artur at jankaritech.com <mailto:artur at jankaritech.com>> wrote:
>>>>
>>>>     Forgot the link to the changes, here it is:
>>>>     https://gerrit.libreoffice.org/#/c/74333/
>>>>
>>>>     On 2019-06-20 5:01 p.m., Artur Neumann wrote:
>>>>>
>>>>>     I've made some UI tests that open every dialog in calc, close
>>>>>     it with the "close" or "cancel" button and if there is an "OK"
>>>>>     button open it again and click the "OK" button
>>>>>
>>>>>     These tests should simply make sure there are no crashes by
>>>>>     opening/closing the dialogues and protect against regressions
>>>>>     like
>>>>>     https://bugs.documentfoundation.org/show_bug.cgi?id=120227
>>>>>     https://bugs.documentfoundation.org/show_bug.cgi?id=125982
>>>>>     https://bugs.documentfoundation.org/show_bug.cgi?id=125985
>>>>>
>>>>>     I just wanted to have some feedback if picking those
>>>>>     low-hanging fruits is a valid approach and worth the effort
>>>>>     and CI time.
>>>>>
>>>>
>>>> I think that in general it is a good idea. Depending on how long it
>>>> takes to execute the test we might need to think about whether we
>>>> can actually include the tests in a normal make/make check or if
>>>> they need to be treated differently. Did you already have a chat
>>>> with Raal who has been writing tests for many bugs/dialogs already?
>>>>
>>>>>     If yes I could extend the tests by:
>>>>>
>>>>>      1. doing the same for writer, impress, etc.
>>>>>      2. delete obsolete tests like uitest/calc_tests/about_test.py
>>>>>      3. define preconditions for the "OK" click, e.g. input data
>>>>>         into fields
>>>>>      4. define assertion after the click on the "OK" button
>>>>>
>>>>
>>>> In general this sounds like a good idea. As mentioned it might be
>>>> good to have a chat with Raal who might have an overview how far we
>>>> are in opening all dialogs already.
>>>>
>>>> Regards,
>>>> Markus
>>>>
>>>>>     Thoughts? Ideas?
>>>>>
>>>>>     -- 
>>>>>     Artur Neumann
>>>>>     Director/CTO
>>>>>     Jankari Tech Pvt Ltd
>>>>>     www.jankaritech.com <http://www.jankaritech.com>
>>>>>     Phone: +977 9806639223
>>>>>     Skype: artur.n.
>>>>>     GitHub: https://github.com/individual-it
>>>>>
>>>>>     _______________________________________________
>>>>>     LibreOffice mailing list
>>>>>     LibreOffice at lists.freedesktop.org <mailto:LibreOffice at lists.freedesktop.org>
>>>>>     https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>>>
>>>>     -- 
>>>>     Artur Neumann
>>>>     Director/CTO
>>>>     Jankari Tech Pvt Ltd
>>>>     www.jankaritech.com <http://www.jankaritech.com>
>>>>     Phone: +977 9806639223
>>>>     Skype: artur.n.
>>>>     GitHub: https://github.com/individual-it
>>>>
>>>>     _______________________________________________
>>>>     LibreOffice mailing list
>>>>     LibreOffice at lists.freedesktop.org
>>>>     <mailto:LibreOffice at lists.freedesktop.org>
>>>>     https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>>>
>>>
>>>
>>> -- 
>>> LibreOffice is powered by a team of volunteers who mostly give their time for free. 
>>> We invite you to join as there are many ways to get involved including bugs triage, 
>>> marketing, UX, documentation, and of course developing -  https://www.libreoffice.org/get-involved/
>>>
>>> _______________________________________________
>>> LibreOffice mailing list
>>> LibreOffice at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>> -- 
>> Artur Neumann
>> Director/CTO
>> Jankari Tech Pvt Ltd
>> www.jankaritech.com
>> Phone: +977 9806639223
>> Skype: artur.n.
>> GitHub: https://github.com/individual-it
>
>
> -- 
> LibreOffice is powered by a team of volunteers who mostly give their time for free. 
> We invite you to join as there are many ways to get involved including bugs triage, 
> marketing, UX, documentation, and of course developing -  https://www.libreoffice.org/get-involved/
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20190625/88c573f8/attachment.html>


More information about the LibreOffice mailing list