6.3.0.0.beta2: calendarImpl: name clash

[Eike Rathke]

Hi balducci,

On Thursday, 2019-06-27 19:14:29 +0200, balducci at units.it wrote:

> > shouldn't cause this, or you have -DU_USING_ICU_NAMESPACE=3D1 somewhere in
> > your CFLAGS or CXXFLAGS settings.
> 
> ... that is precisely the reason: in my install script I now see:
> 
>     ----8<----
>     # 2018-06-18: 6.0.1.1: BLFS
>     prepend_var CPPFLAGS "-DU_USING_ICU_NAMESPACE=1 "
>     ---->8----

That could explain..

Anyhow, should be fixed with these commits in
master 71674ab6a7472132ca2eee1381e3273bd6b35a7b
libreoffice-6-3 4ebf6ff1cf09e3a142b99d62158eb4db64bc700e


> (and from icu docs I seem to
> understand that it shouldn't be needed any longer)
> So, most probably, running without that define wouldn't show any
> problem...

If not some software still relies on an external using directive.
However, LibreOffice at least does not when building a current
LibreOffice or >= 6.1, and I think some 6.0.x version already had all
patches to be built without and with the then recent ICU 61, which had
the change.

> Apologies for the noise: I guess nobody is supposed to run with
> that...

Good that it showed up though, because it pointed out another inadequate
use of using namespace.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20190627/ef27f20d/attachment.sig>