Wrong copy paste in SwFieldFormCheckboxPortion::Format ?

Miklos Vajna vmiklos at collabora.com
Tue Nov 19 08:20:37 UTC 2019


Hi Julien,

Oh sorry, I didn't realize this pattern is:

SetWidth(GetHeight())
SetHeight(GetHeight())

I thought it's:

SetWidth(GetHeight())
SetHeight(GetWidth())

With that in mind, the current code is just OK, the width of the
checkbox portion is the same as its height, since it's a square (and
that size depends on the font size).

Perhaps add a comment explaining this to make it easier for the next
person to understand. :-)

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20191119/169d451d/attachment.sig>


More information about the LibreOffice mailing list