New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1454849:  Control flow issues  (DEADCODE)
/sc/source/ui/unoobj/docuno.cxx: 2027 in ScModelObj::render(int, const com::sun::star::uno::Any &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()


________________________________________________________________________________________________________
*** CID 1454849:  Control flow issues  (DEADCODE)
/sc/source/ui/unoobj/docuno.cxx: 2027 in ScModelObj::render(int, const com::sun::star::uno::Any &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()
2021                 }
2022             }
2023         } aDrawViewKeeper;
2024     
2025         SCTAB nTab;
2026         if (bSinglePageSheets)
>>>     CID 1454849:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "nTab = nSelRenderer;".
2027             nTab = nSelRenderer;
2028         if ( !maValidPages.empty() )
2029             nTab = pPrintFuncCache->GetTabForPage( maValidPages.at( nRenderer )-1 );
2030         else
2031             nTab = pPrintFuncCache->GetTabForPage( nRenderer );
2032     

** CID 1454848:  Code maintainability issues  (UNUSED_VALUE)
/sc/source/ui/unoobj/docuno.cxx: 2027 in ScModelObj::render(int, const com::sun::star::uno::Any &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()


________________________________________________________________________________________________________
*** CID 1454848:  Code maintainability issues  (UNUSED_VALUE)
/sc/source/ui/unoobj/docuno.cxx: 2027 in ScModelObj::render(int, const com::sun::star::uno::Any &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()
2021                 }
2022             }
2023         } aDrawViewKeeper;
2024     
2025         SCTAB nTab;
2026         if (bSinglePageSheets)
>>>     CID 1454848:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "nSelRenderer" to "nTab" here, but that stored value is overwritten before it can be used.
2027             nTab = nSelRenderer;
2028         if ( !maValidPages.empty() )
2029             nTab = pPrintFuncCache->GetTabForPage( maValidPages.at( nRenderer )-1 );
2030         else
2031             nTab = pPrintFuncCache->GetTabForPage( nRenderer );
2032     

** CID 1454847:  Uninitialized members  (UNINIT_CTOR)
/sc/inc/interpretercontext.hxx: 67 in ScInterpreterContext::ScInterpreterContext(const ScDocument &, SvNumberFormatter *)()


________________________________________________________________________________________________________
*** CID 1454847:  Uninitialized members  (UNINIT_CTOR)
/sc/inc/interpretercontext.hxx: 67 in ScInterpreterContext::ScInterpreterContext(const ScDocument &, SvNumberFormatter *)()
61             , mnTokenCachePos(0)
62             , maTokens(TOKEN_CACHE_SIZE, nullptr)
63             , mScLookupCache(nullptr)
64             , pInterpreter(nullptr)
65             , mpFormatter(pFormatter)
66         {
>>>     CID 1454847:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member field "maNFTypeCache.bIsValid" is not initialized in this constructor nor in any functions that it calls.
67         }
68     
69         ScInterpreterContext() = delete;
70     
71         ~ScInterpreterContext();
72     

** CID 1454846:  Resource leaks  (RESOURCE_LEAK)
/desktop/source/lib/init.cxx: 3285 in doc_sendDialogEvent(_LibreOfficeKitDocument *, unsigned int, const char *)()


________________________________________________________________________________________________________
*** CID 1454846:  Resource leaks  (RESOURCE_LEAK)
/desktop/source/lib/init.cxx: 3285 in doc_sendDialogEvent(_LibreOfficeKitDocument *, unsigned int, const char *)()
3279         }
3280     
3281         char* pIdChar = strtok(pCopy, " ");
3282     
3283         if (!pIdChar) {
3284             SetLastExceptionMsg("Error parsing the command.");
>>>     CID 1454846:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pCopy" going out of scope leaks the storage it points to.
3285             return;
3286         }
3287     
3288         OUString sId = OUString::createFromAscii(pIdChar);
3289         free(pCopy);
3290     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB73RtgzoPcQtNNP5dkHLuV1E-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyrPkVZxE0q4RYCn-2B6gRt9wBjofytNk6R5Hl-2FXkRHdAjMUCYvstBk46CNVkiTHmpubzutGbNdLzIzz694DxRtUyEDHZnD6SQbZKKSARR6AUkJ1SpJSFn7zICFseLljhWtI-2BhDB8LcLf3nKa9BueQPGgslvjlk9s38JdvxAs3QJ8kk-3D