New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1453856:  Uninitialized members  (UNINIT_CTOR)
/dbaccess/source/ui/misc/WCopyTable.cxx: 581 in dbaui::OCopyTableWizard::OCopyTableWizard(weld::Window *, const rtl::OUString &, short, const dbaui::ICopyTableSourceObject &, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> &)()


________________________________________________________________________________________________________
*** CID 1453856:  Uninitialized members  (UNINIT_CTOR)
/dbaccess/source/ui/misc/WCopyTable.cxx: 581 in dbaui::OCopyTableWizard::OCopyTableWizard(weld::Window *, const rtl::OUString &, short, const dbaui::ICopyTableSourceObject &, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> &)()
575         AddWizardPage( VclPtr<OWizNameMatching>::Create(this, CreatePageContainer() ) );
576         AddWizardPage( VclPtr<OWizColumnSelect>::Create(this, CreatePageContainer() ) );
577         AddWizardPage( VclPtr<OWizNormalExtend>::Create(this, CreatePageContainer() ) );
578         ActivatePage();
579     
580         m_xAssistant->set_current_page(0);
>>>     CID 1453856:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_bUseHeaderLine" is not initialized in this constructor nor in any functions that it calls.
581     }
582     
583     TabPageParent OCopyTableWizard::CreatePageContainer()
584     {
585         OString sIdent(OString::number(m_nPageCount));
586         weld::Container* pPageContainer = m_xAssistant->append_page(sIdent);

** CID 1453855:  Uninitialized members  (UNINIT_CTOR)
/dbaccess/source/core/api/datasettings.cxx: 113 in dbaccess::ODataSettings_Base::ODataSettings_Base()()


________________________________________________________________________________________________________
*** CID 1453855:  Uninitialized members  (UNINIT_CTOR)
/dbaccess/source/core/api/datasettings.cxx: 113 in dbaccess::ODataSettings_Base::ODataSettings_Base()()
107     ODataSettings_Base::ODataSettings_Base()
108         :m_bApplyFilter(false)
109         ,m_aFont(::comphelper::getDefaultFont())
110         ,m_nFontEmphasis(css::awt::FontEmphasisMark::NONE)
111         ,m_nFontRelief(css::awt::FontRelief::NONE)
112     {
>>>     CID 1453855:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_bAutoGrow" is not initialized in this constructor nor in any functions that it calls.
113     }
114     
115     ODataSettings_Base::~ODataSettings_Base()
116     {
117     }
118     

** CID 1453854:  Security best practices violations  (TOCTOU)
/sal/osl/unx/file_misc.cxx: 626 in osl_replaceFile()


________________________________________________________________________________________________________
*** CID 1453854:  Security best practices violations  (TOCTOU)
/sal/osl/unx/file_misc.cxx: 626 in osl_replaceFile()
620         int nGid = -1;
621         char destPath[PATH_MAX];
622         oslFileError eRet = FileURLToPath(destPath, PATH_MAX, ustrDestURL);
623         if (eRet == osl_File_E_None)
624         {
625             struct stat aFileStat;
>>>     CID 1453854:  Security best practices violations  (TOCTOU)
>>>     Calling function "stat" to perform check on "destPath".
626             int nRet = stat(destPath, &aFileStat);
627             if (nRet == -1)
628             {
629                 nRet = errno;
630                 SAL_INFO("sal.file", "stat(" << destPath << "): " << UnixErrnoString(nRet));
631             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB73RtgzoPcQtNNP5dkHLuV1E-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyPNJyfhUqiM0KfhgD9GjvXJWjY2GyplQm3Q1R-2FMbRibDlmTUYIt0nZtt-2BL4nRGyydsuBJMojMUaywHrhfrKa32IT7mCLypB9gyK3n-2BZiHarAcuFS1WiKfI0pWRsogp6QgM-2FjcMabV4xCjGgpbmREKfuRVaNrvjqTVcihG55MyvMc-3D