asserts removed

Xisco Fauli xiscofauli at
Fri Apr 17 19:02:01 UTC 2020

Hello all,

To my surprise, I found while checking documents with glow effects that
in f9fc420dceb1ece2c98767da16a21aaff771f140 three chunks of code were
deleted in sw/qa/extras/ooxmlexport/ooxmlexport7.cxx. See

After some investigation I found:

- First block: asserts checking the glow effect were removed <- just
needed to be adapted.

- Second block: even non glow effect asserts were removed <- This
worries me more

- Third block: glow effect is no longer exported, causing a regression
<- also worries me

I fixed first and second points in but I think unittests and
asserts are there for a reason and shouldn't be removed unless there is
a major reason to do. In this particular case, I can't find any
explanation why they were removed

Please, be consequent with your patches, I don't think removing old
unittest/asserts to make jenkins happy is the way to go.


Xisco Faulí
LibreOffice QA Team
IRC: x1sc0

More information about the LibreOffice mailing list