LO building fails with non debug mode on slideshow/source/engine/box2dtools.cxx (loplugin:staticmethods)

Sarper Akdemir q.sarperakdemir at gmail.com
Mon Aug 17 11:54:09 UTC 2020

Thanks for the heads up Julien,

On Sun, 16 Aug 2020 at 22:18, Stephan Bergmann <sbergman at redhat.com> wrote:
> (In the given cases, though, it seems more plausible to get rid of the
> asserts, which appear to not state something of relevance for those

Removed the asserts, if there's a valid box2DBody that means
box2DWorld is already initiated and assert is irrelevant.

> functions, and indeed make them static member functions or even
> non-member functions.)

and went with making them non-member functions.
The patch is up for review at https://gerrit.libreoffice.org/c/core/+/100856

More information about the LibreOffice mailing list