[core] tdf#87963: Add percentage value to new calculated compressed image size

[anshu khare]

Hi

I am developing on Visual Studio. I can access  .cxx and  .hxx files.

How can get access to  .ui files (so that I can add label to
compressgraphicdialog.ui) ?

Regards
Anshu

On Mon, 24 Aug, 2020, 12:35 AM Shivam, Kumar Singh (via Code Review), <
gerrit at gerrit.libreoffice.org> wrote:

> Shivam, Kumar Singh has posted comments on this change. (
> https://gerrit.libreoffice.org/c/core/+/101242 )
>
> Change subject: tdf#87963: Add percentage value to new calculated
> compressed image size
> ......................................................................
>
>
> Patch Set 2:
>
> The correct way to do this would be to add a new label say
> "label-new-percentage" in the svx/ui/compressgraphicdialog.ui file right
> next to where the label for the current size is added.
> After that declare a new label similar to m_xFixedText6 in
> compressgraphicdialog.hxx and initialise it
> something like this in the cxx file
>
> " m_xFixedPercentage = m_xBuilder->weld_label("label-new-percentage"); "
>
> and add the new calculated percentage to this label using set_label().
> Do you get my point?
>
> There might be a better way to do this, but this is what i would have
> done. I am adding Tomaz as a reviewer he might be able to judge this idea.
>
>
> --
> To view, visit https://gerrit.libreoffice.org/c/core/+/101242
> To unsubscribe, or for help writing mail filters, visit
> https://gerrit.libreoffice.org/settings
>
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Change-Id: I5fb87fd4d8cceb38775cb98520c0c7ba1d49bc93
> Gerrit-Change-Number: 101242
> Gerrit-PatchSet: 2
> Gerrit-Owner: Anshu <anshukhare50 at gmail.com>
> Gerrit-Reviewer: Jenkins
> Gerrit-Reviewer: Julien Nabet <serval2412 at yahoo.fr>
> Gerrit-CC: Shivam, Kumar Singh <shivamhere247 at gmail.com>
> Gerrit-CC: Tomaž Vajngerl <quikee at gmail.com>
> Gerrit-Comment-Date: Sun, 23 Aug 2020 19:04:51 +0000
> Gerrit-HasComments: No
> Gerrit-Has-Labels: No
> Gerrit-MessageType: comment
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20200824/6e117d5a/attachment.htm>