build failure on ubuntu 18.04

[Mike Kaganski]

On 03.12.2020 22:50, christie at eagle.ca wrote:
> <-snip-> 
> 
> [CXX] sal/rtl/math.cxx
> [CXX]
> workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp
> [CXX] workdir/UnpackedTarball/skia/third_party/skcms/skcms.cpp
> /home/ron/libreoffice/workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp:19:10:
> fatal error: X11/Xlib-xcb.h: No such file or directory
> #include <X11/Xlib-xcb.h>
> ^~~~~~~~~~~~~~~~
> compilation terminated.
> /home/ron/libreoffice/solenv/gbuild/LinkTarget.mk:347: recipe for target
> '/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o'
> failed
> make[1]: ***
> [/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o]
> Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:282: recipe for target 'build' failed
> make: *** [build] Error 2 
> 
> My autogen.sh command looks like this: 
> 
> ./autogen.sh --enable-debug
> --x-includes=/snap/gnome-3-34-1804/36/usr/include/ 
> 
> The file Xlib-xcb.h exists in the directory in the X11 directory which
> in turn is a child of the one listed in the --x-includes path indicated
> above. The file permission is 0644 for the .h file, owner is root. 

On 04.12.2020 1:54, Luke Benes wrote:
> Try: sudo apt-get install  libx11-xcb-dev
> 
> For some reason, the wiki was just massively paired down with stuff like this removed.
> https://wiki.documentfoundation.org/index.php?title=Development/Linux_Build_Dependencies
> 
> In the case of dependencies, less is not more.

The problem that Ron sees is clearly related to the rarely-used (and 
thus not thoroughly tested) --x-includes configuration, which obviously 
is not passed to the newly added skia external. It is a bug that needs 
fixing, and has nothing to do with using old or new wiki instructions 
(where the updated wiki article was discussed and approved on IRC, and 
is a clear improvement over old build-dep way, which results in actual 
problems when newbies report that dependencies installed that way don't 
work with master because of their versions are for older LO versions 
bundled with the distros).

Ron, that looks like a great opportunity for a first contribution to LO! 
:-) You are welcome to join #libreoffice-dev, and discuss any questions 
related to how to change the makefiles of skia to pass the correct 
information there.

-- 
Best regards,
Mike Kaganski