New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1465260:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 79 in svx::sidebar::InspectorTextPanel::updateEntries(const std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>> &)()


________________________________________________________________________________________________________
*** CID 1465260:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 79 in svx::sidebar::InspectorTextPanel::updateEntries(const std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>> &)()
73         pTreeDiagram->all_foreach([pTreeDiagram](weld::TreeIter& rEntry) {
74             pTreeDiagram->expand_row(rEntry);
75             return false;
76         });
77     
78         std::unique_ptr<weld::TreeIter> pEntry = mpListBoxStyles->make_iterator();
>>>     CID 1465260:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "get_iter_first" without checking return value (as is done elsewhere 85 out of 91 times).
79         mpListBoxStyles->get_iter_first(*pEntry);
80         mpListBoxStyles->iter_next(*pEntry);
81         mpListBoxStyles->collapse_row(*pEntry); // Collapse "Default Paragraph Style"
82     }
83     
84     InspectorTextPanel::~InspectorTextPanel() { disposeOnce(); }

** CID 1465257:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 80 in svx::sidebar::InspectorTextPanel::updateEntries(const std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>> &)()


________________________________________________________________________________________________________
*** CID 1465257:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 80 in svx::sidebar::InspectorTextPanel::updateEntries(const std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>> &)()
74             pTreeDiagram->expand_row(rEntry);
75             return false;
76         });
77     
78         std::unique_ptr<weld::TreeIter> pEntry = mpListBoxStyles->make_iterator();
79         mpListBoxStyles->get_iter_first(*pEntry);
>>>     CID 1465257:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "iter_next" without checking return value (as is done elsewhere 77 out of 79 times).
80         mpListBoxStyles->iter_next(*pEntry);
81         mpListBoxStyles->collapse_row(*pEntry); // Collapse "Default Paragraph Style"
82     }
83     
84     InspectorTextPanel::~InspectorTextPanel() { disposeOnce(); }
85     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DlOVo_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiIBpAznbzgneZpXuB0BFjgy83ui9RVkXwiRH3ReS-2FWsVFaWnBvaz26AuSsPfKEvXESqFbxX53gscsDRO-2BxlcmiDMQK11wIclgOljIGPOY0lyZ-2F1BIevZzljNgKr9gHwrz9Xt2LITiTO6Y6zj1gH1WeFCzsKT-2FWxpj26p86kRyLObEkv0xINNiZ0b-2F7pA3icqy