CI and `make screenshot` (was: [core] make the family and mask explicit in SfxStyleSheetBasePool::First)

[Stephan Bergmann]

On 06/05/2020 09:46, Caolán McNamara (via Code Review) wrote:
> Caolán McNamara has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/93461 )
> 
> Change subject: make the family and mask explicit in SfxStyleSheetBasePool::First
> ......................................................................
> 
> 
> Patch Set 2:
> 
>> Patch Set 2:
>>
>> this broke `make screenshot`
> 
> any change the screenshot targets could be built, but not run, with the default ci so its not a perennial gotcha

With a small --with-lang list, `make screenshot` executes rather 
quickly, and at least on Linux doesn't pop up any windows.  So the 
cheapest (in terms of coding) change to include it in 
<https://ci.libreoffice.org/job/gerrit_master/> would be

> diff --git a/bin/linux_clang_dbgutil_64.env b/bin/linux_clang_dbgutil_64.env
> index aaeca80..f0610d0 100644
> --- a/bin/linux_clang_dbgutil_64.env
> +++ b/bin/linux_clang_dbgutil_64.env
> @@ -5,5 +5,5 @@ export LD_LIBRARY_PATH=$LODE_HOME/opt_private/gcc-7.3.0/lib64
>  export CCACHE_CPP2=Y
>  export CCACHE_DIR=$HOME/.ccache_clang
>  export CCACHE_COMPILERCHECK=none
> -target=check
> +target="check screenshot"
>  keep_going=-k

in lode.  (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/> 
appears to build without an explicit --with-lang=... at all.)

If that is deemed too expensive, we could alternatively see to shoehorn 
an additional `make screenshot gb_SUPPRESS_TESTS=x` invocation into the 
build instructions for that job.

(That said, you can catch such issues locally with `make screenshot 
gb_SUPPRESS_TESTS=x`, and they are found post-integration by 
<https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/> and 
<https://ci.libreoffice.org/job/lo_ubsan/>---the latter because that way 
it tries to increase coverage of code that happens to get executed.)