Problem with /core/sc/qa/unit/helper/qahelper.cxx

[Stephan Bergmann]

On 12/11/2020 20:02, Regina Henschel wrote:
> with current master and make sc.check I get the error
> 
> D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): error 
> C2672: 'CppUnit::assertEquals': no matching overloade
> d function found
> D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): error 
> C2782: 'void CppUnit::assertEquals(const T &,const T
> &,CppUnit::SourceLine,const std::string &)': template parameter 'T' is 
> ambiguous
> D:\build_forCommit\core\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(161): 
> note: see declaration of 'Cpp
> Unit::assertEquals'
> D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): note: could 
> be 'tools::Long'
> D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): note: or    
> 'long'
> D:/Build_forCommit/core/sc/qa/unit/helper/qahelper.cxx(192): error 
> C2784: 'void CppUnit::assertEquals(const T &,const T
> &,CppUnit::SourceLine,const std::string &)': could not deduce template 
> argument for 'const T &' from 'tools::Long'
> D:\build_forCommit\core\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(161): 
> note: see declaration of 'Cpp
> Unit::assertEquals'
> 
> The line #192 is
>      CPPUNIT_ASSERT_EQUAL_MESSAGE("font size should be 10", 200l, 
> aFont.GetFontSize().getHeight());

that "200l" needs to be "tools::Long(200)" now; not sure why that hasn't 
been fixed yet, please go ahead and send to Gerrit (if it actually 
works, which it should :)