New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1467976:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1467976:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/uibase/uiview/view0.cxx: 536 in SwView::ExecViewOptions(SfxRequest &)()
530             lcl_SetViewMetaChars( *pOpt, bFlag );
531             break;
532     
533         case SID_AUTOSPELL_CHECK:
534             const SfxPoolItem* pItem;
535     
>>>     CID 1467976:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pArgs" to "HasItem", which dereferences it.
536             if (pArgs->HasItem(FN_PARAM_1, &pItem))
537                 bSet = static_cast<const SfxBoolItem*>(pItem)->GetValue();
538             else if( STATE_TOGGLE == eState )
539             {
540                 bFlag = !pOpt->IsOnlineSpell();
541                 bSet = bFlag;

** CID 1467975:  Control flow issues  (DEADCODE)
/sc/source/ui/view/editsh.cxx: 313 in ScEditShell::Execute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1467975:  Control flow issues  (DEADCODE)
/sc/source/ui/view/editsh.cxx: 313 in ScEditShell::Execute(SfxRequest &)()
307                 {
308                     pTableView->Paste();
309     
310                     if (pTopView)
311                     {
312                         pTopView->Paste();
>>>     CID 1467975:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "NULL" inside this statement: "pViewWindow = (pTopView ? p...".
313                         if (vcl::Window* pViewWindow = pTopView ? pTopView->GetWindow() : nullptr)
314                             pViewWindow->GrabFocus();
315                     }
316                 }
317                 break;
318     

** CID 1467974:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/app/scmod.cxx: 348 in ScModule::Execute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1467974:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/app/scmod.cxx: 348 in ScModule::Execute(SfxRequest &)()
342             case SID_AUTOSPELL_CHECK:
343                 {
344                     bool bSet;
345                     const SfxPoolItem* pItem;
346                     if (pReqArgs->HasItem(FN_PARAM_1, &pItem))
347                         bSet = static_cast<const SfxBoolItem*>(pItem)->GetValue();
>>>     CID 1467974:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pReqArgs" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
348                     else if ( pReqArgs && SfxItemState::SET == pReqArgs->GetItemState( nSlot, true, &pItem ) )
349                         bSet = static_cast<const SfxBoolItem*>(pItem)->GetValue();
350                     else
351                     {   // Toggle
352                         ScDocShell* pDocSh = dynamic_cast<ScDocShell*>( SfxObjectShell::Current() );
353                         if ( pDocSh )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D8A35_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiRRa033OGLfDBXYQaXUgmfxy3PdPJy5cNNTfgVZgBL9JpnKfuR2R2380gqTEsSaP6brtCnVq0n5iiAJQVl1HWO89eiXkWdw6HNBkbm18mgrYfkeflt-2F9HwabcvFgXgnMJMOJh8H0uEHvYanxlangi24K8xuqa-2B0D2aYni67YTPkEcRPK5awGfdzkiqu1N9lBe