About removing long time deprecated types from public API

julien2412 serval2412 at yahoo.fr
Fri Sep 11 11:42:10 UTC 2020


Hello,

I submitted https://gerrit.libreoffice.org/c/core/+/102436 "Remove unused
and deprecated sal_sChar" because it's not used in LO and has been
deprecated since 2013, see:
author	Stephan Bergmann <sbergman at redhat.com>	2013-11-27 12:50:35 +0100
committer	Stephan Bergmann <sbergman at redhat.com>	2013-11-27 12:52:32 +0100
commit	d8565bd266939b4ae4231f5b2c7d6260bee404e9 (patch)
tree	c4dc8575d838bf7f588ebb5102acc62cf7651336
parent	b5fced896632a3c07586702b461545667b33966e (diff)
Mark sal_Char, sal_sChar, sal_uChar as deprecated
...there never was a good reason to have SAL abstractions for the C/C++ char
types anyway.

So almost 7 years these types have been deprecated. Must we wait for more
years to remove them or may we go ahead?
If not what's the use of deprecation except incitating people to use C/C++
char types (at least for people who monitor deprecation warnings)?

Of course, to remove these types won't fix any bug or optimize anything but
the goal is just some decruftify/cleaning.

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html


More information about the LibreOffice mailing list