About removing long time deprecated types from public API

[Stephan Bergmann]

On 11/09/2020 18:54, julien2412 wrote:
> But replacing sal_Char triggers a lot of errors.
> First one is:
> In file included from /home/julien/lo/libreoffice/include/rtl/string.hxx:43:
> /home/julien/lo/libreoffice/include/rtl/stringconcat.hxx:384:59: error: no
> matching function for call to 'rtl_str_valueOfInt32'
>      OStringNumber(number_t i, sal_Int16 radix) { length =
> rtl_str_valueOfInt32(buf, i, radix); }
>                                                           
> ^~~~~~~~~~~~~~~~~~~~
> /home/julien/lo/libreoffice/include/rtl/string.h:623:34: note: candidate
> function not viable: no known conversion from 'char [33]' to 'signed char *'
> for 1st argument
> SAL_DLLPUBLIC sal_Int32 SAL_CALL rtl_str_valueOfInt32(
>                                   ^

Sounds like you replaced occurrences of "sal_Char" with "signed char"? 
(Anyway, hard to guess what's going wrong without seeing the patch.)