New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1489715:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/dialog/StyleList.cxx: 110 in StyleList::StyleList(weld::Builder *, std::optional<std::vector<SfxStyleFamilyItem, std::allocator<SfxStyleFamilyItem>>>, SfxBindings *, SfxCommonTemplateDialog_Impl *, SfxModule *, weld::Container *, rtl::OString, rtl::OString)()


________________________________________________________________________________________________________
*** CID 1489715:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/dialog/StyleList.cxx: 110 in StyleList::StyleList(weld::Builder *, std::optional<std::vector<SfxStyleFamilyItem, std::allocator<SfxStyleFamilyItem>>>, SfxBindings *, SfxCommonTemplateDialog_Impl *, SfxModule *, weld::Container *, rtl::OString, rtl::OString)()
104         , m_pBindings(pBindings)
105         , m_Module(Module)
106         , m_nModifier(0)
107         , m_pContainer(pC)
108     {
109         m_xFmtLb->set_help_id(HID_TEMPLATE_FMT);
>>>     CID 1489715:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_pCurObjShell" is not initialized in this constructor nor in any functions that it calls.
110     }
111     
112     // Destructor
113     
114     StyleList::~StyleList() {}
115     

** CID 1489714:  Code maintainability issues  (UNUSED_VALUE)
/sfx2/source/dialog/templdlg.cxx: 293 in SfxCommonTemplateDialog_Impl::UpdateStyles_Hdl(StyleFlags)()


________________________________________________________________________________________________________
*** CID 1489714:  Code maintainability issues  (UNUSED_VALUE)
/sfx2/source/dialog/templdlg.cxx: 293 in SfxCommonTemplateDialog_Impl::UpdateStyles_Hdl(StyleFlags)()
287     {
288         const SfxStyleFamilyItem* pItem = m_aStyleList.GetFamilyItem();
289         SfxStyleSearchBits nFilter(nActFilter < pItem->GetFilterList().size()
290                                        ? pItem->GetFilterList()[nActFilter].nFlags
291                                        : SfxStyleSearchBits::Auto);
292         if (nFilter == SfxStyleSearchBits::Auto) // automatic
>>>     CID 1489714:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "this->nAppFilter" to "nFilter" here, but that stored value is overwritten before it can be used.
293             nFilter = nAppFilter;
294     
295         if (nFlags & StyleFlags::UpdateFamily) // Update view type list (Hierarchical, All, etc.
296         {
297             CheckItem(OString::number(nActFamily)); // check Button in Toolbox
298     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DbvlA_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJibyFXcp2BSjbWWHwprB-2Beqe-2BNVXryV8GFOAjWyScuw-2BsDnUv8tOFvzHg-2FzppES2PFqAquFpExdtVkh5uL6TPJl-2FoQYqAuCHQTTpSZ0qFT6Wh9Cek1KslpHPF9A7Q-2FOmTKK3vieDyVJT3vtcO-2FLljAKSURxNzgc4UowJD-2BOKHd-2Fn8-3D