New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1486243:  Possible Control flow issues  (DEADCODE)
/vcl/source/control/roadmapwizard.cxx: 329 in vcl::RoadmapWizard::implUpdateRoadmap()()


________________________________________________________________________________________________________
*** CID 1486243:  Possible Control flow issues  (DEADCODE)
/vcl/source/control/roadmapwizard.cxx: 329 in vcl::RoadmapWizard::implUpdateRoadmap()()
323             bool bCurrentPageCanAdvance = true;
324             TabPage* pCurrentPage = GetPage( getCurrentState() );
325             if ( pCurrentPage )
326             {
327                 const IWizardPageController* pController = nullptr;
328                 OSL_ENSURE( pController != nullptr, "RoadmapWizard::implUpdateRoadmap: no controller for the current page!" );
>>>     CID 1486243:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "pController->canAdvance()" inside this statement: "bCurrentPageCanAdvance = !p...".
329                 bCurrentPageCanAdvance = !pController || pController->canAdvance();
330             }
331     
332             // now, we have to remove all items after nCurrentStatePathIndex, and insert the items from the active
333             // path, up to (excluding) nUpperStepBoundary
334             RoadmapTypes::ItemIndex nLoopUntil = ::std::max( nUpperStepBoundary, m_xRoadmapImpl->pRoadmap->GetItemCount() );

** CID 1486242:  Control flow issues  (DEADCODE)
/vcl/source/control/roadmapwizard.cxx: 383 in vcl::RoadmapWizard::implUpdateRoadmap()()


________________________________________________________________________________________________________
*** CID 1486242:  Control flow issues  (DEADCODE)
/vcl/source/control/roadmapwizard.cxx: 383 in vcl::RoadmapWizard::implUpdateRoadmap()()
377                 }
378     
379                 // if the item is *after* the current state, but the current page does not
380                 // allow advancing, the disable the state. This relieves derived classes
381                 // from disabling all future states just because the current state does not
382                 // (yet) allow advancing.
>>>     CID 1486242:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "nItemIndex > nCurrentStatePathIndex" inside this statement: "bUnconditionedDisable = !bC...".
383                 const bool bUnconditionedDisable = !bCurrentPageCanAdvance && ( nItemIndex > nCurrentStatePathIndex );
384                 const bool bEnable = !bUnconditionedDisable && ( m_xRoadmapImpl->aDisabledStates.find( nState ) == m_xRoadmapImpl->aDisabledStates.end() );
385     
386                 m_xRoadmapImpl->pRoadmap->EnableRoadmapItem( m_xRoadmapImpl->pRoadmap->GetItemID( nItemIndex ), bEnable );
387             }
388     

** CID 1486241:  Possible Control flow issues  (DEADCODE)
/vcl/source/control/wizardmachine.cxx: 685 in vcl::RoadmapWizard::prepareLeaveCurrentState(vcl::WizardTypes::CommitPageReason)()


________________________________________________________________________________________________________
*** CID 1486241:  Possible Control flow issues  (DEADCODE)
/vcl/source/control/wizardmachine.cxx: 685 in vcl::RoadmapWizard::prepareLeaveCurrentState(vcl::WizardTypes::CommitPageReason)()
679             Finish( RET_OK );
680         }
681     
682         bool RoadmapWizard::prepareLeaveCurrentState( WizardTypes::CommitPageReason _eReason )
683         {
684             IWizardPageController* pController = nullptr;
>>>     CID 1486241:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: ";".
685             ENSURE_OR_RETURN( pController != nullptr, "RoadmapWizard::prepareLeaveCurrentState: no controller for the current page!", true );
686             return pController->commitPage( _eReason );
687         }
688     
689         bool RoadmapWizard::skipBackwardUntil( WizardTypes::WizardState _nTargetState )
690         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DS5q9_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJim8PyfXycapxDXKkv-2FYbqdUCZuJo4WvfZLjKh5S74XJJqYS1AWII3eA-2BRV265tB-2BVgeVH74yEEzj7AXfFbww9lfT-2BykLPw1h-2FNj-2BLxXYV4YIkKwhHgJOHys-2B8YBbMPaDmFu03dgKq1m7tr9x-2Bpx4AlKrM6hwZx1npCtQvm7rkR0E-3D