proposition for patch in CommonSalLayout.cxx

[Stanisław Jeśmanowicz]

On 3/9/21 6:34 PM, julien2412 wrote:
> Stanisław Jeśmanowicz wrote
>> ...
>> Thank you for your advice, but getting familiar with gerrit on top of git
>> would take some time for
>> me now.
>> I hope, that some of your developers could commit this patch for me in vcl
>> module.
>> It is simple and won't harm anything.
>> But people could benefit from it on all platforms that use system's native
>> HarfBuzz implementation.
>> ...
> 
> I can understand you don't have time for gerrit but would it be possible you
> submit a license statement?
I have created an account and can log in to https://gerrit.libreoffice.org/
but it is not clear for me where to submit a license statement.
> 
> About this line, I retrieved the initial patches which put this line:
> 1) earliest
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316:
> Author: Khaled Hosny <khaledhosny at eglug.org>
> Date:   Fri Mar 10 16:53:08 2017 +0200
> 
>      tdf#106466: Use graphite2 shaper first
>      
>      We want to always prefer Graphite shaping when supported by the font,
>      which is also what HarfBuzz does by default.

This is not always the case, because if a platform didn't include graphite2 shaper in its HarfBuzz 
implementaion, you won't have it anyway ( like ./configure --with-graphite2=no )
Even if you set it the shapers list (as in 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316 )
And if graphite2 shaper is implemented, then it will be first (as you can see in the harfbuzz code: 
https://github.com/harfbuzz/harfbuzz/blob/master/src/hb-shaper-list.hh )
And generally speaking, hard-coded list in such a case disables possible new shapers.

>      
>      Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655
>      Reviewed-on: https://gerrit.libreoffice.org/35046
>      Tested-by: Jenkins <ci at libreoffice.org>
>      Reviewed-by: Khaled Hosny <khaledhosny at eglug.org>
> 
> 
> 2) oldest
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=7854d35cd8172b201f1f3ad247860f242e5cb06b
> Author: Khaled Hosny <khaledhosny at eglug.org>
> Date:   Thu Oct 6 04:15:41 2016 +0200
> 
>      Use HarfBuzz shape plan for a bit more control
>      
>      This way we control exactly what shapers we use in what order, and as an
>      extra we can now tell which shaper HarfBuzz ends up using.
> 
> Julien
> 
> 
> 
> --
> Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

Stan

-- 
__________________________________________________________

Stanislaw Jesmanowicz      stan <at> mail2 <dot> jesmanowicz <dot> com
Amsterdam                  voice : + 31 20 6126193
The Netherlands            mobile: + 31  653380520