New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1484879:    (UNINIT_CTOR)
/sw/source/uibase/inc/wrtsh.hxx: 680 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)()
/sw/source/uibase/inc/wrtsh.hxx: 671 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)()


________________________________________________________________________________________________________
*** CID 1484879:    (UNINIT_CTOR)
/sw/source/uibase/inc/wrtsh.hxx: 680 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)()
674                         m_pWrtSh->GetViewOptions()->IsShowOutlineContentVisibilityButton())
675                 {
676                     m_pWrtSh->StartAllAction();
677                     m_pWrtSh->MakeAllFoldedOutlineContentVisible();
678                     m_bDone = true;
679                 }
>>>     CID 1484879:    (UNINIT_CTOR)
>>>     Non-static class member "m_pWrtSh" is not initialized in this constructor nor in any functions that it calls.
680         }
681     
682         ~MakeAllOutlineContentTemporarilyVisible() COVERITY_NOEXCEPT_FALSE
683         {
684             --nLock;
685             if (nLock > 0)
/sw/source/uibase/inc/wrtsh.hxx: 671 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)()
665     public:
666         static sal_uInt32 nLock;
667         MakeAllOutlineContentTemporarilyVisible(SwDoc* pDoc)
668         {
669             ++nLock;
670             if (nLock > 1)
>>>     CID 1484879:    (UNINIT_CTOR)
>>>     Non-static class member "m_pWrtSh" is not initialized in this constructor nor in any functions that it calls.
671                 return;
672             if (SwDocShell* pDocSh = pDoc->GetDocShell())
673                 if ((m_pWrtSh = pDocSh->GetWrtShell()) && m_pWrtSh->GetViewOptions() &&
674                         m_pWrtSh->GetViewOptions()->IsShowOutlineContentVisibilityButton())
675                 {
676                     m_pWrtSh->StartAllAction();

** CID 1484878:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/oox/autofilterbuffer.cxx: 408 in oox::xls::ColorFilter::ColorFilter(const oox::xls::WorkbookHelper &)()


________________________________________________________________________________________________________
*** CID 1484878:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/oox/autofilterbuffer.cxx: 408 in oox::xls::ColorFilter::ColorFilter(const oox::xls::WorkbookHelper &)()
402         return aSettings;
403     }
404     
405     ColorFilter::ColorFilter(const WorkbookHelper& rHelper)
406         : FilterSettingsBase(rHelper)
407     {
>>>     CID 1484878:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbIsBackgroundColor" is not initialized in this constructor nor in any functions that it calls.
408     }
409     
410     void ColorFilter::importAttribs(sal_Int32 nElement, const AttributeList& rAttribs)
411     {
412         if (nElement == XLS_TOKEN(colorFilter))
413         {

** CID 1484877:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1484877:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/uibase/docvw/FrameControlsManager.cxx: 212 in SwFrameControlsManager::SetOutlineContentVisibilityButton(const SwContentFrame *)()
206                                             m_pEditWin, pContentFrame).get());
207             rControls.insert(lb, make_pair(pContentFrame, pNewControl));
208             pControl.swap(pNewControl);
209         }
210     
211         SwOutlineContentVisibilityWin* pWin = dynamic_cast<SwOutlineContentVisibilityWin *>(pControl->GetWindow());
>>>     CID 1484877:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pWin" to "Set", which dereferences it.
212         pWin->Set();
213     
214         if (pWin->GetSymbol() == ButtonSymbol::SHOW)
215             pWin->Show(); // show the SHOW button immediately
216         else if (!pWin->IsVisible() && pWin->GetSymbol() == ButtonSymbol::HIDE)
217             pWin->ShowAll(true);

** CID 1465676:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx: 114 in SwOutlineContentVisibilityWin::Set()()


________________________________________________________________________________________________________
*** CID 1465676:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx: 114 in SwOutlineContentVisibilityWin::Set()()
108     {
109         const SwTextFrame* pTextFrame = static_cast<const SwTextFrame*>(GetFrame());
110         const SwTextNode* pTextNode = pTextFrame->GetTextNodeFirst();
111         SwWrtShell& rSh = GetEditWin()->GetView().GetWrtShell();
112         const SwOutlineNodes& rOutlineNodes = rSh.GetNodes().GetOutLineNds();
113     
>>>     CID 1465676:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "Seek_Entry" without checking return value (as is done elsewhere 22 out of 24 times).
114         rOutlineNodes.Seek_Entry(static_cast<SwNode*>(const_cast<SwTextNode*>(pTextNode)),
115                                  &m_nOutlinePos);
116     
117         // set symbol displayed on button
118         bool bVisible = true;
119         const_cast<SwTextNode*>(pTextNode)->GetAttrOutlineContentVisible(bVisible);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D7nlg_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiUHhikDMl6-2BHhIz-2BgiMpn8xR0tSjO75bHnoA6Mimz2g8Qy8NPfSKA6xZ744aRpN-2B9fAEqChLybf4SVTstuScteYVMPUwpuVzfS2X8lyT3QagqoTO6jetjkrCrBgJxmgG-2FiYdKJJadiW8f5tOXYifw2WV1RiMbSeCbU6Oqo8Kdkqo-3D