New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1494447:  Control flow issues  (DEADCODE)
/ucb/source/ucp/webdav-curl/CurlSession.cxx: 992 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession &, const http_dav_ucp::CurlUri &, curl_slist *, const com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> *, const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> *, const std::pair<const std::vector<rtl::OUString, std::allocator<rtl::OUString>> &, http_dav_ucp::DAVResource &> *, <unnamed>::ResponseHeaders &)()


________________________________________________________________________________________________________
*** CID 1494447:  Control flow issues  (DEADCODE)
/ucb/source/ucp/webdav-curl/CurlSession.cxx: 992 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession &, const http_dav_ucp::CurlUri &, curl_slist *, const com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> *, const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> *, const std::pair<const std::vector<rtl::OUString, std::allocator<rtl::OUString>> &, http_dav_ucp::DAVResource &> *, <unnamed>::ResponseHeaders &)()
986             ExtractRequestedHeaders(rHeaders, pRequestedHeaders);
987         }
988         else
989         {
990             switch (statusCode)
991             {
>>>     CID 1494447:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "case 0L:".
992                 case SC_NONE:
993                     assert(false); // ??? should be error returned from perform?
994                     break;
995                 case SC_REQUEST_TIMEOUT:
996                 {
997                     throw DAVException(

** CID 1494446:  Uninitialized members  (UNINIT_CTOR)
/ucb/source/ucp/webdav-curl/CurlSession.cxx: 692 in http_dav_ucp::CurlSession::CurlSession(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const rtl::Reference<http_dav_ucp::DAVSessionFactory> &, const rtl::OUString &, const com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> &, const ucbhelper::InternetProxyDecider &)()


________________________________________________________________________________________________________
*** CID 1494446:  Uninitialized members  (UNINIT_CTOR)
/ucb/source/ucp/webdav-curl/CurlSession.cxx: 692 in http_dav_ucp::CurlSession::CurlSession(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const rtl::Reference<http_dav_ucp::DAVSessionFactory> &, const rtl::OUString &, const com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> &, const ucbhelper::InternetProxyDecider &)()
686         {
687             // neon would close the connection from ne_end_request(), this seems
688             // to be the equivalent and not CURLOPT_TCP_KEEPALIVE
689             rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_FORBID_REUSE, 1L);
690             assert(rc == CURLE_OK);
691         }
>>>     CID 1494446:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_AbortFlag._M_base" is not initialized in this constructor nor in any functions that it calls.
692     }
693     
694     CurlSession::~CurlSession() {}
695     
696     auto CurlSession::CanUse(OUString const& rURI, uno::Sequence<beans::NamedValue> const& rFlags)
697         -> bool

** CID 1494445:  Concurrent data access violations  (MISSING_LOCK)
/framework/source/helper/statusindicatorfactory.cxx: 522 in framework::StatusIndicatorFactory::impl_reschedule(bool)()


________________________________________________________________________________________________________
*** CID 1494445:  Concurrent data access violations  (MISSING_LOCK)
/framework/source/helper/statusindicatorfactory.cxx: 522 in framework::StatusIndicatorFactory::impl_reschedule(bool)()
516         // SAFE ->
517         std::unique_lock aRescheduleGuard(rescheduleLock);
518     
519         if (m_nInReschedule != 0)
520             return;
521     
>>>     CID 1494445:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "framework::StatusIndicatorFactory::m_nInReschedule" without holding lock "std::unique_lock<std::mutex>._M_device". Elsewhere, "framework::StatusIndicatorFactory::m_nInReschedule" is accessed with "std::unique_lock<std::mutex>._M_device" held 1 out of 2 times (1 of these accesses strongly imply that it is necessary).
522         ++m_nInReschedule;
523         aRescheduleGuard.unlock();
524         // <- SAFE
525     
526         {
527             SolarMutexGuard g;

** CID 1494444:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1494444:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/core/data/table3.cxx: 3054 in ScTable::ValidQuery(int, const ScQueryParam &, const ScRefCellValue *, bool *, const ScInterpreterContext *, sc::TableColumnBlockPositionSet *, ScTable::ValidQueryCache *)()
3048             ScRefCellValue aCell;
3049             if(pCell && it == itBeg)
3050                 aCell = *pCell;
3051             else if( pBlockPos )
3052             {   // hinted mdds access
3053                 ScColumn* column = FetchColumn(nCol);
>>>     CID 1494444:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "nullptr" "column" when calling "GetCellValue".
3054                 aCell = column->GetCellValue(*pBlockPos->getBlockPosition( nCol ), nRow);
3055             }
3056             else
3057                 aCell = GetCellValue(nCol, nRow);
3058     
3059             std::pair<bool,bool> aRes = validQueryProcessEntry(nRow, nCol, nTab, rParam, aCell,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dfwj4_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiar9X9G1wcThd76egN-2FqrKkiKoM6cFeWZEvliEbhBgmGK-2BAV6U2wgcsbOtUhQoaDcOQgpVjDWXj10GtRm8ZX5J0kuQVVAmQr4Qa-2Bx3X5PZXYwHPDcYFPO8f1JpXHxe3FENAIRW6sZZFJNvvFYUK2naeBDzceDB9tUss3zxnL1ChE-3D