ESC meeting minutes: 2022-01-13

Miklos Vajna vmiklos at collabora.com
Thu Jan 13 15:44:53 UTC 2022


* Present:
     + Sophie, Stephan, Michael S, Kendy, Ilmari, Hossein, Gabriel, Eike, Cloph, Chris, Olivier, Miklos, Xisco, Caolan, Michael M

* Completed Action Items:
     + Update “[Bug 146386] Drop support for FTP” to support the removal (Heiko)
     + submit the change to turn on mergelibs for the gcc/release CI config (Jan-Marek)

* Pending Action Items:
     + None

* Release Engineering update (Cloph)
     + 7.2 status: 7.2.6 rc1 in 5 weeks
     + 7.3 status: 7.3.0 rc2 is tagged, builds to be available tomorrow
       + "hard code freeze" stage, rc3 in 2 weeks
     + Remotes: Android, iOS
     + Android viewer

* Documentation (Olivier)
     + New Help, no news
     + Helpcontent2
        + several bug smash by R. Lima, and oHallot
        + Typos and fixes from translators (S. Horacek, A. Barrientos)

      + Guides
          + Published Draw Guide 7.2 (Peter Schofield)
          + Work in progress towards 7.3 (S. Fanning Jean Weber, P. Schofield

     + Bugzilla Documentation statistics
         241(241) bugs open
     + Updates:
         BZ changes   1 week    1 month   3 months   12 months
            created     16(-3)     48(7)     93(3)      315(-3)
          commented     32(-26)   147(21)   369(16)    1654(10)
           resolved      5(-2)     20(0)     50(4)      194(0)
     + top 10 contributors:
           Rafael Lima made 66 changes in 1 month, and 321 changes in 1 year
           Olivier Hallot made 33 changes in 1 month, and 501 changes in 1 year
           Nabet, Julien made 18 changes in 1 month, and 52 changes in 1 year
           Ilmari Lauhakangas made 14 changes in 1 month, and 90 changes in 1 year
           Foote, V Stuart made 13 changes in 1 month, and 69 changes in 1 year
           Kaganski, Mike made 10 changes in 1 month, and 96 changes in 1 year
           gmarco made 9 changes in 1 month, and 16 changes in 1 year
           Dieter made 8 changes in 1 month, and 119 changes in 1 year
           Heiko Tietze made 7 changes in 1 month, and 92 changes in 1 year
           Alain Romedenne made 5 changes in 1 month, and 27 changes in 1 year

* UX Update (Heiko)
     + Missing Heiko
     + Bugzilla (topicUI) statistics
         257(257) (topicUI) bugs open, 149(149) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month    3 months   12 months
              added      2(0)      3(-5)     18(-8)      80(-6)
          commented     62(7)    172(-55)   587(-18)   3025(-13)
            removed      0(0)      2(-2)      7(0)       36(0)
           resolved     11(7)     24(-2)     81(6)      413(-1)
     + top 10 contributors:
           Heiko Tietze made 119 changes in 1 month, and 2036 changes in 1 year
           Foote, V Stuart made 37 changes in 1 month, and 539 changes in 1 year
           Kaganski, Mike made 31 changes in 1 month, and 182 changes in 1 year
           MarjaE made 20 changes in 1 month, and 20 changes in 1 year
           Ilmari Lauhakangas made 13 changes in 1 month, and 356 changes in 1 year
           Dieter made 11 changes in 1 month, and 262 changes in 1 year
           Telesto made 10 changes in 1 month, and 417 changes in 1 year
           Stéphane Guillou made 9 changes in 1 month, and 72 changes in 1 year
           Coolman made 8 changes in 1 month, and 8 changes in 1 year
           Kainz, Andreas made 7 changes in 1 month, and 33 changes in 1 year

    + 9 new tickets since Jan/06
      + [Bug 146700] [Enhancement] have an UI way to switch arrow
      + [Bug 146719] Numbered list has 'Character Style" entry in context menu
             but pick Emphasis does nothing
      + [Bug 146720] UI: List in context menu for ordered list doesn't change
             the existing list style, but starts a new list
      + [Bug 146706] If ordered list is turned with F12 Character formatting
             is applied. If Format -> Bullet & Numbering it's set to NONE
      + [Bug 146667] Code Folding in the BASIC IDE's editor
      + [Bug 146647] [UI] Reword for Match in the Find and Replace dialog
      + [Bug 146651] FIND AND REPLACE: difficult to recognize certain
             search/replace terms, enlarge the UI font (optionally) for clarity
      + [Bug 146612] UI Warning dialog when pressing Apply in
             Hyperlink dialog - New Document tab
      + [Bug 145996] Collate Rows and Columns

   -> + Improve frames eg. with rotation vs. focus on text boxes
        (bug 14092 & bug 118348)
        + interesting discussion with good arguments for both
        + consolidation makes sense from usability POV

* Crash Testing (Caolan)
     + 12(-2) import failure, 6(+3) export failures
       - there are new crashes in here, I suspect
       121cbc250b36290f0f8c7265fea57256dad69553 tdf#66039 DOCX: import textboxes
       for at least some of them
     + 3 coverity issues
       - fixed in git
     + 12 ossfuzz issues, 6 timeouts 6 crashes.
       - Two crashes probably fixed in next run.
     + crashtesting code: fixed incrementally ever-growing zip file used as a transport while uploading

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.1.8.1
          + (+414) 907 493 137 0
    + https://crashreport.libreoffice.org/stats/version/7.2.4.1
          + (+177) 1783 1606 370 0
    + https://crashreport.libreoffice.org/stats/version/7.2.5.2
          + (+691) 691 0


    + Some crashes fixed in 7.2.5.2

     - sw::mark::MarkManager::renameMark(sw::mark::IMark *,rtl::OUString const &)

     - Thanks to M. Stahl

     - std::make_unique<sw::sidebar::WriterInspectorTextPanel,weld::Widget * &,0>

     - Thanks to Caolán

     - mdds::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::noncopyable_managed_element_block<55,ScPostIt> >,mdds::detail::mtv::event_func>::get<ScPostIt *>

     - Thanks to Julien Nabet


    + Top 1 in 7.2.5.2
      - https://crashreport.libreoffice.org/stats/signature/SalInstanceTreeView::get_drag_source()

* Mentoring/EasyHack update (Hossein)
           committer...   1 week     1 month    3 months   12 months
                   open      70(14)     111(3)     156(6)      207(-9)
                reviews     422(96)    1308(78)   3234(64)   10790(262)
                 merged     302(41)    1319(21)   4058(21)   13235(331)
              abandoned      18(3)       71(5)     170(3)      615(18)
            own commits     229(3)      975(45)   3128(-6)   12797(-5)
         review commits      57(-25)    292(21)   1015(2)     4195(-48)
         contributor...   1 week     1 month    3 months    12 months
                   open      41(18)      71(13)    104(11)      208(25)
                reviews     848(86)    3090(92)   8834(36)    29518(644)
                 merged      11(-22)     89(3)     351(-17)    1502(-24)
              abandoned       6(-3)      27(6)      52(2)       409(6)
            own commits       7(-41)    124(0)     472(-17)    1879(-48)
         review commits       0(0)        0(0)       0(0)         0(0)
     + easyHack statistics:
        needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 282(282)
        total 336(336)   assigned 30(30)   open 277(277)
     + top 10 contributors:
           Johnny_M made 84 patches in 1 month, and 921 patches in 1 year
           Kevin Suo made 6 patches in 1 month, and 31 patches in 1 year
           Attila Bakos made 4 patches in 1 month, and 30 patches in 1 year
           Vaibhav Malik made 4 patches in 1 month, and 5 patches in 1 year
           Ramreiso Kashung made 4 patches in 1 month, and 4 patches in 1 year
           Ismael Luceno made 3 patches in 1 month, and 5 patches in 1 year
           Dhiraj Holden made 3 patches in 1 month, and 3 patches in 1 year
           scito made 2 patches in 1 month, and 19 patches in 1 year
           Po-Yen Huang made 2 patches in 1 month, and 7 patches in 1 year
           Olivier R made 2 patches in 1 month, and 2 patches in 1 year
     + top 10 reviewers:
           Thorsten Behrens made 150 review comments in 1 month, and 580 in 1 year
           Olivier Hallot made 148 review comments in 1 month, and 1176 in 1 year
           Adolfo Jayme Barrientos made 112 review comments in 1 month, and 786 in 1 year
           Kaganski, Mike made 82 review comments in 1 month, and 730 in 1 year
           Xisco Fauli made 78 review comments in 1 month, and 762 in 1 year
           Rathke, Eike made 62 review comments in 1 month, and 274 in 1 year
           Nabet, Julien made 62 review comments in 1 month, and 416 in 1 year
           Vajna, Miklos made 56 review comments in 1 month, and 526 in 1 year
           Hossein made 54 review comments in 1 month, and 160 in 1 year
           McNamara, Caolán made 42 review comments in 1 month, and 454 in 1 year
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Alexander Solodukhin
           Alain Romedenne
   + Merged commits from the contributors: 11 -> All code related, no translations
   + 2 New contributors
   + Collaboration with a high school
     + problem: they are (only?) familiar with Python
     + hope to focus on the little areas of LO that are implemented in Python
     + might be helpful to explicitly require C++ from students (Miklos)

* Commit Access
   + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 2 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
processing /home/ci/jenkins/home/global-build-stats/jobresults/jobResults-2022-01.xml
     from:Thu Jan  6 15:06:55 2022
     master linux rel  jobs: 130 ok: 122 ko:   8 fail ratio:  6.15 % break:   6 broken duration: 2.93%
     master linux dbg  jobs: 123 ok:  90 ko:  32 fail ratio: 26.02 % break:  11 broken duration:21.05%
     master mac rel    jobs: 114 ok: 106 ko:   8 fail ratio:  7.02 % break:   2 broken duration: 3.65%
     master mac dbg    jobs: 113 ok: 104 ko:   9 fail ratio:  7.96 % break:   2 broken duration: 3.42%
     master win rel    jobs:  85 ok:  83 ko:   2 fail ratio:  2.35 % break:   1 broken duration: 2.14%
     master win dbg    jobs:  87 ok:  85 ko:   2 fail ratio:  2.30 % break:   1 broken duration: 2.14%
     master win64 dbg  jobs:  83 ok:  81 ko:   2 fail ratio:  2.41 % break:   1 broken duration: 2.12%
     master gerrit lin jobs: 568 ok: 418 ko: 124 fail ratio: 21.83% time for ok: mean:  21 median:  17
     master gerrit plg jobs: 504 ok: 318 ko: 143 fail ratio: 28.37% time for ok: mean:  45 median:  41
     master gerrit win jobs: 604 ok: 394 ko: 144 fail ratio: 23.84% time for ok: mean:  67 median:  64
     master gerrit mac jobs: 550 ok: 417 ko:  95 fail ratio: 17.27% time for ok: mean:  32 median:  28
     master android    jobs: 457 ok: 397 ko:  33 fail ratio:  7.22% time for ok: mean:  24 median:  18
     master gerrit all jobs: 554 ok: 256 ko: 230 fail ratio: 41.52% time for ok: mean:  97 median:  79

    + https://dev-www.libreoffice.org/tmp/gerrit_220113.html
    + tests that failed more than twice in last seven days:
       3 CppunitTest_sw_mailmerge                gerrit_windows
       4 CppunitTest_sc_subsequent_export_test2                gerrit_windows
       8 UITest_signatureLine                gerrit_linux_clang_dbgutil
      18 CppunitTest_sd_misc_tests                gerrit_linux_clang_dbgutil
      24 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      41 CppunitTest_sd_misc_tests                gerrit_linux_gcc_release
     + large number of test failures on Linux
       + think it's already fixed on master (Cloph)
       + CppunitTest_sd_misc_tests was fixed by Mike (Miklos)


* l10n (Sophie)
   + new Polish and Swedish translators
   + copyright year update caused some not needed work, but fixed (Cloph)

* FOSDEM 2022 (Italo)
   + January 23 is deadline for uploading devroom videos to Penta
   + **no exceptions**, deadline imposed by FOSDEM organisers so they can

         bulk-transcode

   + lightning talks (Thorsten)
     + if you have such a talk: send the video to Thorsten, and then he'll stream it
     + otherwise don't miss the above deadline!

* Ongoing macOS runtime bumpage (Ilmari)
   + Apple is whipping C++ projects to raise their minimum runtime by not providing certain STL features in older macOS versions
   + No complaints from users
     + https://ask.libreoffice.org/t/intention-to-raise-minimum-required-macos-version/69894
     + https://www.reddit.com/r/libreoffice/comments/qkj64c/intention_to_raise_minimum_required_macos_version/
   + Announced in 7.3 release notes: https://wiki.documentfoundation.org/ReleaseNotes/7.3#Platform_Compatibility
   + 7.4 is now at 10.13 https://git.libreoffice.org/core/commit/3e94991d7fd3a085549c3a5d4c991688042d2cb9
   + fine with this (Stephan)
   + build-time requirement side (Stephan)
     + older than Xcode 12.5: std::optional::value() is not available
       + fixed Xcode 12.5, which only runs on macOS 11, which is not available to some older Apple HW
       + current TDF macs run 10.14 -> possible to upgrade, but need to do the work (Cloph)
         + need to make sure release branches build with latest Xcode
         + apple M1 machine is happy with the release branches, so expect no problems
   + does this affect runtime? (Chris)
     + no, just build-time
=> do it in early Feb, after the 7.3.0 builds are done (all)

* tdf#140286 What should =INFO(OSVERSION) show? (Chris Sherlock)
   + Excel shows:
     * Windows 10 Home: Windows (64-bit) NT 10.00
     * macOS Big Sur: Macintosh (Intel) Version 11.6.2 (Build 20G314)
   + What should SalInstance::getOSVersion show?
     + currently:
       * Linux: Linux version 3.16.7-29-desktop
       * FreeBSD: just kernel version string
       * Other Unix: just kernel version string
       * MacOS: Mac OS X 11.6.2 (not Darwin kernel version)
       * Windows: Windows 6.1 Service Pack 1 build 7601
     + Should it show the distribution and vendor?
     + If so, should the function be changed to just get the kernel version?
       * If not, should there be another function that gets the release?
       * If the later, then should we alter MacOS getOSVersion to get the Darwin kernel version and another function gives the MacOS "distribution"?
     + may need to update documentation if change to Excel function
     + just return the same value as Excel (Eike)
       + on Windows and macOS
         + what we have currently: legacy compat from several years ago
       + patch submitted is https://gerrit.libreoffice.org/c/core/+/127921
     + what we return on Linux is not important (Eike)
       + we don't know the actual end-user use-case

* What’s cooking (Miklos)
   + vcl-level text layout improvements (Caolan)
     + trying to make the positions of glyphs in Writer stable with different zoom levels
       + focusing on cairo, X11+skia, Windows
       + no changes when asking info from vcl, just for drawing glyphs
     + looking forward to it (Thorsten)
     + interested to test that with non-Latin layouts (Hossein)
       + it's opt-in for now, fear not (Caolan)

* QA update (Xisco)

     + UNCONFIRMED: 1656 (+34)
         + enhancements: 252  (+2)
         + needsUXEval: 2 (-5)
         + haveBackTrace: 4 (+0)
         + needsDevAdvice: 28 (+0)
         + documentation:  9 (-2)
         + android:  1 (+0)
         + iOS:  0 (+0)
         + Online:  10 (+0)


     + Most pressing bugs:
      New:

     None

      Old:
         + Slow typing in Writer with version 7.1 or above on Windows 11
             + https://bugs.documentfoundation.org/show_bug.cgi?id=145963
             + Lubos?
             + seems to be Windows 11-only

         + macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128233

         + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from
           imported PDF are reversed, PDFIProcessor::mirrorString not behaving
             + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
             + already listed here for 2 years, and many duplicates


     + New high severity bugs of the week:
         + Autocorrection for all languages doesn't work anymore
             + https://bugs.documentfoundation.org/show_bug.cgi?id=141773
             + Julien?
             + the commit introducing this regression fixed a more important one
             + will ask Laszlo if he has an idea

* QA stats
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +132  -16 (-127) overall)
       many thanks to the top bug squashers:
        Mike Kaganski           9
        QA Administrators       9
        Caolán McNamara         8
        Heiko Tietze            8
        Attila Bakos (NISZ)     6
        Telesto                 6
        Timur                   6
        Aron Budea              4
        Buovjaga                4
        László Németh           4

     + top 10 bugs reporters:
        Telesto                 10
        Gabor Kelemen (allotropia) 3
        John                    3
        Timur                   3
        dainius.mazuika         3
        D. Gold                 2
        Damian Hofmann          2
        Kevin Suo               2
        Regina Henschel         2
        Roman Kuznetsov         2

     + top 10 bugs fixers:
        McNamara, Caolán        7
        Grandin, Noel           4
        Kaganski, Mike          3
        Jaise James             2
        Justin Luth             2
                                1
        Adolfo Jayme Barrientos 1
        Andras Timar            1
        Andreas Heinisch        1
        Attila Bakos            1

     + top 10 bugs confirmers:
        Dieter                  6
        Timur                   6
        Heiko Tietze            5
        Ilmari Lauhakangas      5
        *UNKNOWN*               4
        Telesto                 4
        Kaganski, Mike          3
        Nabet, Julien           3
        Rafael Lima             3
        m.a.riosv               3

* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 1/53 -     1 %  (+0)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 1/36 -     2 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 3/85 -     3 %  (+0)
      4.0 : 2/83 -     2 %  (+0)
      old : 2/247 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Timur                  5
         Telesto                2
         Roman Kuznetsov        1
         Ilmari Lauhakangas     1
         Michael Stahl          1
         Kaganski, Mike         1

* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Timur                  6
         Telesto                2
         Roman Kuznetsov        1
         Ilmari Lauhakangas     1
         Kaganski, Mike         1

* all bugs tagged with 'regression'
    + 1280(-2) bugs open of 11470(+20) total 11(-1) high prio.

      done by:
         Timur                  6
         Telesto                3
         Roman Kuznetsov        2
         Ilmari Lauhakangas     2
         Dieter                 1
         Kaganski, Mike         1

* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 8(-1)
      Calc          - 1(+0)
      Draw          - 1(+0)
      LibreOffice   - 1(+0)

    by OS:
      All           - 10(-1)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 1(+0)

* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 434(-4)
      Calc                     - 215(+1)
      Impress                  - 131(+0)
      Writer: docx filter      - 55(+1)
      UI                       - 49(+1)
      Draw                     - 48(+0)
      LibreOffice              - 47(-3)
      Crashes                  - 46(+0)
      Borders                  - 39(-1)
      Writer: perf             - 38(+1)
      Writer: other filter     - 36(+1)
      Base                     - 34(+0)
      Chart                    - 30(+0)
      RTL                      - 27(+0)
      Writer: doc filter       - 22(+0)
      graphics stack           - 22(+1)
      Printing and PDF export  - 21(-1)
      BASIC                    - 18(+0)
      filters and storage      - 17(+0)
      Formula Editor           - 2(+0)
      framework                - 1(+0)
      sdk                      - 1(+0)


More information about the LibreOffice mailing list