skia and bigendian

Rene Engelhard rene at debian.org
Sat Jun 11 17:38:17 UTC 2022 

Hi,

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b06663135f9c7c08f5866a87a1fb0932df5af8bd

did

--- snip ---
enable Skia on big-endian too
Without this the build will #error out, and despite the disclaimer
it reportedly works fine.
https://lists.freedesktop.org/archives/libreoffice/2022-May/088838.html

Change-Id: I0e87b31647fe5107bca9b58d8f4af5fc0c67cd65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134032
Tested-by: Jenkins
--- snip ---

and I followed suit in Debians packages (where bigendian got a 
--disable-skia before).

Since 7.4.0 beta1 (which is the first pre-release to actually contain 
this, and in the meanwhile skia got updated) this results in:

[...]
S=/<<PKGBUILDDIR>> && I=$S/instdir && W=$S/workdir &&  mkdir -p 
$W/CxxObject/external/skia/source/ 
$W/Dep/CxxObject/external/skia/source/ && cd /<<PKGBUILDDIR>> &&   	 
clang++ -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED 
-DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DS390X -DUNIX 
-DUNX -D_FORTIFY_SOURCE=2 -D_PTHREADS -D_REENTRANT -Wdate-time 
-Wdate-time -D_FORTIFY_SOURCE=2 -DSKIA_IMPLEMENTATION=1 -DSKIA_DLL 
-DSK_USER_CONFIG_HEADER="<$S/config_host/config_skia.h>"  -DSYSTEM_ZLIB 
-DZLIB_CONST  -flto=thin -fvisibility=hidden         -Wall 
-Wno-missing-braces -Wnon-virtual-dtor -Wendif-labels -Wextra -Wundef 
-Wunreachable-code -Wshadow -Wunused-macros -finput-charset=UTF-8 
-fmessage-length=0 -fno-common -pipe -Wdeprecated-copy-dtor 
-Wduplicated-cond -Wlogical-op -Wshift-overflow=2 
-Wunused-const-variable=1 -Wno-cast-function-type 
-fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual 
-std=c++17 -pthread -g1 -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security 
-DEXCEPTIONS_ON -fexceptions -O2 -w -DLIBO_INTERNAL_ONLY  -c 
$S/external/skia/source/skia_compiler.cxx -o 
$W/CxxObject/external/skia/source/skia_compiler.o -MMD -MT 
$W/CxxObject/external/skia/source/skia_compiler.o -MP -MF 
$W/Dep/CxxObject/external/skia/source/skia_compiler.d_ -I$S/include 
-I/usr/lib/jvm/default-java/include 
-I/usr/lib/jvm/default-java/include/linux -I$S/config_host     -isystem 
/usr/include/freetype2 -isystem /usr/include/libpng16     -isystem 
/usr/include/uuid -isystem /usr/include/freetype2 -isystem 
/usr/include/libpng16          -isystem /usr/include/libpng16 
-I$W/UnpackedTarball/skia 
-I$W/UnpackedTarball/skia/include/third_party/skcms/ 
-I$W/UnpackedTarball/skia/third_party/vulkanmemoryallocator/ 
-I$W/UnpackedTarball/skia/include/third_party/vulkan/ 
-I$S/external/skia/inc/   && mv 
$W/Dep/CxxObject/external/skia/source/skia_compiler.d_ 
$W/Dep/CxxObject/external/skia/source/skia_compiler.d
[build CXX] external/skia/source/skia_opts.cxx
S=/<<PKGBUILDDIR>> && I=$S/instdir && W=$S/workdir &&  mkdir -p 
$W/CxxObject/external/skia/source/ 
$W/Dep/CxxObject/external/skia/source/ && cd /<<PKGBUILDDIR>> &&   	 
clang++ -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED 
-DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DS390X -DUNIX 
-DUNX -D_FORTIFY_SOURCE=2 -D_PTHREADS -D_REENTRANT -Wdate-time 
-Wdate-time -D_FORTIFY_SOURCE=2 -DSKIA_IMPLEMENTATION=1 -DSKIA_DLL 
-DSK_USER_CONFIG_HEADER="<$S/config_host/config_skia.h>"  -DSYSTEM_ZLIB 
-DZLIB_CONST  -flto=thin -fvisibility=hidden         -Wall 
-Wno-missing-braces -Wnon-virtual-dtor -Wendif-labels -Wextra -Wundef 
-Wunreachable-code -Wshadow -Wunused-macros -finput-charset=UTF-8 
-fmessage-length=0 -fno-common -pipe -Wdeprecated-copy-dtor 
-Wduplicated-cond -Wlogical-op -Wshift-overflow=2 
-Wunused-const-variable=1 -Wno-cast-function-type 
-fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual 
-std=c++17 -pthread -g1 -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security 
-DEXCEPTIONS_ON -fexceptions -O2 -w -DLIBO_INTERNAL_ONLY  -c 
$S/external/skia/source/skia_opts.cxx -o 
$W/CxxObject/external/skia/source/skia_opts.o -MMD -MT 
$W/CxxObject/external/skia/source/skia_opts.o -MP -MF 
$W/Dep/CxxObject/external/skia/source/skia_opts.d_ -I$S/include 
-I/usr/lib/jvm/default-java/include 
-I/usr/lib/jvm/default-java/include/linux -I$S/config_host     -isystem 
/usr/include/freetype2 -isystem /usr/include/libpng16     -isystem 
/usr/include/uuid -isystem /usr/include/freetype2 -isystem 
/usr/include/libpng16          -isystem /usr/include/libpng16 
-I$W/UnpackedTarball/skia 
-I$W/UnpackedTarball/skia/include/third_party/skcms/ 
-I$W/UnpackedTarball/skia/third_party/vulkanmemoryallocator/ 
-I$W/UnpackedTarball/skia/include/third_party/vulkan/ 
-I$S/external/skia/inc/   && mv 
$W/Dep/CxxObject/external/skia/source/skia_opts.d_ 
$W/Dep/CxxObject/external/skia/source/skia_opts.d
[build CXX] workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp
In file included from 
/<<PKGBUILDDIR>>/external/skia/source/skia_opts.cxx:15:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/core/SkOpts.h:13:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/core/SkRasterPipeline.h:12:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:12:
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/core/SkColorType.h:61:6: 
error: "SK_*32_SHIFT values must correspond to BGRA or RGBA byte order"
     #error "SK_*32_SHIFT values must correspond to BGRA or RGBA byte order"
      ^
test -f 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp 
|| (echo "Missing generated source file 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp" 
&& false)
[build CXX] workdir/UnpackedTarball/skia/src/codec/SkAndroidCodec.cpp
S=/<<PKGBUILDDIR>> && I=$S/instdir && W=$S/workdir &&  mkdir -p 
$W/GenCxxObject/UnpackedTarball/skia/src/codec/ 
$W/Dep/GenCxxObject/UnpackedTarball/skia/src/codec/ && cd 
/<<PKGBUILDDIR>> &&   	  clang++ -DBOOST_ERROR_CODE_HEADER_ONLY 
-DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG 
-DOSL_DEBUG_LEVEL=0 -DS390X -DUNIX -DUNX -D_FORTIFY_SOURCE=2 -D_PTHREADS 
-D_REENTRANT -Wdate-time -Wdate-time -D_FORTIFY_SOURCE=2 
-DSKIA_IMPLEMENTATION=1 -DSKIA_DLL 
-DSK_USER_CONFIG_HEADER="<$S/config_host/config_skia.h>"  -DSYSTEM_ZLIB 
-DZLIB_CONST  -flto=thin -fvisibility=hidden         -Wall 
-Wno-missing-braces -Wnon-virtual-dtor -Wendif-labels -Wextra -Wundef 
-Wunreachable-code -Wshadow -Wunused-macros -finput-charset=UTF-8 
-fmessage-length=0 -fno-common -pipe -Wdeprecated-copy-dtor 
-Wduplicated-cond -Wlogical-op -Wshift-overflow=2 
-Wunused-const-variable=1 -Wno-cast-function-type 
-fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual 
-std=c++17 -pthread -g1 -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security 
-DEXCEPTIONS_ON -fexceptions -O2 -w -DLIBO_INTERNAL_ONLY  -c 
$W/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp -o 
$W/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.o 
-MMD -MT 
$W/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.o 
-MP -MF 
$W/Dep/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.d_ 
-I$S/include -I/usr/lib/jvm/default-java/include 
-I/usr/lib/jvm/default-java/include/linux -I$S/config_host     -isystem 
/usr/include/freetype2 -isystem /usr/include/libpng16     -isystem 
/usr/include/uuid -isystem /usr/include/freetype2 -isystem 
/usr/include/libpng16          -isystem /usr/include/libpng16 
-I$W/UnpackedTarball/skia 
-I$W/UnpackedTarball/skia/include/third_party/skcms/ 
-I$W/UnpackedTarball/skia/third_party/vulkanmemoryallocator/ 
-I$W/UnpackedTarball/skia/include/third_party/vulkan/ 
-I$S/external/skia/inc/   && mv 
$W/Dep/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.d_ 
$W/Dep/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.d
1 error generated.
make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:334: 
/<<PKGBUILDDIR>>/workdir/CxxObject/external/skia/source/skia_opts.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp:8:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.h:10:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/codec/SkAndroidCodec.h:11:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/codec/SkCodec.h:15:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:12:
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/core/SkColorType.h:61:6: 
error: "SK_*32_SHIFT values must correspond to BGRA or RGBA byte order"
     #error "SK_*32_SHIFT values must correspond to BGRA or RGBA byte order"
      ^
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp:8:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.h:10:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/codec/SkAndroidCodec.h:11:
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/codec/SkCodec.h:21:
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/include/private/SkEncodedInfo.h:174:44: 
error: use of undeclared identifier 'kN32_SkColorType'
                                            kN32_SkColorType      ;
                                            ^
In file included from 
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.cpp:9:
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkCodecPriv.h:156:12: 
error: use of undeclared identifier 'SkEndianSwap16'
     return SkEndianSwap16(result);
            ^
/<<PKGBUILDDIR>>/workdir/UnpackedTarball/skia/src/codec/SkCodecPriv.h:170:12: 
error: use of undeclared identifier 'SkEndianSwap32'
     return SkEndianSwap32(result);
            ^
4 errors generated.
make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:404: 
/<<PKGBUILDDIR>>/workdir/GenCxxObject/UnpackedTarball/skia/src/codec/SkAndroidCodecAdapter.o] 
Error 1
[...]

Regards,

René

More information about the LibreOffice mailing list