Review requested: updated gcov/lcov report shell script

[Maarten Hoes]

Hi,


The modified version of the gcov/lcov report shell script [1] (in the
'buildbot' repo) has been reviewed, and received a '+2 code review'.
However, it has not been merged/committed yet.

I must confess I do not really understand what further steps are required
(of me) to make that happen ? I guess that 'normally', a successful build
with Jenkins needs to happen as well, but since this is a shell script this
is not really relevant here. Or perhaps someone (other than me) needs to
not only look at the code, but actually run the script to see if it works ?

Any and all help on the matter would be appreciated here.

Thanks,


- Maarten


[1]
https://gerrit.libreoffice.org/c/buildbot/+/135560



On Thu, Jun 9, 2022 at 5:55 PM Maarten Hoes <hoes.maarten at gmail.com> wrote:

> Hi,
>
>
> After my previous emails on the gcov/lcov code coverage subject on this
> list, I have modified the existing lcov html report generating script [1],
> and would like some feedback/reviewer on the modifications.
>
> The major changes compared to the previous version are:
>
> 1.)
> The script was reworked to make its usage simpler. The current script
> requires you to run the script multiple times, in multiple 'steps/phases',
> and for you to run a manual 'make check' in between these steps at some
> point. The new version only needs to be run once, and only needs flags to
> tell it where the sources are, where the report should go, etc. With the
> new version, you basically don't have to know anything about lcov/gcov,
> while the current version assumes you have a basic understanding of how
> lcov works / should be used.
>
> 2.)
> The order of the various steps in the script has been changed, to (more)
> correctly reflect how the lcov tool should be used (both the current script
> and the wiki page [4] get this wrong, I'm thinking about updating the wiki
> as well).
>
>
> Some open points and notes (which I should perhaps put in a 'NOTES' or
> 'TODO' file next to the actual shell script in git ?) are :
>
> 1.)
> The current build system tries to enforce building Skia with clang, which
> led to incompatibilities between clang and gcc [2]. But - intended or not -
> when clang is not installed, Skia gets built with gcc as fallback. The
> script currently does not verify if clang is indeed not installed, but will
> fail when parts of the build (Skia) get built with clang, and other parts
> with gcc.
>
> 2.)
> On my test system, 3 checks of 'make check' (specifically and only in
> combination with a 'gcov' build) fail when run on my PC (UITest_solver,
> CppunitTest_sccomp_solver, CppunitTest_sccomp_swarmsolvertest). It is
> currently assumed that the 'slowness' of my PC leads to timeouts, and
> running the tests on a faster system will resolve this issue [3]. This is
> currently not verified as I do not have a faster system at my disposal. As
> it currently stands, the script fails when 'make check' fails, and in that
> case no report is generated.
>
> 3.)
> The current directory in git for the script has a subdirectory called
> 'tinderbox', apparently with things for use with, well, a 'tinderbox'. I
> wonder how useful and/or relevant this still is ? I can't really remember
> much about this, even though 'git log' tells me I'm the author of the
> things in there. Is this something that still is relevant today and needs
> to be updated along with the new script, or can this safely be removed ?
>
>
> PS: Sorry, but as a result of my ferocious editing, the 'diff' between the
> old and new versions of the script are a bit of a mess, and doesn't really
> make sense anymore.
>
>
> - Maarten
>
>
> [1]
> https://gerrit.libreoffice.org/c/buildbot/+/135560
>
> [2]
> https://lists.freedesktop.org/archives/libreoffice/2022-May/088867.html
>
> [3]
> https://lists.freedesktop.org/archives/libreoffice/2022-June/088971.html
>
> [4]
> https://wiki.documentfoundation.org/Development/Lcov
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20220625/b553888b/attachment.htm>