ESC meeting minutes: 2022-11-17
Miklos Vajna
vmiklos at collabora.com
Thu Nov 17 15:26:32 UTC 2022
* Present:
+ Cloph, Olivier, Xisco, Caolan, Eike, Heiko, Hossein, Ilmari, Michael S, Stephan, Thorsten, Miklos, Stéphane
* Completed Action Items:
+ turn ‘Remove the feature for positioning of mouse on "Default Button"’ into an easy hack (Heiko)
* Pending Action Items:
+ create the Jenkins job for macOS arm64 (Cloph)
+ document how to get the Jenkins stats (Xisco)
* Release Engineering update (Cloph)
+ 7.4 status: 7.4.3 rc2 has been tagged yesterday
+ Revert "TempFile: clear handle on close" (Xisco)
+ only on master, not a huge deal, no need to worry about libreoffice-7-4 (Stephan)
+ OK to keep it in the branch
+ 7.5 release plan: https://wiki.documentfoundation.org/ReleasePlan/7.5
+ alpha next week
+ feature freeze in 3 weeks
* Documentation (Olivier)
+ New Help
+ fixed regression (ohallot)
+ Helpcontents 2
+ Updates and fixes (Bogdan B, ohallot, A. Romedenne)
+ Guides
+ Work in progress
+ Bugzilla Documentation statistics
237(237) bugs open
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
created 19(8) 40(4) 81(8) 310(6)
commented 47(22) 98(30) 211(27) 1238(33)
resolved 7(1) 16(0) 41(5) 200(4)
+ top 10 contributors:
Bogdan B made 88 changes in 1 month, and 89 changes in 1 year
Olivier Hallot made 19 changes in 1 month, and 460 changes in 1 year
Stéphane Guillou (stragu) made 19 changes in 1 month, and 24 changes in 1 year
Roman Kuznetsov made 18 changes in 1 month, and 49 changes in 1 year
Rafael Lima made 17 changes in 1 month, and 237 changes in 1 year
Heiko Tietze made 16 changes in 1 month, and 115 changes in 1 year
*UNKNOWN* made 7 changes in 1 month, and 7 changes in 1 year
Ilmari Lauhakangas made 5 changes in 1 month, and 90 changes in 1 year
m.a.riosv made 5 changes in 1 month, and 5 changes in 1 year
Nabet, Julien made 5 changes in 1 month, and 84 changes in 1 year
* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
276(276) (topicUI) bugs open, 78(78) (needsUXEval) needs to be evaluated by the UXteam
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
added 9(-4) 17(-9) 44(-8) 66(-9)
commented 67(-38) 208(-18) 641(0) 2310(-49)
removed 0(-2) 3(1) 9(-1) 34(-1)
resolved 8(-2) 23(5) 84(4) 322(0)
+ top 10 contributors:
Heiko Tietze made 128 changes in 1 month, and 1551 changes in 1 year
Eyal Rozenberg made 78 changes in 1 month, and 255 changes in 1 year
V Stuart Foote made 51 changes in 1 month, and 70 changes in 1 year
Dieter made 42 changes in 1 month, and 242 changes in 1 year
Rafael Lima made 31 changes in 1 month, and 219 changes in 1 year
Roman Kuznetsov made 30 changes in 1 month, and 206 changes in 1 year
Ilmari Lauhakangas made 16 changes in 1 month, and 161 changes in 1 year
Bogdan B made 15 changes in 1 month, and 40 changes in 1 year
Cor Nouws made 14 changes in 1 month, and 66 changes in 1 year
Stéphane Guillou (stragu) made 11 changes in 1 month, and 16 changes in 1y
+ [Bug 152078] Add button to Basic IDE to easily grow/shrink font height
+ [Bug 152066] Exporting .odp file to animated gif file showing all the slides
+ [Bug 152060] Field context menu needs "Update" entry
+ [Bug 152023] Ability to move entire submenu between menus in Tools > Customize
+ [Bug 152022] Improve Help Online (main0102.xhp)
+ [Bug 152035] Need ability to access info about a bookmark via its location
indication in the document
+ [Bug 151829] Writer TABLE: Optimal column width does not adjust columns that
are too wide
+ [Bug 152026] EDITING: Add a "Simple markup" view to Writer
+ [Bug 152030] Allow regular deletion of selection containing an entire
generated index/table
+ [Bug 152029] Visually draw attention to in-view bookmark when
selecting/hovering it in the Navigator
+ [Bug 152028] Ability to sort bookmarks by order of target in document
+ [Bug 151828] Table name should be retained, if table is cutted & pasted
+ [Bug 151827] ODBC Connection Wizard connects to a database
-> * Table name should be retained, if table is cutted & pasted
+ https://bugs.documentfoundation.org/show_bug.cgi?id=151828
+ cut/paste "Foo" becomes "Foo 1" but subsequent operation still "Foo 1"
* Crash Testing (Caolan)
+ 23(+1) import failure, 0(+0) export failures
- one sdt related one logged here, much of these appear related
- https://bugs.documentfoundation.org/show_bug.cgi?id=152038
+ 1 coverity issue
+ 8 ossfuzz issues
- 1 new crash, fix in gerrit
- 1 leak https://bugs.documentfoundation.org/show_bug.cgi?id=151930
* Crash Reporting (Xisco)
+ https://crashreport.libreoffice.org/stats/version/7.3.6.2
+ (-139) 657 796 797 802 695 605 523 391 313 139 0
+ https://crashreport.libreoffice.org/stats/version/7.3.7.2
+ (+638) 855 217 0
+ https://crashreport.libreoffice.org/stats/version/7.4.1.2
+ (-125) 855 980 948 1288 1676 1942 1653 1202 783 0
+ https://crashreport.libreoffice.org/stats/version/7.4.2.3
+ (+254) 1986 1732 1632 1253 650 0
* Easyhack update / mentoring (Hossein)
committer... 1 week 1 month 3 months 12 months
open 82(-4) 129(1) 134(-10) 138(-10)
reviews 458(100) 1160(60) 2920(66) 11842(60)
merged 237(-29) 1114(3) 3491(-73) 14763(-77)
abandoned 19(8) 67(7) 177(4) 850(7)
own commits 179(-24) 881(8) 2675(-66) 11356(-59)
review commits 85(1) 319(12) 761(41) 3061(29)
contributor... 1 week 1 month 3 months 12 months
open 63(11) 237(13) 242(-18) 258(-20)
reviews 858(32) 2848(114) 7834(-90) 32580(-42)
merged 33(-1) 98(15) 250(20) 1108(19)
abandoned 48(38) 70(42) 107(41) 418(39)
own commits 49(-1) 145(19) 300(41) 1061(38)
review commits 0(0) 0(0) 0(0) 0(0)
+ easyHack statistics:
needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 310(310)
total 371(371) assigned 20(20) open 320(320)
+ top 10 contributors:
Bogdan B made 37 patches in 1 month, and 37 patches in 1 year
Armin Le Grand (allotropia) made 14 patches in 1 month, and 27 patches in 1 year
Kevin Suo made 11 patches in 1 month, and 25 patches in 1 year
Paris Oplopoios made 10 patches in 1 month, and 10 patches in 1 year
made 6 patches in 1 month, and 19 patches in 1 year
Srebotnjak, Martin made 4 patches in 1 month, and 22 patches in 1 year
Emanuele Goldoni made 4 patches in 1 month, and 4 patches in 1 year
Omkar Acharekar made 4 patches in 1 month, and 5 patches in 1 year
Dr. David Alan Gilbert made 3 patches in 1 month, and 7 patches in 1 year
Batmunkh Dorjgotov made 2 patches in 1 month, and 4 patches in 1 year
+ top 10 reviewers:
Michael Stahl made 86 review comments in 1 month, and 1072 in 1 year
McNamara, Caolán made 84 review comments in 1 month, and 822 in 1 year
Vajngerl, Tomaž made 84 review comments in 1 month, and 404 in 1 year
Xisco Fauli made 80 review comments in 1 month, and 882 in 1 year
Vajna, Miklos made 72 review comments in 1 month, and 544 in 1 year
Adolfo Jayme Barrientos made 70 review comments in 1 month, and 1064 in 1 year
Nabet, Julien made 64 review comments in 1 month, and 778 in 1 year
Hossein made 64 review comments in 1 month, and 280 in 1 year
Olivier Hallot made 50 review comments in 1 month, and 694 in 1 year
Ilmari Lauhakangas made 48 review comments in 1 month, and 236 in 1 year
+ Patches automatically abandoned:
* Most of them are from Chris
vcl: followup "tdf#74702: cleans OutputDevice::DrawHatchLine up" ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/123432
vcl: extract GenerateHatchLinePoints() from DrawHatchLines() into Gradient ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/127140
tdf#43157 vcl: use SAL_WARN instead of OSL_ENSURE in OutputDevice::DrawHatch() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/127141
chart2: getOpenWidth() and getOpenHeight() to GetWidth/Height() in obvious case ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/137377
vcl: migrate IsMapModeEnabled() and EnableMapMode() to Geometry ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138042
vcl: migrate mnOutOffLogic{X|Y} to Geometry ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138043
vcl: rename GetOutputSizePixel() to GetSize() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138044
vcl: format vcl/source/outdev/map.cxx ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138046
vcl: migrate MappingMetrics to Geometry ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138047
vcl: move ImplCalcMapResolution() into MappingMetrics ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138048
vcl: remove ENTER1 and ENTER4 macros from map.cxx ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138049
vcl: migrate internal logical units to pixel and vice versa to Geometry ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138050
vcl: some minor whitespace changes to Geometry.cxx to make it easier to read ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138051
vcl: split conditional in ImplDrawText() to allow for method extraction ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138614
vcl: declare nFormatLines in scope it is used ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138617
vcl: extract lcl_DrawMnemonicLinesExceptLast() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138622
vcl: extract lcl_DrawMultilineText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138625
vcl: extract lcl_DrawSinglelineText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138626
vcl: bail out of function earlier if no text height ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138629
vcl: make DrawDeviceAlphaBitmap use pixel units ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138930
vcl: make OutputDevice::SetClipRegion() take pixel coordinates ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138931
vcl: make IntersectClipRegion() use pixel units ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138932
vcl: make DrawHatch(PolyPolygon, Hatch) use pixel units ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/138933
vcl: rename GetOutputRectPixel() to GetFrameRect() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139318
vcl: use SetFrameOffset() instead of SetOutOff{X|Y}Pixel() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139319
vcl: change mnOutOff{X|Y} to maFrameOffset ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139320
vcl: rename GetOutputSizePixel() to GetSize() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139321
vcl: remove OutputDevice::GetOutputSize() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139322
vcl: remove commented out code ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/139323
* From others:
Drop boost dependency for xmloff ( Hossein )
- https://gerrit.libreoffice.org/#/c/139277
- WIP, OK to be abandoned for now
cppuhelper : cleanup using osl namespace ( Arnaud Versini )
- https://gerrit.libreoffice.org/#/c/139373
tdf#147132: Flatten Basic function implementations ( Aleksa Savic )
- https://gerrit.libreoffice.org/#/c/139577
Add const modifier to function arguments. ( Stanislav Lopatin )
- https://gerrit.libreoffice.org/#/c/138222
tdf#150138: sw_odfimport: Add unittest ( Xisco Fauli )
- https://gerrit.libreoffice.org/#/c/138304
Add .gitreview used by git-review tool ( Michael Weghorn )
- https://gerrit.libreoffice.org/#/c/138340
tdf#148645 Extract integer value in places argument ( Hao Liu )
- https://gerrit.libreoffice.org/#/c/138352
fix ant related test for paths with non-ascii characters ( Christian Lohmaier )
- https://gerrit.libreoffice.org/#/c/138441
→ fine to abandon or rather: many other places in the build that wouldn't work with non-ascii characters in the path, so would only a first tiny step in fixing everything else around that... (cloph)
tdf#147566 Writer: use formatted search only from F&R dialog ( Jim Raykowski )
- https://gerrit.libreoffice.org/#/c/131569
changes to testwin11 ( )
- https://gerrit.libreoffice.org/#/c/135026
tdf#141712 PPTX export: fix hyperlink custom color ( Nagy Tibor )
- https://gerrit.libreoffice.org/#/c/138771
optimize converting old fonts by using constexpr ( Bartosz Kosiorek )
- https://gerrit.libreoffice.org/#/c/137508
tdf#147132 - Flatten Basic function implementations ( Robert Nyamugada )
- https://gerrit.libreoffice.org/#/c/137674
tdf#149915 Add unit test. ( Gülşah Köse )
- https://gerrit.libreoffice.org/#/c/137805
writerfilter: replace fake CELLX with real CELLX ( Michael Stahl )
- https://gerrit.libreoffice.org/#/c/137884
tdf#126008 Don't update table box formats on row/col insertion ( Matt K )
- https://gerrit.libreoffice.org/#/c/137915
+ big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
Xuan Chen (sakura286)
* 30 merged commits from the contributors
* New blog post on code formatting:
* Formatting the code in your patch for LibreOffice
https://dev.blog.documentfoundation.org/2022/11/17/formatting-the-code-in-your-patch-for-libreoffice/
* Commit Access
* Developer Certification (Stephan/Kendy/Thorsten/László)
+ resting since: 9 weeks (limit: 20 weeks)
* Jenkins / CI update (Cloph)
from:Thu Nov 10 14:56:51 2022
master linux rel jobs: 123 ok: 122 ko: 1 fail ratio: 0.81 % break: 1 broken duration: 0.00%
master linux dbg jobs: 105 ok: 102 ko: 2 fail ratio: 1.90 % break: 2 broken duration: 3.76%
master mac rel jobs: 103 ok: 103 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master mac dbg jobs: 99 ok: 99 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win rel jobs: 72 ok: 72 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win dbg jobs: 78 ok: 78 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win64 dbg jobs: 73 ok: 73 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master gerrit lin jobs: 438 ok: 337 ko: 69 fail ratio: 15.75% time for ok: mean: 21 median: 19
master gerrit plg jobs: 413 ok: 285 ko: 84 fail ratio: 20.34% time for ok: mean: 43 median: 42
master gerrit win jobs: 458 ok: 286 ko: 109 fail ratio: 23.80% time for ok: mean: 61 median: 57
master gerrit mac jobs: 455 ok: 290 ko: 123 fail ratio: 27.03% time for ok: mean: 35 median: 33
master android jobs: 413 ok: 365 ko: 17 fail ratio: 4.12% time for ok: mean: 26 median: 16
master gerrit all jobs: 425 ok: 205 ko: 151 fail ratio: 35.53% time for ok: mean: 82 median: 65
+ https://dev-www.libreoffice.org/tmp/gerrit_221117.html
+ tests that failed more than twice in last seven days:
3 CppunitTest_chart2_export3 gerrit_mac
3 CppunitTest_sc_subsequent_export_test2 gerrit_linux_gcc_release
3 CppunitTest_sw_a11y gerrit_windows
3 CppunitTest_sw_uiwriter2 gerrit_linux_gcc_release
4 CppunitTest_drawinglayer_processors gerrit_windows
4 CppunitTest_sc_subsequent_export_test2 gerrit_mac
6 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
+ added some mechanism to automatically disconnect a bot in case there is a failure to launch a process on Windows
+ already caught multiple instances of this kind of failure
+ re-enabled the resume of builds when the bot disconnected
+ had to restore the old rule
* What’s cooking (Miklos)
+ testcase refactors (Xisco)
+ most of the duplicate code in sc/ is now done
+ almost finished
+ PDF export watermarking can now be non-green (Miklos)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=145359 "Enter group: functionality to add an existing shape to a group is missing" (Jim Raykowski)
+ very nice little feature with a video
* QA update (Xisco)
+ UNCONFIRMED: 1794 (-33)
+ enhancements: 297 (-7)
+ needsUXEval: 23 (-11)
+ haveBackTrace: 7 (+0)
+ needsDevAdvice: 30 (+2)
+ documentation: 11 (-3)
+ android: 3 (+0)
+ iOS: 0 (+0)
+ Online: 11 (+0)
+ Most pressing bugs:
New:
+ LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from idle thread
+ https://bugs.documentfoundation.org/show_bug.cgi?id=148435
+ Lubos?
+ New high severity bugs of the week:
None
* QA stats (Stephane)
+ https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
+95 +15 (-112) overall)
many thanks to the top bug squashers:
Stéphane Guillou (stragu) 17
Heiko Tietze 9
QA Administrators 8
V Stuart Foote 8
Caolán McNamara 5
Eike Rathke 5
Kevin Suo 5
Alex Thurgood 4
Buovjaga 4
Gabor Kelemen (allotropia) 4
+ top 10 bugs reporters:
Hossein 10
Eyal Rozenberg 9
BogdanB 4
Kevin Suo 3
Mike Kaganski 2
NISZ LibreOffice Team 2
Stephen Morey 2
jcsanz 2
Daniel Collins 1
Justin L 1
+ top 10 bugs fixers:
McNamara, Caolán 5
Bogdan B 4
Kevin Suo 4
Rathke, Eike 4
Kelemen, Gabor 3
Németh, László 3
Olivier Hallot 2
Rafael Lima 2
Samuel Mehrbrodt 2
Vajna, Miklos 2
+ top 10 bugs confirmers:
Stéphane Guillou (stragu) 27
Heiko Tietze 12
Ilmari Lauhakangas 8
Raal 8
Dieter 7
m.a.riosv 7
Roman Kuznetsov 5
Bogdan B 4
*UNKNOWN* 2
Juan C. Sanz 2
* Highest-Priority bugs (aka "MABs"):
+ http://bit.ly/2lJAAJI
6.0 : 1/53 - 1 % (+0)
5.4 : 0/41 - 0 % (+0)
5.3 : 0/54 - 0 % (+0)
5.2 : 0/43 - 0 % (+0)
5.1 : 0/35 - 0 % (+0)
5.0 : 0/64 - 0 % (+0)
4.4 : 0/76 - 0 % (+0)
4.3 : 0/73 - 0 % (+0)
4.2 : 2/134 - 1 % (+0)
4.1 : 2/85 - 2 % (+0)
4.0 : 1/83 - 1 % (+0)
old : 1/246 - 0 % (+0)
* Bisected bugs open: keyword 'bisected'
+ more accurate - down to a single commit.
+ http://bit.ly/2dyIfDy
+
done by:
Stéphane Guillou (stragu) 2
Roman Kuznetsov 1
Ilmari Lauhakangas 1
Raal 1
* Bibisected bugs open: keyword 'bibisected'
+ http://bit.ly/2cSCXlS
+
done by:
Stéphane Guillou (stragu) 2
Roman Kuznetsov 1
Ilmari Lauhakangas 1
Raal 1
* all bugs tagged with 'regression'
+ 1183(+7) bugs open of 12130(+19) total 9(+1) high prio.
done by:
Stéphane Guillou (stragu) 6
m.a.riosv 3
Raal 3
Dieter 2
Németh, László 2
Hossein 1
Ilmari Lauhakangas 1
* ~Component count net * high severity regressions
+ http://bit.ly/1HWHb3E
Writer - 5(+0)
LibreOffice - 2(+1)
Calc - 1(+0)
Draw - 1(+0)
by OS:
All - 7(+0)
Linux - 0(+0)
Mac OS X - 0(+0)
Windows - 1(+0)
* ~Component count net * all regressions
+ http://bit.ly/1BUdI8i
Writer: other - 423(+1)
Calc - 198(+3)
Impress - 118(+1)
Writer: docx filter - 58(+1)
Crashes - 53(+0)
LibreOffice - 44(+0)
Base - 41(+2)
Draw - 40(-1)
UI - 36(+0)
Writer: perf - 36(+0)
Borders - 32(+0)
Writer: other filter - 31(+0)
Chart - 24(+0)
RTL - 23(+0)
Writer: doc filter - 19(+0)
BASIC - 17(+0)
Printing and PDF export - 15(+0)
filters and storage - 13(+0)
graphics stack - 13(+0)
Formula Editor - 3(+0)
sdk - 2(+0)
framework - 1(+0)
More information about the LibreOffice
mailing list