ESC meeting minutes: 2022-11-24

Miklos Vajna vmiklos at collabora.com
Thu Nov 24 15:44:45 UTC 2022


* Present:
     + Stéphane, Heiko, Ilmari, Cloph, Eike, Gabriel, Hossein, Stephan, Miklos, Xisco, Kendy, Michael S, Caolan, Thorsten

* Completed Action Items:
     + create the Jenkins job for macOS arm64 (Cloph)
       + but builds are not ran yet (daily tinderbox)
     + document how to get the Jenkins stats (Xisco)
       + Xisco now knows how to do it

* Pending Action Items:

* Release Engineering update (Cloph)
     + 7.4 status: 7.4.3 is released as final
       + app stores (macOS, Windows) need doing still
     + 7.5 release plan: https://wiki.documentfoundation.org/ReleasePlan/7.5
       + alpha1 to be tagged tomorrow
       + feature freeze in 2 weeks, also means the beta1
       + no late features are known at this time

* Documentation (Olivier)
     + Missing Olivier
     + Helpcontents2
        + Updates in menus descriptions (B. Buzea, R. Lima)
        + Fixes (erack, stragu)
     + Guides
        + Getting started 7.4 on the way (S. Masonsmith, K. Kriek)

     + Bugzilla Documentation statistics
         244(244) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created     14(-5)    45(5)     91(10)     320(10)
          commented     53(6)    145(47)   259(48)    1225(-13)
           resolved      4(-3)    19(3)     45(4)      203(3)
     + top 10 contributors:
           Bogdan B made 132 changes in 1 month, and 145 changes in 1 year
           Stéphane Guillou (stragu) made 29 changes in 1 month, and 34 changes in 1 year
           Olivier Hallot made 23 changes in 1 month, and 462 changes in 1 year
           Roman Kuznetsov made 22 changes in 1 month, and 53 changes in 1 year
           Heiko Tietze made 19 changes in 1 month, and 117 changes in 1 year
           Ilmari Lauhakangas made 13 changes in 1 month, and 98 changes in 1 year
           Rafael Lima made 10 changes in 1 month, and 233 changes in 1 year
           Kaganski, Mike made 8 changes in 1 month, and 116 changes in 1 year
           *UNKNOWN* made 7 changes in 1 month, and 7 changes in 1 year
           m.a.riosv made 5 changes in 1 month, and 5 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         275(275) (topicUI) bugs open, 74(74) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
              added      6(-3)    14(-3)    37(-7)      61(-5)
          commented     94(27)   247(39)   633(-8)    2310(0)
            removed      0(0)      3(0)      7(-2)      34(0)
           resolved     10(2)     27(4)     83(-1)     322(0)
     + top 10 contributors:
           Heiko Tietze made 177 changes in 1 month, and 1569 changes in 1 year
           Eyal Rozenberg made 72 changes in 1 month, and 231 changes in 1 year
           V Stuart Foote made 70 changes in 1 month, and 98 changes in 1 year
           Dieter made 30 changes in 1 month, and 234 changes in 1 year
           Bogdan B made 27 changes in 1 month, and 48 changes in 1 year
           Roman Kuznetsov made 23 changes in 1 month, and 191 changes in 1 year
           Cor Nouws made 21 changes in 1 month, and 73 changes in 1 year
           Stéphane Guillou (stragu) made 17 changes in 1 month, and 22 changes in 1 year
           Rafael Lima made 15 changes in 1 month, and 210 changes in 1 year
           Hossein made 11 changes in 1 month, and 74 changes in 1 year

      + 10 new tickets with needsUXEVal
        + [Bug 143886] Consider removing Attribute Blinking in Find and Replace dialog
        + [Bug 152157] Update Available icon (on InfoBar) messes up ability to work
               with multiple Calc windows
        + [Bug 145836] Unclear string 'Long Dot'
        + [Bug 152125] Ease use of Unicode control characters for bidirectionality,
               e.g. RLI and PDI
        + [Bug 152122] Improve Help Online (/text/shared/01/01010300.xhp)
        + [Bug 152115] Hyperlink Target in document: The last user setting is
               not remembered
        + [Bug 152116] Navigator: State of outline headings is lost when navigator
               is closed then reopened
        + [Bug 152111] Add a protection-against-deletion checkbox to table/index
               generation dialog
        + [Bug 152095] Enhancement request : adding 'Data - Refresh all ranges' command
        + [Bug 152075] Writer: TOC for chapter should start at current level+1,
                not current level

* Crash Testing (Caolan)
     + 24(+1) import failure, 1(+1) export failures
       - Gabor's efforts have made the turnaround here much shorter
     + 1 coverity issues
     + 5 ossfuzz issues

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.3.6.2
          + (-26) 631 657 796 797 802 695 605 523 391 313 139 0
    + https://crashreport.libreoffice.org/stats/version/7.3.7.2
          + (+395) 460 855 217 0
    + https://crashreport.libreoffice.org/stats/version/7.4.1.2
          + (60) 905 855 980 948 1288 1676 1942 1653 1202 783 0
    + https://crashreport.libreoffice.org/stats/version/7.4.2.3
          + (+62) 2048 1986 1732 1632 1253 650 0
    + nothing to report this week, looking forward to 7.4.3 results next week

* Easyhack update / mentoring (Hossein)
           committer...   1 week      1 month     3 months    12 months
                   open      43(-39)     104(-25)    109(-25)     114(-24)
                reviews     344(-114)   1182(22)    2890(-30)   11726(-116)
                 merged     295(58)     1187(73)    3483(-8)    14710(-53)
              abandoned      18(-1)       71(4)      188(11)      851(1)
            own commits     223(44)      905(24)    2665(-10)   11304(-52)
         review commits      78(-7)      319(0)      793(32)     2978(-83)
         contributor...   1 week     1 month     3 months     12 months
                   open     136(73)     224(-13)    226(-16)      242(-16)
                reviews     766(-92)   2888(40)    7690(-144)   32372(-208)
                 merged      44(11)     126(28)     260(10)      1088(-20)
              abandoned       5(-43)     65(-5)     109(2)        420(2)
            own commits      50(1)      172(27)     330(30)      1003(-58)
         review commits       0(0)        0(0)        0(0)          0(0)
     + easyHack statistics:
        needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 308(308)
        total 368(368)   assigned 18(18)   open 319(319)
     + top 10 contributors:
           Bogdan B made 61 patches in 1 month, and 61 patches in 1 year
           Armin Le Grand (allotropia) made 12 patches in 1 month, and 29 patches in 1 year
           Kevin Suo made 11 patches in 1 month, and 26 patches in 1 year
           Paris Oplopoios made 8 patches in 1 month, and 10 patches in 1 year
           Srebotnjak, Martin made 6 patches in 1 month, and 22 patches in 1 year
             made 6 patches in 1 month, and 19 patches in 1 year
           Skyler Grey made 5 patches in 1 month, and 5 patches in 1 year
           Emanuele Goldoni made 4 patches in 1 month, and 4 patches in 1 year
           Rashesh Padia made 3 patches in 1 month, and 4 patches in 1 year
           Nick Wingate made 3 patches in 1 month, and 4 patches in 1 year
     + top 10 reviewers:
           Michael Stahl made 98 review comments in 1 month, and 1070 in 1 year
           McNamara, Caolán made 96 review comments in 1 month, and 824 in 1 year
           Nabet, Julien made 80 review comments in 1 month, and 788 in 1 year
           Vajngerl, Tomaž made 76 review comments in 1 month, and 402 in 1 year
           Vajna, Miklos made 72 review comments in 1 month, and 534 in 1 year
           Adolfo Jayme Barrientos made 60 review comments in 1 month, and 1050 in 1 year
           Xisco Fauli made 58 review comments in 1 month, and 862 in 1 year
           Ilmari Lauhakangas made 56 review comments in 1 month, and 256 in 1 year
           Hossein made 54 review comments in 1 month, and 272 in 1 year
           Olivier Hallot made 54 review comments in 1 month, and 604 in 1 year
     + Patches automatically abandoned:
         vcl: begin test of DrawHatch() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/123431
         avoid vcl_pdfexport unit test failure. ( Justin Luth )
             - https://gerrit.libreoffice.org/#/c/134253
         vcl: _rLayout -> rLayout ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/138623
         vcl: make CalcHatchValues() a local function ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/139775
         shallow clone the help and translations repo ( Noel Grandin )
             - https://gerrit.libreoffice.org/#/c/139994
         WIP: openssl: Add patch to not quote "CC" since flags are currently set there ( Michael Weghorn )
             - https://gerrit.libreoffice.org/#/c/140068
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Jonas Eyov
           Siddharth Khattar
           Skyler Grey (Collabora)
           Leonid Ryzhov

* New Blog post:
   * gbuild: LibreOffice build system - part 1
     https://dev.blog.documentfoundation.org/?p=551&preview=1&_ppp=e11037f9cb
     To be published in the coming days

* Outreachy (Ilmari)
   + Two Outreachy interns selected for the Windows installer rework project: https://www.outreachy.org/alums/2022-12/
   + Marina is listed as "Marina - deneb_alpha - Latini" which looks odd (Caolán)
     + an IRC nick, nothing unusual (Michael S)
   + Hacking period starts on 5th Dec
   + Marina and Jussi is mentoring
   + What is the project about, technically? (Miklos)
     + want to rewrite it from scratch (Ilmari)
     + using wix toolset, with the help of https://github.com/jpakkane/msicreator
       + "This script generates MSI packages from a JSON description file and one or more staging directories"

* Commit Access
   > git shortlog -sn --author=<email> (Heiko)
     54  Kevin Suo
     + great work, with many reviewers
     + support the idea (Caolan)
     => no objections (all)
     AI: enable the permission (Cloph)
     AI: send the new-committer welcome mail (Heiko)

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 10 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
     from:Thu Nov 17 14:46:10 2022
     master linux rel  jobs: 109 ok: 108 ko:   1 fail ratio:  0.92 % break:   1 broken duration: 0.65%
     master linux dbg  jobs:  86 ok:  84 ko:   2 fail ratio:  2.33 % break:   2 broken duration: 1.63%
     master mac rel    jobs:  33 ok:  31 ko:   1 fail ratio:  3.03 % break:   1 broken duration:14.78%
     master mac dbg    jobs:  35 ok:  32 ko:   1 fail ratio:  2.86 % break:   1 broken duration:15.23%
     master win rel    jobs:  73 ok:  70 ko:   3 fail ratio:  4.11 % break:   2 broken duration: 3.82%
     master win dbg    jobs:  76 ok:  73 ko:   3 fail ratio:  3.95 % break:   2 broken duration: 1.59%
     master win64 dbg  jobs:  74 ok:  72 ko:   2 fail ratio:  2.70 % break:   2 broken duration: 0.92%
     master gerrit lin jobs: 561 ok: 467 ko:  53 fail ratio:  9.45% time for ok: mean:  25 median:  20
     master gerrit plg jobs: 537 ok: 351 ko: 129 fail ratio: 24.02% time for ok: mean:  48 median:  46
     master gerrit win jobs: 608 ok: 401 ko: 142 fail ratio: 23.36% time for ok: mean:  59 median:  52
     master gerrit mac jobs: 580 ok: 417 ko: 108 fail ratio: 18.62% time for ok: mean:  38 median:  34
     master android    jobs: 524 ok: 456 ko:  24 fail ratio:  4.58% time for ok: mean:  32 median:  23
     master gerrit all jobs: 573 ok: 288 ko: 209 fail ratio: 36.47% time for ok: mean:  88 median:  73
    + https://dev-www.libreoffice.org/tmp/gerrit_221124.html
    + tests that failed more than twice in last seven days
       3 CppunitTest_chart2_pivot_chart_test                gerrit_windows
       3 CppunitTest_oox_shape                gerrit_mac
       3 UITest_sw_sidebar                gerrit_linux_clang_dbgutil
       5 CppunitTest_sc_subsequent_export_test                gerrit_windows
       6 CppunitTest_sw_mailmerge                gerrit_windows
      15 CppunitTest_vcl_font                gerrit_windows
      23 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     + this week was OK (Cloph)
     + had 1 failing macOS builder
     + Windows bots now disable themselves, which is better than nothing
     + High number of builds that are aborted
       + not Linux only, also macOS
       + might have an idea (Caolan)
         + used gerrit to "bisect" a hang
         + some 12 patch sets can be attributed to that
         + let's revisit next week
     + macOS timeouts, is that not managed by kill-wrapper, correct? (Stephan)
       + that's correct (Cloph)
       + so no useful logs (Stephan)

* DPI/scaling-related test failures on Windows (Ilmari)
   + embeddedobj https://lists.freedesktop.org/archives/libreoffice/2022-November/089606.html
   + long chart labels https://lists.freedesktop.org/archives/libreoffice/2022-November/089607.html
   + can we do something in CI to prevent these types of problems slipping in?
     + adjust DPI scaling automatically? (Ilmari)
     + could force DPI to be 96? (Miklos)
       + Jenkins builders have no display (Cloph)
       + couldn't force a hidpi environment in the first place
   + what we already have (Ilmari)
     + more tolerance can be added
       + but with larger differences that will still fail (Hossein)
     + you can also return early in tests if DPI is not the default (Miklos)
       + IsDefaultDPI() can do that
   + if we have a way to let a Windows VM show up as hidpi, that could be done (Cloph)

* FOSDEM 2023 (Xisco)
   + 11th December is the deadline to submit talks:
   + submissions via pentabarf:  https://penta.fosdem.org/submission/FOSDEM23
   + please submit your talks (if you're coming) in 2 weeks
   + Link to blog post:

     https://blog.documentfoundation.org/blog/2022/11/08/fosdem-2023-cfp-libreoffice-technology-devroom/


* What’s cooking (Miklos)
     + testcase refactors (Xisco)
       + mostly done by now
     + macOS dark mode is now in master (Caolan)
       + much appreciated by macOS users in the design channel(s)
     + Writer layout xml dump improvement (Miklos)
       + content inside paragraphs was based on a11y API, decoupled now
       + handles e.g. ruby portions
     + Kevin has improvements around RTL text PDF import into Draw (Hossein)
       + testing patches left & right

* QA update (Xisco)
     + UNCONFIRMED: 1767 (-27)
         + enhancements: 291  (-6)
         + needsUXEval: 15 (-8)
         + haveBackTrace: 6 (-1)
         + needsDevAdvice: 31 (+1)
         + documentation:  12 (+1)
         + android:  3 (+0)
         + iOS:  0 (+0)
         + Online:  11 (+0)

     + Most pressing bugs:
      New:
          None
      Old:
         + LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from idle thread
             + https://bugs.documentfoundation.org/show_bug.cgi?id=148435
             + Fixed. Thanks to Noel Grandin
             + Verified by Steve

     + New high severity bugs of the week:

* QA stats (Stephane)
     + everything looks normal (Xisco)
     + interest in bugs that have a lot of duplicates? (Stephane)
       + normally it's one of the criteria to prioritize the bugs (Xisco)
       + if you have an old bug that has >5 duplicates and important, then increase the priority, and next week it'll show up here (Xisco)
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +117  -22 (-111) overall)
       many thanks to the top bug squashers:
        Stéphane Guillou (stragu) 15
        Buovjaga                10
        Heiko Tietze            10
        Caolán McNamara         8
        QA Administrators       8
        V Stuart Foote          6
        Rafael Lima             5
        Telesto                 5
        BogdanB                 4
        Tibor Nagy (NISZ)       3

     + top 10 bugs reporters:
        Hossein                 7
        Mike Kaganski           7
        BogdanB                 5
        NISZ LibreOffice Team   5
        Rafael Lima             3
        Regina Henschel         3
        Eyal Rozenberg          2
        R. Green                2
        Samuel Mehrbrodt (allotropia) 2
        Stéphane Guillou (stragu) 2

     + top 10 bugs fixers:
        McNamara, Caolán        7
        Bogdan B                4
        Rafael Lima             4
        Heiko Tietze            3
        Nagy Tibor              3
        Andreas Heinisch        2
        Balazs Varga            2
        Grandin, Noel           2
        Kaganski, Mike          2
        Kelemen, Gabor          2

     + top 10 bugs confirmers:
        Stéphane Guillou (stragu) 28
        Ilmari Lauhakangas      27
        Heiko Tietze            9
        m.a.riosv               8
        Bogdan B                5
        McNamara, Caolán        5
        Roman Kuznetsov         5
        V Stuart Foote          3
        *UNKNOWN*               2
        Dieter                  2


* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 1/53 -     1 %  (+0)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 0/35 -     0 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 2/85 -     2 %  (+0)
      4.0 : 1/83 -     1 %  (+0)
      old : 1/246 -    0 %  (+0)


* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Stéphane Guillou (stragu)   6
         Aron Budea                  3
         Ilmari Lauhakangas          3
         Roman Kuznetsov             2
         Raal                        2
         Hossein                     1


* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Ilmari Lauhakangas          4
         Stéphane Guillou (stragu)   4
         Roman Kuznetsov             2
         Aron Budea                  2
         Raal                        2
         Kelemen, Gabor              1


* all bugs tagged with 'regression'
    + 1187(+4) bugs open of 12144(+14) total 9(+0) high prio.

      done by:
         Ilmari Lauhakangas          4
         Stéphane Guillou (stragu)   3
         Roman Kuznetsov             2
         Raal                        2
         NISZ LibreOffice Team       1
         Kaganski, Mike              1


* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 5(+0)
      LibreOffice   - 2(+0)
      Calc          - 1(+0)
      Draw          - 1(+0)

    by OS:
      All           - 7(+0)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 1(+0)


* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 423(+0)
      Calc                     - 200(+2)
      Impress                  - 118(+0)
      Writer: docx filter      - 57(-1)
      Crashes                  - 53(+0)
      LibreOffice              - 46(+2)
      Base                     - 41(+0)
      Draw                     - 40(+0)
      UI                       - 36(+0)
      Writer: perf             - 36(+0)
      Borders                  - 31(-1)
      Writer: other filter     - 31(+0)
      Chart                    - 24(+0)
      RTL                      - 23(+0)
      Writer: doc filter       - 19(+0)
      BASIC                    - 17(+0)
      Printing and PDF export  - 15(+0)
      filters and storage      - 13(+0)
      graphics stack           - 13(+0)
      Formula Editor           - 3(+0)
      sdk                      - 2(+0)
      framework                - 1(+0)


More information about the LibreOffice mailing list