Test failure in embeddedobj on some Windows systems

[Stephan Bergmann]

On 30/11/2022 14:03, Mike Kaganski wrote:
> FTR: this issue has already surfaced once on the IRC, and I recall that 
> we tracked it down to the MS Paint OLE registration issues specific to 
> Windows 11 (the unit test uses the "mspaint data").

Oh my, thanks for reminding me, we'd already discussed the exact same 
issue on 2022-07-06:

> Jul 06 08:37:17 <sberg>	mikekaganski, I have a really odd error on Windows: after updating all kinds of software on the machine (latest Win 11 updates, VS 17.5.x micro-update,...), all builds (both MSVC and clang-cl, so unlikely related to the VS update) started to consistently fail CppunitTest_embeddedobj_msole with <https://paste.centos.org/view/254fee01>; trying to bisect this, however long I go back in time (I'm now at sometime in May, 
> Jul 06 08:37:17 <sberg>	when builds definitely still used to work for me), this keeps always failing exactly that way
> Jul 06 08:37:26 <sberg>	guess you haven't experienced something similar too?
> Jul 06 08:39:03 <mikekaganski>	sberg: no I haven't; I use Win10 and VS 2020 17.3.0 preview 2.0 - *if* that makes a difference. I'll try to run that test separately now.
> Jul 06 08:39:28 <mikekaganski>	sberg: is "VS 17.5.x" a typo?
> Jul 06 08:40:03 <sberg>	mikekaganski, yes, 17.2.5 is what I'm at now (and was some older 17.2.x before)
> Jul 06 08:40:42 <mikekaganski>	and on my side, 2020 is also a typo
> Jul 06 10:03:54 <mikekaganski>	sberg: sorry for not replying soon - I tested, and the test succeeded for me locally (as I expected).
> Jul 06 10:04:42 <sberg>	mikekaganski, thanks for checking; odd then why it suddenly started to fail for me...
> Jul 06 10:05:53 <mikekaganski>	sberg: it is failing for you exactly as the test expects; so I assume, debugging the accompanying fix could be useful?
> Jul 06 10:08:10 <sberg>	mikekaganski, oh indeed, I hadn't noticed that comment before
> Jul 06 15:14:27 <sberg>	mikekaganski, if you have a Windows build with SAL_LOG, can you pastebin your workdir/CppunitTest/embeddedobj_msole.test.log? maybe that'd give me a clue where things start to go differently for me
> Jul 06 15:16:11 <mikekaganski>	sberg: https://pastebin.com/eCFaeUPt - but I have no specific setup wrt SAL_LOG
> Jul 06 15:18:27 <sberg>	mikekaganski, thanks, exactly what I was hoping for (just needed all the SAL_WARN output)
> Jul 06 15:37:07 <sberg>	mikekaganski, so I'm hitting the RunObject() call from the fix at <https://gerrit.libreoffice.org/c/core/+/115236/2/embeddedobj/source/msole/olecomponent.cxx#1141>, but then within that call it hits the UnreachableStateException branch ("the object server is not installed") at <https://gerrit.libreoffice.org/c/core/+/115236/2/embeddedobj/source/msole/olecomponent.cxx#992>.  any idea what that would mean, and if that 
> Jul 06 15:37:07 <sberg>	might be a consequence of me applying whatever recent Win 11 and/or VS updates?
> Jul 06 15:37:08 <IZBot>	gerrit: »embeddedobj: handle getting the visible area on a thread« by Miklos Vajna for master [MERGED]
> Jul 06 15:49:48 <mikekaganski>	sberg: I'd suspect the "Win 11 updates", yes. The OLE object as I debug locally gives me m_clsidServer = {CLSID_Paintbrush Picture}
> Jul 06 15:50:25 <mikekaganski>	sberg: could them change something in latest Win11 to break paintbrush as OLE server?
> Jul 06 15:52:17 <mikekaganski>	sberg: https://forums.autodesk.com/t5/autocad-forum/ole-not-showing-in-windows-11/td-p/11083461
> Jul 06 15:54:42 <mikekaganski>	sberg: https://www.ptc.com/pt/support/article/cs366080
> Jul 06 15:55:38 <sberg>	mikekaganski, ha! thanks a lot for digging that out