New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
12 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1513477:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sc/source/core/data/table4.cxx: 2684 in ScTable::AutoFormat(short, int, short, int, unsigned short)()


________________________________________________________________________________________________________
*** CID 1513477:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sc/source/core/data/table4.cxx: 2684 in ScTable::AutoFormat(short, int, short, int, unsigned short)()
2678             if (nIndex == 13)
2679                 nIndex = 14;
2680             else
2681                 nIndex = 13;
2682         }
2683         // Body
>>>     CID 1513477:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     The "and" condition "pData->IsDataEqual(5, 6) && pData->IsDataEqual(9, 10) && pData->IsDataEqual(5, 9)" can never be true because "5" cannot be equal to two different values at the same time.
2684         if ((pData->IsDataEqual(5, 6)) && (pData->IsDataEqual(9, 10)) && (pData->IsDataEqual(5, 9)))
2685             AutoFormatArea(nStartCol + 1, nStartRow + 1, nEndCol-1, nEndRow - 1, *pPatternAttrs[5], nFormatNo);
2686         else
2687         {
2688             if ((pData->IsDataEqual(5, 9)) && (pData->IsDataEqual(6, 10)))
2689             {

** CID 1513476:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1513476:  Incorrect expression  (USELESS_CALL)
/sw/source/core/doc/DocumentContentOperationsManager.cxx: 2418 in sw::DocumentContentOperationsManager::MoveRange(SwPaM &, SwPosition &, SwMoveFlags)()
2412                 {
2413                     if (!pContentStore->Empty())
2414                     {
2415                         pContentStore->Restore(m_rDoc, pOrigNode->GetIndex()-SwNodeOffset(1), 0, true, false, eMode);
2416                     }
2417                 });
>>>     CID 1513476:  Incorrect expression  (USELESS_CALL)
>>>     Calling "pTNd->SplitContentNode(rPos, &restoreFunc)->GetTextNode()" is only useful for its return value, which is ignored.
2418             pTNd->SplitContentNode(rPos, &restoreFunc)->GetTextNode();
2419     
2420             //A new node was inserted before the orig pTNd and the content up to
2421             //rPos moved into it. The old node is returned with the remainder
2422             //of the content in it.
2423             //


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D21hF_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJipwFlDzYTbdjzaDCdMruSsJ4qVLr0RMLcpRxgwS9rYLOeDVmLbdx5gRKAC-2FhwmjbaqFMQ6ZI-2Bg9bVM2LpNZ6WxlhDNJXJOt8s9uvZZ-2Bxq8wsygfslQfRBbQUd-2Fxn59ZKv9pVniWwqu4YNy1Xy2MUZFEbzZaYFHCXb-2BD2JB9PZQZs-3D